Andrew Chow 27772d8009 Merge bitcoin/bitcoin#26889: refactor: wallet, remove global 'ArgsManager' dependency ...

52f4d567d6 refactor: remove <util/system.h> include from wallet.h (furszy)
6c9b342c30 refactor: wallet, remove global 'ArgsManager' access (furszy)
d8f5fc4462 wallet: set '-walletnotify' script instead of access global args manager (furszy)
3477a28dd3 wallet: set keypool_size instead of access global args manager (furszy)

Pull request description:

  Structurally, the wallet class shouldn't access the global `ArgsManager` class, its internal behavior shouldn't be coupled to a global command line args parsing object.

  So this PR migrates the only two places where we depend on it: (1) the keypool size, and (2) the "-walletnotify" script. And cleans up the, now unneeded, wallet `ArgsManager` ref member.

  Extra note:
  In the process of removing the args ref member, discovered and fixed files that were invalidly depending on the wallet header including `util/system.h`.

ACKs for top commit:
  achow101:
    ACK 52f4d567d6
  TheCharlatan:
    Re-ACK 52f4d567d6
  hebasto:
    re-ACK 52f4d567d6

Tree-SHA512: 0cffd99b4dd4864bf618aa45aeaabbef2b6441d27b6dbb03489c4e013330877682ff17b418d07aa25fbe1040bdf2c67d7559bdeb84128c5437bf0e6247719016

2023-02-17 12:47:52 -05:00

..

data

Add deserialize + CheckBlock benchmarks, and a full block hex

2016-11-09 11:27:59 -08:00

.gitignore

Ignore bench_bitcoin binary.

2015-10-06 17:46:12 +02:00

addrman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

base58.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bech32.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bench_bitcoin.cpp

Merge bitcoin/bitcoin#26481: bench: Suppress output when running with -sanity-check option

2022-12-29 11:42:03 +01:00

bench.cpp

Merge bitcoin/bitcoin#26481: bench: Suppress output when running with -sanity-check option

2022-12-29 11:42:03 +01:00

bench.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

block_assemble.cpp

Merge bitcoin/bitcoin#26695: bench: BlockAssembler on a mempool with packages

2023-01-11 18:11:11 -05:00

ccoins_caching.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

chacha20.cpp

Only support 32-byte keys in ChaCha20{,Aligned}

2023-01-30 18:12:21 -05:00

chacha_poly_aead.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

checkblock.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

checkqueue.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

coin_selection.cpp

refactor: wallet, remove global 'ArgsManager' access

2023-02-15 15:49:45 -03:00

crypto_hash.cpp

Merge bitcoin/bitcoin#15294: refactor: Extract RipeMd160

2023-01-30 09:49:01 +01:00

data.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

data.h

bench: Move generated data to a dedicated translation unit

2019-07-02 18:11:15 +01:00

descriptors.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

duplicate_inputs.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

examples.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

gcs_filter.cpp

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

hashpadding.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

load_external.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

lockedpool.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

logging.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

mempool_eviction.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

mempool_stress.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

merkle_root.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

nanobench.cpp

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

nanobench.h

Update nanobench to version v4.3.10

2023-02-03 07:08:28 +01:00

peer_eviction.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

poly1305.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

prevector.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

rollingbloom.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rpc_blockchain.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rpc_mempool.cpp

refactor: add kernel/cs_main.*

2023-01-05 09:05:14 +00:00

strencodings.cpp

bench: explicitly make all current benchmarks "high" priority

2022-10-20 10:21:04 -03:00

util_time.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

verify_script.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

wallet_balance.cpp

refactor: wallet, remove global 'ArgsManager' access

2023-02-15 15:49:45 -03:00

wallet_create_tx.cpp

refactor: wallet, remove global 'ArgsManager' access

2023-02-15 15:49:45 -03:00

wallet_loading.cpp

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00