bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-20 04:30:31 +01:00

Files

MacroFake 4d0c00dffd Merge bitcoin/bitcoin#25168 : refactor: Avoid passing params where not needed

fa1b76aeb0 Do not call global Params() when chainman is in scope (MacroFake)
fa30234be8 Do not pass CChainParams& to PeerManager::make (MacroFake)
fafe5c0ca2 Do not pass CChainParams& to BlockAssembler constructor (MacroFake)
faf012b438 Do not pass Consensus::Params& to Chainstate helpers (MacroFake)
fa4ee53dca Do not pass time getter to Chainstate helpers (MacroFake)

Pull request description:

  It seems confusing to pass chain params, consensus params, or a time function around when it is not needed.

  Fix this by:

  * Inlining the passed time getter function. I don't see a use case why this should be mockable.
  * Using `chainman.GetConsensus()` or `chainman.GetParams()`, where possible.

ACKs for top commit:
  promag:
    Code review ACK fa1b76aeb0.
  vincenzopalazzo:
    ACK fa1b76aeb0

Tree-SHA512: 1abff5cba4b4871d97f17dbcdf67bc9255ff21fa4150a79a74e39b28f0610eab3e7dee24d56872dd6e111f003b55e288958cdd467e6218368d896f191e4ec9cd

2022-05-20 13:35:15 +01:00

blockchain.cpp

Merge bitcoin/bitcoin#25168 : refactor: Avoid passing params where not needed

2022-05-20 13:35:15 +01:00

blockchain.h

…

client.cpp

…

client.h

…

external_signer.cpp

…