mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-13 14:13:52 +02:00
a9d181f2d3
d3d74e701fipc, refactor: Update mp::g_thread_context references (Ryan Ofsky)2d3f72fd3fipc, refactor: Update mp::SpawnProcess call (Ryan Ofsky)e9f19815caipc, refactor: Add Stream type alias and use it (Ryan Ofsky)3859805f05ipc, refactor: Add SocketId type alias and use it (Ryan Ofsky)2ee9b69c7aipc, refactor: Add ProcessId type alias and use it (Ryan Ofsky)3449797141ipc: Avoid 'unistd.h' error with MSVC (Ryan Ofsky)dbcc192dceipc, refactor: fix include order (Ryan Ofsky)7c86d4834eipc, refactor: use native path separators in test (Ryan Ofsky)00287b9a34ipc, refactor: Change Protocol class field order (Ryan Ofsky)33d37f3c35ipc, refactor: Drop connect/listen/serve exe_name parameters (Ryan Ofsky)794940469eipc, moveonly: combine ipc_test.cpp and ipc_tests.cpp (Ryan Ofsky) Pull request description: This PR makes Bitcoin Core changes needed to be compatible with https://github.com/bitcoin-core/libmultiprocess/pull/274, which changes the libmultiprocess API to stop using unix-specific types so it is compatible with windows. (Windows support is added in followups: https://github.com/bitcoin-core/libmultiprocess/pull/231 and https://github.com/bitcoin/bitcoin/pull/32387.) The PR uses some [compatibility shims](https://github.com/ryanofsky/bitcoin/blob/pr/ipc-wins/src/ipc/util.h) so it can be reviewed and merged without needing to merge https://github.com/bitcoin-core/libmultiprocess/pull/274 first and bump the libmultiprocess subtree. These can be deleted when the subtree is updated. --- Review note: All the changes here are refactoring, and you don't really need to know anything about IPC or Windows to review this code. It is also a mostly move-only change (131 lines added, 96 removed, 215 moved) ACKs for top commit: xyzconstant: tACKd3d74e701fenirox001: ACKd3d74e701fSjors: ACKd3d74e701fViniciusCestarii: re-ACKd3d74e701ftested locally on Linux Tree-SHA512: cd48708f9fd086ac8127dc75cfaf4bd8f8da81e07d11b2c9e65fd9061ffa33478bffc6fd6fa4b3505e86c6437752578fe6e5bd590c683c3bc9969093103a5608