MarcoFalke 1ff254e45c Merge bitcoin/bitcoin#26974: refactor: rpc: set TxToJSON default verbosity to SHOW_DETAILS ...

a24e633339 refactor: rpc: set TxToJSON default verbosity to SHOW_DETAILS (stickies-v)

Pull request description:

  `TxToJSON()` and `TxToUniv()` are only to be called when we want to decode the transaction (i.e. its details) into JSON. If `TxVerbosity` is `SHOW_TXID`, the function should not have been (and currently is not) called in the first place.

  There is no behaviour change, current logic simply assumes anything less than `TxVerbosity::SHOW_DETAILS_AND_PREVOUT` equals `TxVerbosity::SHOW_DETAILS`. With this change, the assumptions and intent become more explicit.

ACKs for top commit:
  w0xlt:
    ACK a24e633339

Tree-SHA512: b97235adae49b972bdbe10aca1438643fb35ec66a4e57166b1975b3015bc5a06a711feebe4453a8fefe71781e484b21ef80847d8e8a33694a3abcc863accd4d7

2023-01-31 18:22:19 +01:00

..

blockchain.cpp

Merge bitcoin/bitcoin#26900: refactor: Add BlockManager getters

2023-01-27 17:33:11 +01:00

blockchain.h

refactor: add kernel/cs_main.*

2023-01-05 09:05:14 +00:00

client.cpp

Merge bitcoin/bitcoin#26506: refactor: rpc: use convenience fn to auto parse non-string parameters

2023-01-18 13:12:09 +01:00

client.h

…

external_signer.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.cpp

rpc: Run type check against RPCArgs

2023-01-11 17:42:09 +01:00

mempool.cpp

rpc: Run type check against RPCArgs

2023-01-11 17:42:09 +01:00

mempool.h

…

mining.cpp

scripted-diff: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG

2023-01-22 15:01:48 +00:00

mining.h

…

net.cpp

Merge bitcoin/bitcoin#26727: rpc: remove optional from fStateStats fields

2023-01-18 12:48:22 +01:00

node.cpp

scripted-diff: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG

2023-01-22 15:01:48 +00:00

output_script.cpp

scripted-diff: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG

2023-01-22 15:01:48 +00:00

protocol.h

…

rawtransaction_util.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rawtransaction_util.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rawtransaction.cpp

refactor: rpc: set TxToJSON default verbosity to SHOW_DETAILS

2023-01-26 11:51:33 +00:00

register.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

request.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

request.h

…

server_util.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

server_util.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

server.cpp

scripted-diff: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG

2023-01-22 15:01:48 +00:00

server.h

…

signmessage.cpp

…

txoutproof.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

util.cpp

Merge bitcoin/bitcoin#26929: rpc: Throw more user friendly arg type check error (1.5/2)

2023-01-25 15:25:49 +00:00

util.h

Merge bitcoin/bitcoin#26929: rpc: Throw more user friendly arg type check error (1.5/2)

2023-01-25 15:25:49 +00:00