highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
b557a24be931ce24ab347dd487f0003544500a5d
bitcoin/src/bench
History
laanwj fe6a299fc0 Merge bitcoin/bitcoin#24852: util: optimize HexStr 
5e61532e72 util: optimizes HexStr (Martin Leitner-Ankerl)
4e2b99f72a bench: Adds a benchmark for HexStr (Martin Leitner-Ankerl)
67c8411c37 test: Adds a test for HexStr that checks all 256 bytes (Martin Leitner-Ankerl)

Pull request description:

  In my benchmark, this rewrite improves runtime 27% (g++) to 46% (clang++) for the benchmark `HexStrBench`:

  g++ 11.2.0
  |             ns/byte |              byte/s |    err% |        ins/byte |        cyc/byte |    IPC |       bra/byte |   miss% |     total | benchmark
  |--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:----------
  |                0.94 |    1,061,381,310.36 |    0.7% |           12.00 |            3.01 |  3.990 |           1.00 |    0.0% |      0.01 | `HexStrBench` master
  |                0.68 |    1,465,366,544.25 |    1.7% |            6.00 |            2.16 |  2.778 |           1.00 |    0.0% |      0.01 | `HexStrBench` branch

  clang++ 13.0.1
  |             ns/byte |              byte/s |    err% |        ins/byte |        cyc/byte |    IPC |       bra/byte |   miss% |     total | benchmark
  |--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:----------
  |                0.80 |    1,244,713,415.92 |    0.9% |           10.00 |            2.56 |  3.913 |           0.50 |    0.0% |      0.01 | `HexStrBench` master
  |                0.43 |    2,324,188,940.72 |    0.2% |            4.00 |            1.37 |  2.914 |           0.25 |    0.0% |      0.01 | `HexStrBench` branch

  Note that the idea for this change comes from denis2342 in #23364. This is a rewrite so no unaligned accesses occur.

  Also, the lookup table is now calculated at compile time, which hopefully makes the code a bit easier to review.

ACKs for top commit:
  laanwj:
    Code review ACK 5e61532e72
  aureleoules:
    tACK 5e61532e72.
  theStack:
    ACK 5e61532e72 🚤

Tree-SHA512: 40b53d5908332473ef24918d3a80ad1292b60566c02585fa548eb4c3189754971be5a70325f4968fce6d714df898b52d9357aba14d4753a8c70e6ffd273a2319
2022-05-04 20:36:09 +02:00
..
data
Add deserialize + CheckBlock benchmarks, and a full block hex
2016-11-09 11:27:59 -08:00
.gitignore
Ignore bench_bitcoin binary.
2015-10-06 17:46:12 +02:00
addrman.cpp
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
base58.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bech32.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bench_bitcoin.cpp
Use GetPathArg where possible
2022-03-02 12:09:27 +01:00
bench.cpp
bench: Represents paths with fs::path instead of std::string
2022-02-04 09:33:41 -05:00
bench.h
bench: Represents paths with fs::path instead of std::string
2022-02-04 09:33:41 -05:00
block_assemble.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
ccoins_caching.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chacha20.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chacha_poly_aead.cpp
Do not run functions with necessary side-effects in assert()
2020-12-06 00:48:09 +00:00
checkblock.cpp
Use spans of std::byte in serialize
2022-01-02 11:40:31 +01:00
checkqueue.cpp
test, bench: make prevector and checkqueue swap member functions noexcept
2022-04-28 20:34:43 +02:00
coin_selection.cpp
bench: fix incorrect named args in coin_selection bench
2022-03-25 21:27:39 +00:00
crypto_hash.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
data.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
data.h
bench: Move generated data to a dedicated translation unit
2019-07-02 18:11:15 +01:00
duplicate_inputs.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
examples.cpp
bench: Avoid deprecated use of volatile +=
2022-02-17 17:25:57 +01:00
gcs_filter.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
hashpadding.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
lockedpool.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
logging.cpp
bench: Add logging benchmark
2021-12-15 14:33:59 +01:00
mempool_eviction.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
mempool_stress.cpp
refactor: fix clang-tidy named args usage
2022-04-04 09:01:19 +01:00
merkle_root.cpp
Replace current benchmarking framework with nanobench
2020-06-13 12:24:18 +02:00
nanobench.cpp
Replace current benchmarking framework with nanobench
2020-06-13 12:24:18 +02:00
nanobench.h
bench: update nanobench from 4.3.4 to 4.3.6
2021-09-21 11:46:01 +02:00
peer_eviction.cpp
scripted-diff: Rename touched member variables
2021-12-13 13:32:08 +01:00
poly1305.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
prevector.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
rollingbloom.cpp
refactor: Remove deduplication of data in rollingbloom bench
2022-04-06 13:57:31 +01:00
rpc_blockchain.cpp
move-mostly: Make fHavePruned a BlockMan member
2022-04-19 14:34:56 -04:00
rpc_mempool.cpp
refactor: fix clang-tidy named args usage
2022-04-04 09:01:19 +01:00
strencodings.cpp
bench: Adds a benchmark for HexStr
2022-04-17 14:29:52 +02:00
util_time.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
verify_script.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
wallet_balance.cpp
refactor: fix clang-tidy named args usage
2022-04-04 09:01:19 +01:00
wallet_loading.cpp
bench: Add a benchmark for wallet loading
2022-04-18 17:02:57 -04:00