MeshCollider 2452c6cc0a Merge #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. ...

102faad81 Factor out combine / finalize / extract PSBT helpers (Glenn Willen)
78b9893d0 Remove op== on PSBTs; check compatibility in Merge (Glenn Willen)
bd0dbe876 Switch away from exceptions in refactored tx code (Glenn Willen)
c6c3d42a7 Move PSBT definitions and code to separate files (Glenn Willen)
81cd95884 Factor BroadcastTransaction out of sendrawtransaction (Glenn Willen)
c734aaa15 Split DecodePSBT into Base64 and Raw versions (Glenn Willen)
162ffefd2 Add pf_invalid arg to std::string DecodeBase{32,64} (Glenn Willen)

Pull request description:

  * Move most PSBT definitions into psbt.h.
  * Move most PSBT RPC utilities into psbt.{h,cpp}.
  * Move wallet-touching PSBT RPC utilities (FillPSBT) into
      wallet/psbtwallet.{h,cpp}.
  * Switch exceptions from JSONRPCError() to new PSBTException class.
  * Split DecodePSBT into DecodeBase64PSBT (old behavior) and DecodeRawPSBT.
  * Add one new version of DecodeBase64 utility in strencodings.h (and
      corresponding DecodeBase32 for completeness).
  * Factor BroadcastTransaction utility function out of sendrawtransaction RPC
      handler in rpc/rawtransaction.cpp

  Note: For those keeping score at home wondering why refactor, this is in anticipation of (and developed in parallel with) a change to actually introduce GUI use of all this stuff, which is already under development and working-ish.

Tree-SHA512: 2197c448e657421f430943025357597e7b06c4c377d5d4b2622b9edea52a7193c48843dd731abb3a88ac4023a9c88d211991e0a9b740c22f2e1cbe72adefe390

2019-02-14 21:49:01 +13:00

..

bytevectorhash.cpp

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

bytevectorhash.h

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

memory.h

…

moneystr.cpp

Use IsDigit(...) instead of std::isdigit

2018-11-06 17:32:08 +01:00

moneystr.h

Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.

2018-11-05 17:03:11 +01:00

strencodings.cpp

Add pf_invalid arg to std::string DecodeBase{32,64}

2019-02-11 12:23:14 -08:00

strencodings.h

Add pf_invalid arg to std::string DecodeBase{32,64}

2019-02-11 12:23:14 -08:00

system.cpp

util: Add SetupHelpOptions()

2019-02-06 14:16:43 -05:00

system.h

util: Add SetupHelpOptions()

2019-02-06 14:16:43 -05:00

time.cpp

Change in transaction pull scheduling to prevent InvBlock-related attacks

2019-02-06 20:25:27 -08:00

time.h

Change in transaction pull scheduling to prevent InvBlock-related attacks

2019-02-06 20:25:27 -08:00