bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-12 15:09:59 +01:00

Files

W. J. van der Laan 991753e4d5 Merge bitcoin/bitcoin#23118 : test: refactor: introduce script_util helper for creating P2PK scripts

429b49378e test: introduce script_util helper for creating P2PK scripts (Sebastian Falbesoner)

Pull request description:

  This PR is a follow-up to #22363, which took use of already existing `script_util` helpers to get rid of manual CScript for the P2{PKH,SH,WPKH,WSH} output types, in order to increase readability and maintainability of the test code. Here the same is done for P2PK scripts by introducing a helper `key_to_p2pk_script` and using it. Note that the helper only accepts ECDSA pubkeys (i.e. ones with a size of 33 or 65 bytes), hence it can't be used for scripts in the form of [x-only-pubkey, OP_CHECKSIG].

ACKs for top commit:
  brunoerg:
    Code review ACK 429b49378e
  laanwj:
    Code review ACK 429b49378e
  rajarshimaitra:
    Concept + tACK 429b49378e

Tree-SHA512: 984aea01eba5f38a328d69905d90a3a36f0a02419ca3e5baf3c8095895fb094e3780c7da16fad5851db3847bdb05ce8cda244ab09b79b8aa9602dfb3c5e0414c

2021-10-07 15:41:57 +02:00

__init__.py

…

address.py

test: refactor: remove hex_str_to_bytes helper

2021-08-01 19:26:51 +02:00

authproxy.py

test: Remove Windows workaround in authproxy

2021-09-25 09:33:16 +02:00

bdb.py

test: refactor: remove binascii from test_framework

2021-08-04 19:59:13 +01:00