highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-06 09:50:55 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/interfaces
History
Wladimir J. van der Laan 91af7ef831
Merge #19289: wallet: GetWalletTx and IsMine require cs_wallet lock 
b8405b833ad28351c80fb10f6f896f974013fd9e wallet: IsChange requires cs_wallet lock (João Barbosa)
d8441f30ff57e4ae98cff6694c995eaffc19c51a wallet: IsMine overloads require cs_wallet lock (João Barbosa)
a13cafc6c6998baedf3c5766259c21fcd763b99e wallet: GetWalletTx requires cs_wallet lock (João Barbosa)

Pull request description:

  This change removes some unlock/lock and lock/lock cases regarding `GetWalletTx` and `IsMine` overloads.

ACKs for top commit:
  laanwj:
    Code review ACK b8405b833ad28351c80fb10f6f896f974013fd9e
  ryanofsky:
    Code review ACK b8405b833ad28351c80fb10f6f896f974013fd9e. Just new commit since last review changing IsChange GetChange locks and adding annotations

Tree-SHA512: 40d37c4fe5d10a1407f57d899d5822bb285633d8dbfad8afcf15a9b41b428ed9971a9a7b1aae84318371155132df3002699a15dab56e004527d50c889829187d
2020-08-27 16:21:37 +02:00
..
chain.cpp
Add loadwallet and createwallet RPC load_on_startup options
2020-08-13 09:44:48 -04:00
chain.h
Add loadwallet and createwallet RPC load_on_startup options
2020-08-13 09:44:48 -04:00
handler.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
handler.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
node.cpp
gui: Partially revert #10244 gArgs and Params changes
2020-08-26 05:52:31 -04:00
node.h
gui: Partially revert #10244 gArgs and Params changes
2020-08-26 05:52:31 -04:00
README.md
…
wallet.cpp
wallet: IsMine overloads require cs_wallet lock
2020-08-17 00:06:03 +01:00
wallet.h
Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO
2020-07-02 16:10:49 +02:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.