bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-14 09:35:00 +01:00

Files

W. J. van der Laan 8f1c28a609 Merge bitcoin/bitcoin#21879 : refactor: wrap accept() and extend usage of Sock

6bf6e9fd9d net: change CreateNodeFromAcceptedSocket() to take Sock (Vasil Dimov)
9e3cbfca7c net: use Sock in CConnman::ListenSocket (Vasil Dimov)
f8bd13f85a net: add new method Sock::Accept() that wraps accept() (Vasil Dimov)

Pull request description:

  _This is a piece of https://github.com/bitcoin/bitcoin/pull/21878, chopped off to ease review._

  Introduce an `accept(2)` wrapper `Sock::Accept()` and extend the usage of `Sock` in `CConnman::ListenSocket` and `CreateNodeFromAcceptedSocket()`.

ACKs for top commit:
  laanwj:
    Code review ACK 6bf6e9fd9d
  jamesob:
    ACK 6bf6e9fd9d ([`jamesob/ackr/21879.2.vasild.wrap_accept_and_extend_u`](https://github.com/jamesob/bitcoin/tree/ackr/21879.2.vasild.wrap_accept_and_extend_u))
  jonatack:
    ACK 6bf6e9fd9d per `git range-diff ea989de 976f6e8 6bf6e9f` -- only change since my last review was `s/listen_socket.socket/listen_socket.sock->Get()/` in `src/net.cpp: CConnman::SocketHandlerListening()` -- re-read the code changes, rebase/debug build/ran units following my previous full review (https://github.com/bitcoin/bitcoin/pull/21879#pullrequestreview-761251278)
  w0xlt:
    tACK 6bf6e9f

Tree-SHA512: dc6d1acc4f255f1f7e8cf6dd74e97975cf3d5959e9fc2e689f74812ac3526d5ee8b6a32eca605925d10a4f7b6ff1ce5e900344311e587d19786b48c54d021b64

2022-01-05 15:32:53 +01:00

addition_overflow.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

addrman.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

asmap_direct.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

asmap.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

autofile.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

banman.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

base_encode_decode.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bech32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

block_header.cpp

…

block.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

blockfilter.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bloom_filter.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

buffered_file.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

chain.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

checkqueue.cpp

…

coins_view.cpp

policy: Treat taproot as always active

2021-11-16 08:20:33 +01:00

connman.cpp

Merge bitcoin/bitcoin#23636 : Remove GetAdjustedTime from init.cpp

2021-12-02 15:24:55 +01:00

crypto_aes256.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_aes256cbc.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_chacha20_poly1305_aead.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

crypto_chacha20.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Refactor the chacha20 differential fuzz test

2021-12-17 23:04:04 +05:30

crypto_hkdf_hmac_sha256_l32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_poly1305.cpp

…

crypto.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

cuckoocache.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

decode_tx.cpp

…

descriptor_parse.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

deserialize.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

eval_script.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fee_rate.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

flatfile.cpp

…

float.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fuzz.cpp

…

fuzz.h

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

FuzzedDataProvider.h

…

golomb_rice.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

Merge bitcoin/bitcoin#23411 : refactor: Avoid integer overflow in ApplyStats when activating snapshot

2022-01-05 10:34:29 +01:00

key_io.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

key.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

merkleblock.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

message.cpp

…

minisketch.cpp

fuzz: Add minisketch fuzz test

2021-11-16 19:18:05 +01:00

muhash.cpp

fuzz: Cleanup muhash fuzz target

2021-09-22 10:39:08 +02:00

multiplication_overflow.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

net_permissions.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

net.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

netaddress.cpp

…

netbase_dns_lookup.cpp

p2p, refactor: drop unused DNSLookupFn param in LookupSubnet()

2021-12-07 13:13:18 +01:00

node_eviction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

p2p_transport_serialization.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_numbers.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_script.cpp

…

parse_univalue.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

policy_estimator_io.cpp

…

policy_estimator.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

pow.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

prevector.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

primitives_transaction.cpp

…

process_message.cpp

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

process_messages.cpp

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

protocol.cpp

…

psbt.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

random.cpp

…

rbf.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rolling_bloom_filter.cpp

scripted-diff: Move bloom to src/common

2021-10-05 11:10:37 +02:00

rpc.cpp

fuzz: Fix RPC internal bug detection

2021-12-08 14:20:16 +01:00

script_assets_test_minimizer.cpp

Remove unused (and broken) functionality in SpanReader

2021-12-06 16:18:14 -05:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script_flags.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script_interpreter.cpp

…

script_ops.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

script_sigcache.cpp

…

script_sign.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

scriptnum_ops.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)

2021-09-30 14:21:17 +00:00

strprintf.cpp

…

system.cpp

fuzz: Fix memory leak in system fuzz target

2021-09-29 13:24:14 +02:00

timedata.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

torcontrol.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

transaction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

Remove CTxMemPool params from ATMP

2021-12-07 18:56:29 -03:00

txrequest.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

util.cpp

Merge bitcoin/bitcoin#21879 : refactor: wrap accept() and extend usage of Sock

2022-01-05 15:32:53 +01:00

util.h

Merge bitcoin/bitcoin#21879 : refactor: wrap accept() and extend usage of Sock

2022-01-05 15:32:53 +01:00

utxo_snapshot.cpp

Merge bitcoin/bitcoin#23413 : Replace MakeSpan helper with Span deduction guide

2021-12-03 10:44:37 +01:00

validation_load_mempool.cpp

…

versionbits.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00