mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-02 11:11:04 +02:00

History

W. J. van der Laan 95d19f8c1a

Merge bitcoin/bitcoin#16807 : Let validateaddress locate error in Bech32 address

88cc4810926e4f5af6757ee1b0eed61abda3d746 Modify copyright header on Bech32 code (Samuel Dobson)
5599813b80e53a1539c66625b4320ab1b4fb4848 Add lots of comments to Bech32 (Samuel Dobson)
2eb5792ec7bbeaf7138420b6c85c5cd0a0404946 Add release notes for validateaddress Bech32 error detection (MeshCollider)
42d6a029e57a32f2d1d829ff7718b6d40d58b9d1 Refactor and add more tests for validateaddress (Samuel Dobson)
c4979f77c1264f0099d1dfa278b1d9c18340b5f9 Add boost tests for bech32 error detection (MeshCollider)
02a7bdee429ae307a5e57832727fed789e2e04fb Add error_locations to validateaddress RPC (Samuel Dobson)
b62b67e06cc406fdad68da4c091168fb5f11c1d4 Add Bech32 error location function (Samuel Dobson)
0b06e720c0182dee8b560d2e8d3891b036f63ea7 More detailed error checking for base58 addresses (Samuel Dobson)

Pull request description:

  Addresses (partially) #16779 - no GUI change in this PR

  Adds a LocateError function the bech32 library, which is then called by `validateaddress` RPC, (and then eventually from a GUI tool too, future work). I think modifying validateaddress is nicer than adding a separate RPC for this.
  Includes tests.

  Based on https://github.com/sipa/bech32/blob/master/ecc/javascript/bech32_ecc.js
  Credit to sipa for that code

ACKs for top commit:
  laanwj:
    Code review and manually tested ACK 88cc4810926e4f5af6757ee1b0eed61abda3d746
  ryanofsky:
    Code review ACK 88cc4810926e4f5af6757ee1b0eed61abda3d746 with caveat that I only checked the new `LocateErrors` code to try to verify it didn't have unsafe or unexpected operations or loop forever or crash. Did not try to verify behavior corresponds to the spec. In the worst case bugs here should just affect error messages not actual decoding of addresses so this seemed ok.
  w0xlt:
    tACK 88cc481

Tree-SHA512: 9c7fe9745bc7527f80a30bd4c1e3034e16b96a02cc7f6c268f91bfad08a6965a8064fe44230aa3f87e4fa3c938f662ff4446bc682c83cb48c1a3f95cf4186688

2021-11-22 13:26:01 +01:00

man

scripted-diff: Fix typo in stub manual pages

2021-01-12 16:46:55 +01:00

release-notes

doc: Add historical release notes for 22.0

2021-09-14 13:20:48 +02:00

.gitignore

…

assets-attribution.md

…

assumeutxo.md

doc: add assumeutxo notes

2021-10-04 16:40:00 -04:00

benchmarking.md

doc: update doc/benchmarking.md

2021-06-24 11:15:29 +02:00

bips.md

doc: Add output script descriptors BIPs 380..386

2021-11-01 16:20:35 +02:00

bitcoin_logo_doxygen.png

…

bitcoin-conf.md

doc: added info to bitcoin.conf doc

2021-07-06 09:32:37 -04:00

build-android.md

doc: Add minimum supported Android NDK version

2021-11-10 18:51:33 +02:00

build-freebsd.md

docs: improve make with parallel jobs description.

2021-05-14 08:45:27 +08:00

build-netbsd.md

docs: improve make with parallel jobs description.

2021-05-14 08:45:27 +08:00

build-openbsd.md

script, doc: guix touchups

2021-07-23 21:23:37 +05:30

build-osx.md

doc: note that brew installed qt is not supported

2021-05-17 21:36:08 -04:00

build-unix.md

Fix Arch linux dead link

2021-11-14 23:50:11 +00:00

build-windows.md

doc: remove WSL install instructions and point to upstream

2021-09-17 11:24:55 +08:00

dependencies.md

build: require glibc 2.18+ for release builds

2021-11-16 07:51:24 +08:00

descriptors.md

Merge bitcoin/bitcoin#22067 : Test and document a basic M-of-N multisig using descriptor wallets and PSBTs

2021-10-18 16:17:45 +02:00

developer-notes.md

Improve fs::PathToString documentation

2021-11-15 12:08:49 -05:00

dnsseed-policy.md

…

Doxyfile.in

Generate doxygen documentation for test sources

2021-05-19 22:08:18 -07:00

external-signer.md

Move external signer out of wallet module

2021-04-08 17:56:00 +02:00

files.md

Ignore banlist.dat

2021-07-30 11:21:51 +02:00

fuzzing.md

Add a brief overview of fuzzing/Bitcoin Core fuzzing

2021-11-10 11:10:04 -07:00

guix.md

docs: Point to contrib/guix/README.md in doc/guix.md

2021-01-08 11:40:01 -05:00

i2p.md

Improve doc/i2p.md regarding I2P router options/versions

2021-08-19 15:41:46 +02:00

init.md

doc: Replace tabs for spaces

2021-02-04 12:06:13 +00:00

JSON-RPC-interface.md

Update 'Secure string handling'

2020-12-29 01:49:30 +05:30

managing-wallets.md

Document about wallet backup and restoration

2021-08-17 09:40:47 -03:00

multiprocess.md

multiprocess: Add comments and documentation

2021-04-23 03:02:50 -05:00

productivity.md

doc: Add libnatpmp stuff

2021-01-07 18:07:10 +02:00

psbt.md

doc: M-of-N multisig using descriptor wallets and PSBTs, as well as a signing flow

2021-08-16 10:43:07 +05:00

README_doxygen.md

…

README_windows.txt

…

README.md

doc: add assumeutxo notes

2021-10-04 16:40:00 -04:00

reduce-memory.md

doc: update reduce-memory.md peer connections info

2021-04-17 20:17:59 +02:00

reduce-traffic.md

doc: Use precise permission flags where possible

2020-07-10 15:37:42 +02:00

release-notes-16807.md

Add release notes for validateaddress Bech32 error detection

2021-10-12 12:03:14 +13:00

release-notes-23093.md

Add release notes for keypool flush changes

2021-09-26 15:35:54 +13:00

release-notes.md

Merge bitcoin/bitcoin#22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified)

2021-10-19 15:47:53 +02:00

release-process.md

build_msvc/bitcoin_config.h is generated using build_msvc/msvc-autogen.py

2021-11-14 15:00:29 +01:00

REST-interface.md

rpc: deprecate addresses and reqSigs from rpc outputs

2021-03-23 10:51:43 -04:00

shared-libraries.md

doc: libbitcoinconsensus: add missing error code description, fix NBitcoin link

2020-12-05 13:37:00 +01:00

tor.md

Merge bitcoin/bitcoin#22420 : doc: Specifiy how to set the value of TORGROUP

2021-09-16 20:17:01 +02:00

tracing.md

tracing: drop block_connected hash.toString() arg

2021-10-18 14:35:25 +02:00

translation_process.md

doc: Remove unnecessary steps from translations update process

2021-07-03 21:31:29 +02:00

translation_strings_policy.md

doc: Do not translate technical or extremely rare errors

2020-05-05 04:46:08 +03:00

zmq.md

doc: Add IPv6 address to zmq example

2021-06-20 16:56:08 +02:00

README.md

Bitcoin Core

Setup

Bitcoin Core is the original Bitcoin client and it builds the backbone of the network. It downloads and, by default, stores the entire history of Bitcoin transactions, which requires a few hundred gigabytes of disk space. Depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to a day or more.

To download Bitcoin Core, visit bitcoincore.org.

Running

The following are some helpful notes on how to run Bitcoin Core on your native platform.

Unix

Unpack the files into a directory and run:

bin/bitcoin-qt (GUI) or
bin/bitcoind (headless)

Windows

Unpack the files into a directory, and then run bitcoin-qt.exe.

macOS

Drag Bitcoin Core to your applications folder, and then run Bitcoin Core.

Need Help?

See the documentation at the Bitcoin Wiki for help and more information.
Ask for help on Bitcoin StackExchange.
Ask for help on #bitcoin on Libera Chat. If you don't have an IRC client, you can use web.libera.chat.
Ask for help on the BitcoinTalk forums, in the Technical Support board.

Building

The following are developer notes on how to build Bitcoin Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.

Development

The Bitcoin repo's root README contains relevant information on the development process and automated testing.

Resources

Discuss on the BitcoinTalk forums, in the Development & Technical Discussion board.
Discuss project-specific development on #bitcoin-core-dev on Libera Chat. If you don't have an IRC client, you can use web.libera.chat.

Miscellaneous

License

Distributed under the MIT software license.