Andrew Chow bc2b1f0fe2 Merge bitcoin/bitcoin#23549: Add scanblocks RPC call (attempt 2) ...

626b7c8493 fuzz: add scanblocks as safe for fuzzing (James O'Beirne)
94fe5453c7 test: rpc: add scanblocks functional test (Jonas Schnelli)
6ef2566b68 rpc: add scanblocks - scan for relevant blocks with descriptors (Jonas Schnelli)
a4258f6e81 rpc: move-only: consolidate blockchain scan args (James O'Beirne)

Pull request description:

  Revives #20664. All feedback from the previous PR has either been responded to inline or incorporated here.

  ---

  Major changes from Jonas' PR:
  - consolidated arguments for scantxoutset/scanblocks
  - substantial cleanup of the functional test

  Here's the range-diff (`git range-diff master jonasschnelli/2020/12/filterblocks_rpc jamesob/2021-11-scanblocks`): https://gist.github.com/jamesob/aa4a975344209f0316444b8de2ec1d18

  ### Original PR description

  > The `scanblocks` RPC call allows one to get relevant blockhashes from a set of descriptors by scanning all blockfilters in a given range.
  >
  > **Example:**
  >
  > `scanblocks start '["addr(<bitcoin_address>)"]' 661000` (returns relevant blockhashes for `<bitcoin_address>` from blockrange 661000->tip)
  >
  > ## Why is this useful?
  > **Fast wallet rescans**: get the relevant blocks and only rescan those via `rescanblockchain getblockheader(<hash>)[height] getblockheader(<hash>)[height])`. A future PR may add an option to allow to provide an array of blockhashes to `rescanblockchain`.
  >
  > **prune wallet rescans**: (_needs additional changes_): together with a call to fetch blocks from the p2p network if they have been pruned, it would allow to rescan wallets back to the genesis block in pruned mode (relevant #15946).
  >
  > **SPV mode** (_needs additional changes_): it would be possible to build the blockfilterindex from the p2p network (rather then deriving them from the blocks) and thus allow some sort of hybrid-SPV mode with moderate bandwidth consumption (related #9483)

ACKs for top commit:
  furszy:
    diff re-ACK 626b7c8

Tree-SHA512: f84e4dcb851b122b39e9700c58fbc31e899cdcf9b587df9505eaf1f45578cc4253e89ce2a45d1ff21bd213e31ddeedbbcad2c80810f46755b30acc17b07e2873

2022-10-13 10:48:16 -04:00

..

util

fuzz: pass max fee into ConsumeTxMemPoolEntry

2022-10-04 21:12:50 +01:00

addition_overflow.cpp

…

addrman.cpp

refactor: Use type-safe std::chrono for addrman time

2022-07-26 11:06:10 +02:00

asmap_direct.cpp

…

asmap.cpp

[netgroupman] Add GetMappedAS() and GetGroup()

2022-04-20 14:35:52 +01:00

autofile.cpp

Use AutoFile where possible

2022-06-29 10:33:13 +02:00

banman.cpp

…

base_encode_decode.cpp

Use std::string_view throughout util strencodings/string

2022-04-27 14:13:39 +02:00

bech32.cpp

…

bitdeque.cpp

fuzz: Avoid timeout in bitdeque fuzz target

2022-09-05 15:38:33 +02:00

block_header.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash()

2022-07-22 12:45:07 +02:00

checkqueue.cpp

test, bench: make prevector and checkqueue swap member functions noexcept

2022-04-28 20:34:43 +02:00

coins_view.cpp

fuzz: Remove useless GetUTXOStats fuzz case

2022-05-20 16:33:24 -04:00

connman.cpp

[net] Move asmap into NetGroupManager

2022-04-20 14:29:29 +01:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)

2022-04-26 10:41:45 +01:00

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

[net] Move asmap into NetGroupManager

2022-04-20 14:29:29 +01:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

Remove unused GetTimeSeconds

2022-05-11 16:39:23 +02:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

hex.cpp

util: Add ParseHex<std::byte>() helper

2022-04-27 19:53:17 +02:00

http_request.cpp

Use std::string_view throughout util strencodings/string

2022-04-27 14:13:39 +02:00

i2p.cpp

…

integer.cpp

fuzz: add util/mempool/h.cpp

2022-10-04 21:12:50 +01:00

key_io.cpp

…

key.cpp

script/sign: remove needless IsSolvable() utility

2022-08-11 15:43:40 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

refactor: Make mapBlocksUnknownParent local, and rename it

2022-07-18 12:06:14 -06:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

miniscript.cpp

miniscript: mark nodes with duplicate keys as insane

2022-05-30 15:16:43 +02:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

[net processing] Remove CNode::nLocalServices

2022-07-14 15:25:15 +02:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

[net] Add connection type to NodeEvictionCandidate

2022-07-04 14:58:43 +02:00

p2p_transport_serialization.cpp

…

parse_hd_keypath.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

fuzz: refactor: Replace NullUniValue with UniValue{}

2022-07-25 17:20:56 +02:00

policy_estimator_io.cpp

Use AutoFile where possible

2022-06-29 10:33:13 +02:00

policy_estimator.cpp

fuzz: add util/mempool/h.cpp

2022-10-04 21:12:50 +01:00

pow.cpp

fuzz: Remove no-op call to get()

2022-09-06 14:38:19 +02:00

prevector.cpp

test, bench: make prevector and checkqueue swap member functions noexcept

2022-04-28 20:34:43 +02:00

primitives_transaction.cpp

…

process_message.cpp

net: drop cs_sendProcessing

2022-09-15 14:44:42 +10:00

process_messages.cpp

net: drop cs_sendProcessing

2022-09-15 14:44:42 +10:00

protocol.cpp

…

psbt.cpp

Make DecodeBase{32,64} always return vector, not string

2022-04-27 14:12:55 +02:00

random.cpp

…

rbf.cpp

fuzz: add util/mempool/h.cpp

2022-10-04 21:12:50 +01:00

rolling_bloom_filter.cpp

…

rpc.cpp

fuzz: add scanblocks as safe for fuzzing

2022-10-04 13:51:35 -04:00

script_assets_test_minimizer.cpp

scripted-diff: Use getInt<T> over get_int/get_int64

2022-05-18 19:15:03 +02:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

refactor: merge ScriptPubKeyToUniv & ScriptToUniv into one function

2022-03-30 20:00:23 +01:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

tests: Reduce calls to InitS*Cache()

2022-08-03 12:02:31 -04:00

script_sign.cpp

refactor: Change * to & in MutableTransactionSignatureCreator

2022-05-04 11:49:29 +02:00

script.cpp

script/sign: remove needless IsSolvable() utility

2022-08-11 15:43:40 +02:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

fuzz: SplitString with multiple separators

2022-05-04 07:34:48 +02:00

strprintf.cpp

…

system.cpp

…

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

Remove ::g_max_datacarrier_bytes global

2022-08-02 15:29:16 +02:00

tx_in.cpp

…

tx_out.cpp

Move minRelayTxFee to policy/settings

2022-05-31 15:05:57 +02:00

tx_pool.cpp

fuzz: add util/mempool/h.cpp

2022-10-04 21:12:50 +01:00

txorphan.cpp

fuzz: Limit outpoints.size in txorphan target to avoid OOM

2022-09-30 16:52:01 +02:00

txrequest.cpp

…

util.cpp

Merge bitcoin/bitcoin#25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods

2022-10-12 15:49:02 -04:00

util.h

Merge bitcoin/bitcoin#25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods

2022-10-12 15:49:02 -04:00

utxo_snapshot.cpp

Require callers of AcceptBlockHeader() to perform anti-dos checks

2022-08-29 08:10:35 -04:00

validation_load_mempool.cpp

fuzz: add util/mempool/h.cpp

2022-10-04 21:12:50 +01:00

versionbits.cpp

…