Andrew Chow bc88f3ab90 Merge bitcoin/bitcoin#27997: Descriptors: rule out unspendable miniscript descriptors ...

c7db88af71 descriptor: assert we never parse a sane miniscript with no pubkey (Antoine Poinsot)
a49402a9ec qa: make sure we don't let unspendable Miniscript descriptors be imported (Antoine Poinsot)
639e3b6c97 descriptor: refuse to parse unspendable miniscript descriptors (Antoine Poinsot)
e3280eae1b miniscript: make GetStackSize() and GetOps() return optionals (Antoine Poinsot)

Pull request description:

  `IsSane()` in Miniscript does not ensure a Script is actually spendable. This is an issue as we would accept any sane Miniscript when parsing a descriptor. Fix this by explicitly checking a Miniscript descriptor is both sane and spendable when parsing it.

  This bug was exposed due to a check added in #22838 (https://github.com/bitcoin/bitcoin/pull/22838#discussion_r1226859880) that triggered a fuzz crash (https://github.com/bitcoin/bitcoin/pull/22838#issuecomment-1612510057).

ACKs for top commit:
  sipa:
    utACK c7db88af71
  achow101:
    ACK c7db88af71

Tree-SHA512: e79bc9f7842e98a4e8f358f05811fca51b15b4b80a171c0d2b17cf4bb1f578a18e4397bc2ece9817d392e0de0196ee6a054b7318441fd3566dd22e1f03eb64a5

2023-07-17 19:16:09 -04:00

..

bitcoinconsensus.cpp

…

bitcoinconsensus.h

…

descriptor.cpp

Merge bitcoin/bitcoin#27997: Descriptors: rule out unspendable miniscript descriptors

2023-07-17 19:16:09 -04:00

descriptor.h

…

interpreter.cpp

…

interpreter.h

…

keyorigin.h

…

miniscript.cpp

…

miniscript.h

…

script_error.cpp

…

script_error.h

…

script.cpp

…

script.h

…

sigcache.cpp

…

sigcache.h

…

sign.cpp

…

sign.h

…

signingprovider.cpp

…

signingprovider.h

…

standard.cpp

…

standard.h

…