highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-20 04:30:31 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
bda0b637b2d7ac343329c6a499b4c7b02541328d
bitcoin/src
History
MarcoFalke a3791da0e8 Merge bitcoin/bitcoin#22428: [Refactor] Rename scriptPubKey -> exec_script 
007910388b [Refactor] Rename scriptPubKey -> exec_script (sanket1729)

Pull request description:

  Rename scriptPubKey to witness_script in ExecuteWitnessScript() function to correctly reflect which script is being executed.

  For example in segwitv0, this scriptPubKey refers to the script of the form `OP_0 <script_hash>`, but witness_script refers to the script that actually hashes to the `script_hash`.

  If there is a reason why it's named this way, I would love to know

ACKs for top commit:
  MarcoFalke:
    review ACK 007910388b 🖖
  theStack:
    ACK 007910388b
  lsilva01:
    Code Review 007910388b ACK

Tree-SHA512: 768e10e656b60b1293beb560fb7adbc2c1495e6db1f54f0c2c63109692ae0c579c856b194b33f72afd0d332159a9796c0e2bd99b79ea5c4b1803469a81301fd6
2021-07-21 15:05:14 +02:00
..
bench
Merge bitcoin/bitcoin#22232: refactor: Pass interpreter flags as uint32_t instead of signed int
2021-07-20 15:36:23 +02:00
compat
Remove support for double serialization
2021-05-24 16:15:05 -07:00
config
…
consensus
Merge bitcoin/bitcoin#22232: refactor: Pass interpreter flags as uint32_t instead of signed int
2021-07-20 15:36:23 +02:00
crc32c
…
crypto
…
index
Move pblocktree global to BlockManager
2021-07-15 13:54:09 +02:00
init
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
interfaces
refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage
2021-06-16 10:48:58 +02:00
ipc
…
leveldb
…
logging
…
node
Merge bitcoin/bitcoin#22371: Move pblocktree global to BlockManager
2021-07-20 17:37:29 +02:00
policy
MOVEONLY: context-free package policies
2021-06-02 17:26:44 +01:00
primitives
…
qt
Merge bitcoin/bitcoin#21430: build: Add -Werror=implicit-fallthrough compile flag
2021-07-18 11:06:10 +08:00
rpc
Merge bitcoin/bitcoin#21934: RPC/blockchain: getblockchaininfo: Include versionbits signalling details during LOCKED_IN
2021-07-21 09:50:21 +02:00
script
Merge bitcoin/bitcoin#22428: [Refactor] Rename scriptPubKey -> exec_script
2021-07-21 15:05:14 +02:00
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#22505: addrman: Remove unused test_before_evict argument from Good()
2021-07-21 12:32:44 +08:00
univalue
…
util
build: Fix Boost Process compatibility with mingw-w64 compiler
2021-07-01 12:16:47 +03:00
wallet
Reorder dumpwallet so that cs_main functions go first
2021-07-19 12:25:11 -04:00
zmq
zmq: use msg: prefix over errno= in zmqError
2021-06-09 19:25:13 +08:00
.clang-format
…
addrdb.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
addrdb.h
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
addrman.cpp
scripted-diff: remove ResetI2PPorts() (revert e0a2b390c1)
2021-07-19 14:33:21 +02:00
addrman.h
[addrman] Remove unused test_before_evict argument from Good()
2021-07-20 16:17:51 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
banman.h
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
cli: Implement human readable -getinfo.
2021-07-21 19:27:04 +08:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: Pass grind args vector as const reference
2021-06-18 20:10:07 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Remove unused OptionsCategory arg from AddCommand
2021-06-18 20:09:23 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
doc: Various validation doc fixups
2021-06-03 13:53:31 +02:00
chainparams.cpp
Update assumed chain params
2021-07-19 19:34:30 +05:30
chainparams.h
net: distinguish default port per network
2021-07-09 11:19:36 +02:00
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
net: change I2P seeds' ports to 0
2021-07-09 11:19:35 +02:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
coins.h
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentinfo.h
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentstatus.cpp
scripted-diff: rename versionbitscache
2021-06-30 08:19:12 +10:00
deploymentstatus.h
Use DeploymentEnabled to hide VB deployments
2021-07-01 20:20:52 +02:00
dummywallet.cpp
…
external_signer.cpp
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
external_signer.h
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
refactor: Make httpserver work queue a unique_ptr
2021-06-28 11:47:05 +02:00
httpserver.h
…
i2p.cpp
net: do not connect to I2P hosts on port!=0
2021-07-09 11:19:37 +02:00
i2p.h
…
indirectmap.h
…
init.cpp
Move pblocktree global to BlockManager
2021-07-15 13:54:09 +02:00
init.h
init: remove straggling boost thread_group code
2021-07-12 21:46:59 +08:00
key_io.cpp
Separate WitnessV1Taproot variant in CTxDestination
2021-05-24 12:14:16 -07:00
key_io.h
…
key.cpp
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
key.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
logging.cpp
…
logging.h
…
Makefile.am
Merge bitcoin/bitcoin#22234: build: Mark print-% target as phony.
2021-07-18 13:41:24 +08:00
Makefile.bench.include
bench: add peer eviction protection benchmarks
2021-07-08 12:28:23 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
Makefile.qt_locale.include
…
Makefile.qt.include
Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always deterministic
2021-06-03 21:25:30 +08:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
fuzz: fix fuzz binary linking order
2021-06-16 10:41:24 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
miner.h
miner: Pass in chainman to RegenerateCommitments
2021-05-27 13:50:11 -04:00
net_permissions.cpp
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_permissions.h
Rate limit the processing of incoming addr messages
2021-07-15 12:52:38 -07:00
net_processing.cpp
Merge bitcoin/bitcoin#22096: p2p: AddrFetch - don't disconnect on self-announcements
2021-07-20 20:27:21 +08:00
net_processing.h
Add logging and addr rate limiting statistics
2021-07-15 13:03:20 -07:00
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#22096: p2p: AddrFetch - don't disconnect on self-announcements
2021-07-20 20:27:21 +08:00
net.h
Merge bitcoin/bitcoin#22096: p2p: AddrFetch - don't disconnect on self-announcements
2021-07-20 20:27:21 +08:00
netaddress.cpp
Merge bitcoin/bitcoin#22179: Torv2 removal followups
2021-07-08 17:20:35 +02:00
netaddress.h
Merge bitcoin/bitcoin#22211: net: relay I2P addresses even if not reachable (by us)
2021-07-15 16:53:34 +02:00
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
Disallow bech32m addresses for legacy wallet things
2021-06-22 21:57:04 -04:00
outputtype.h
Disallow bech32m addresses for legacy wallet things
2021-06-22 21:57:04 -04:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Replace memset calls with array initialization
2021-05-13 12:42:21 +01:00
protocol.h
Add roundtrip fuzz tests for CAddress serialization
2021-05-24 18:06:35 -07:00
psbt.cpp
Make GetInputUTXO safer: verify non-witness UTXO match
2021-06-12 12:25:28 -07:00
psbt.h
Construct and use PrecomputedTransactionData in PSBT signing
2021-06-12 12:25:28 -07:00
pubkey.cpp
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
pubkey.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
reverse_iterator.h
…
scheduler.cpp
test: Fix off-by-one in mockscheduler test RPC
2021-05-14 12:49:16 +02:00
scheduler.h
…
serialize.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
shutdown.cpp
…
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
…
streams.h
…
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
torcontrol.cpp
torcontrol: Resolve Tor control plane address
2021-06-27 19:27:25 +02:00
torcontrol.h
…
txdb.cpp
doc: add comment about CCoinsViewDBCursor constructor
2021-06-18 14:15:39 -04:00
txdb.h
move-only(ish): don't expose CCoinsViewDBCursor
2021-06-18 14:14:15 -04:00
txmempool.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
txmempool.h
[refactor] comment/naming improvements
2021-06-02 09:40:40 +01:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
Make XOnlyPubKey act like byte container
2021-05-24 12:14:16 -07:00
undo.h
…
validation.cpp
Move pblocktree global to BlockManager
2021-07-15 13:54:09 +02:00
validation.h
Move pblocktree global to BlockManager
2021-07-15 13:54:09 +02:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
versionbits.h
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…