mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-29 14:54:59 +02:00

Files

MarcoFalke 25ad2c623a Merge #18740 : Remove g_rpc_node global

b3f7f375ef refactor: Remove g_rpc_node global (Russell Yanofsky)
ccb5059ee8 scripted-diff: Remove g_rpc_node references (Russell Yanofsky)
6fca33b2ed refactor: Pass NodeContext to RPC and REST methods through util::Ref (Russell Yanofsky)
691c817b34 Add util::Ref class as temporary alternative for c++17 std::any (Russell Yanofsky)

Pull request description:

  This PR removes the `g_rpc_node` global, to get same benefits we see removing other globals and make RPC code more testable, modular, and reusable.

  This uses a hybrid of the approaches suggested in #17548. Instead of using `std::any`, which isn't available in c++11, or `void*`, which isn't type safe, it uses a small new `util::Ref` helper class, which acts like a simplified `std::any` that only holds references, not values.

  Motivation for writing this was to provide an simpler alternative to #18647 by Harris Brakmić (brakmic) which avoids some shortcomings of that PR (https://github.com/bitcoin/bitcoin/pull/18647#issuecomment-617878826)

ACKs for top commit:
  MarcoFalke:
    re-ACK b3f7f375ef, only change is adding back const and more tests 🚾
  ajtowns:
    ACK b3f7f375ef

Tree-SHA512: 56292268a001bdbe34d641db1180c215351503966ff451e55cc96c9137f1d262225d7d7733de9c9da7ce7d7a4b34213a98c2476266b58c89dbbb0f3cb5aa5d70

2020-05-21 06:53:39 -04:00

chain.cpp

Merge #18922 : gui: Do not translate InitWarning messages in debug.log

2020-05-13 20:30:39 +02:00

chain.h

gui: Do not translate InitWarning messages in debug.log

2020-05-10 18:01:28 +03:00

handler.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

handler.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

node.cpp

Merge #18740 : Remove g_rpc_node global

2020-05-21 06:53:39 -04:00

node.h

refactor: Pass SynchronizationState enum to GUI

2020-05-19 02:49:32 +03:00

README.md

Suggested interfaces::Chain cleanups from #15288

2019-03-04 15:57:58 -05:00

wallet.cpp

Merge #18587 : gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged

2020-05-20 11:09:29 +02:00

wallet.h

Merge #18587 : gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged

2020-05-20 11:09:29 +02:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.