merge-script ab2df1726e Merge bitcoin/bitcoin#31917: fuzz: provide more realistic values to the base58(check) decoders ...

d5537c18a9 fuzz: make sure DecodeBase58(Check) is called with valid values more often (Lőrinc)
bad1433ef2 fuzz: Always restrict base conversion input lengths (Lőrinc)

Pull request description:

  This is a follow-up to https://github.com/bitcoin/bitcoin/pull/30746, expanding coverage by:
  * restricting every input for the base58 conversions, capping max sizes to `100` instead of `1000` or all available input (suggested by marcofleon in https://github.com/bitcoin/bitcoin/pull/30746#discussion_r1963718683) since most actual usage has lengths of e.g. `21`, `34`, `78`.
  * providing more valid values to the decoder (suggested by maflcko in https://github.com/bitcoin/bitcoin/pull/30746#discussion_r1957847712) by randomly providing a random input or a valid encoded one; this also enables unifying the roundtrip tests to a single roundtrip per fuzz.

ACKs for top commit:
  mzumsande:
    Code Review / lightly tested ACK d5537c18a9
  maflcko:
    review ACK d5537c18a9 🚛

Tree-SHA512: 50365654cdac8a38708a7475eaa43396642b7337e2ee8999374c3faafff4f05457abc1a54c701211e0ed24d36c12af77bcad17b49695699be42664f2be660659

2025-03-16 17:02:58 +08:00

..

util

fuzz: in FuzzedSock::GetSockName(), return a random-length name

2025-02-12 11:39:37 -05:00

addition_overflow.cpp

…

addrman.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

base_encode_decode.cpp

fuzz: make sure DecodeBase58(Check) is called with valid values more often

2025-03-05 22:30:28 +01:00

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index.cpp

…

block.cpp

…

blockfilter.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

[checkqueue] support user-defined return type through std::optional

2024-12-02 16:25:13 -05:00

cluster_linearize.cpp

…

CMakeLists.txt

fuzz: implement targets for PCP and NAT-PMP port mapping requests

2025-02-12 11:39:37 -05:00

coins_view.cpp

coins, refactor: Split up AddFlags to remove invalid states

2024-12-02 13:48:04 +01:00

coinscache_sim.cpp

…

connman.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

…

feeratediagram.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

refactor: Avoid GCC false positive error

2025-01-20 17:43:58 +01:00

fuzz.cpp

test: Exclude SeedStartup from coverage counts

2025-02-25 10:15:00 +01:00

fuzz.h

…

FuzzedDataProvider.h

fuzz: add cstdlib to FuzzedDataProvider

2024-12-09 17:01:10 +00:00

golomb_rice.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

headerssync.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

integer.cpp

…

key_io.cpp

…

key.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

kitchen_sink.cpp

…

load_external_block_file.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

miner: bugfix: fix duplicate weight reservation in block assembler

2025-02-04 11:53:03 -05:00

miniscript.cpp

refactor: Drop deprecated space in operator""_mst

2024-11-11 12:14:08 +01:00

minisketch.cpp

…

muhash.cpp

Add a fuzz test for Num3072 multiplication and inversion

2025-01-09 10:11:46 -05:00

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

netaddress.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

overflow.cpp

fuzz: Add fuzz test for checked and saturating add and left shift

2025-01-15 15:44:03 +01:00

p2p_handshake.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

p2p_headers_presync.cpp

Remove checkpoints

2025-03-13 11:13:13 +00:00

p2p_transport_serialization.cpp

…

package_eval.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

Remove checkpoints

2025-03-13 11:13:13 +00:00

pcp.cpp

fuzz: implement targets for PCP and NAT-PMP port mapping requests

2025-02-12 11:39:37 -05:00

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

process_messages.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

protocol.cpp

…

psbt.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

random.cpp

…

rbf.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

rolling_bloom_filter.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

rpc.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

script_assets_test_minimizer.cpp

doc: Adjust path in comment

2025-03-13 11:47:41 +00:00

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_parsing.cpp

…

script_sigcache.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

span.cpp

…

string.cpp

…

strprintf.cpp

refactor: Introduce struct to hold a runtime format string

2025-01-15 12:16:08 +01:00

system.cpp

…

timeoffsets.cpp

…

torcontrol.cpp

…

transaction.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

txdownloadman.cpp

[fuzz] TxOrphanage::SanityCheck accounting

2025-02-07 13:55:57 -05:00

txorphan.cpp

fuzz: add basic TxOrphanage::EraseForBlock cov

2025-02-20 14:00:21 -05:00

txrequest.cpp

[fuzz] GetCandidatePeers

2025-01-29 18:05:16 -05:00

util.cpp

util: Implement ParseISO8601DateTime based on C++20

2024-12-02 08:21:32 +01:00

util.h

refactor: Reserve vectors in fuzz tests

2024-11-25 20:09:44 +01:00

utxo_snapshot.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

utxo_total_supply.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

validation_load_mempool.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

vecdeque.cpp

…

versionbits.cpp

…