fanquake 4fefd80f08 Merge #19704: Net processing: move ProcessMessage() to PeerLogicValidation ...

daed542a12 [net_processing] Move ProcessMessage to PeerLogicValidation (John Newbery)
c556770b5e [net_processing] Change PeerLogicValidation to hold a connman reference (John Newbery)

Pull request description:

  Rather than ProcessMessage() being a static function in net_processing.cpp, make it a private member function of PeerLogicValidation. This is the start of moving static functions and global variables into PeerLogicValidation to make it better encapsulated.

ACKs for top commit:
  jonatack:
    ACK daed542a12 code review and debug tested
  promag:
    Code review ACK daed542a12.
  MarcoFalke:
    re-ACK daed542a12, only change is removing second commit 🎴
  theStack:
    Code Review ACK daed542a12

Tree-SHA512: ddebf410d114d9ad5a9e536950018ff333a347c035d74fcc101fb4a3f20a281782c7eac2b7d1bd1c8f6bc7e59f5b5630fb52c2e1b4c32df454fa584673bd021e

2020-08-24 21:50:37 +08:00

..

addition_overflow.cpp

…

addrdb.cpp

fuzz: fix unused variable addrdb compiler warning

2020-07-19 08:31:34 +02:00

asmap_direct.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

asmap.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

autofile.cpp

tests: Add fuzzing harness for CAutoFile (streams.h)

2020-07-15 11:41:21 +00:00

banman.cpp

tests: Add fuzzing harness for BanMan

2020-07-08 05:31:43 +00:00

base_encode_decode.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

bech32.cpp

…

block_header.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

block.cpp

tests: Fill fuzzing coverage gaps for functions in consensus/validation.h

2020-05-14 18:45:42 +00:00

blockfilter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

bloom_filter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

buffered_file.cpp

refactor: Drop unused CBufferedFile::Seek()

2020-07-26 22:46:28 +03:00

chain.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

checkqueue.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

coins_view.cpp

rpc: gettxoutsetinfo can specify hash_type (only legacy option for now)

2020-06-22 00:55:44 +02:00

crypto_aes256.cpp

tests: Add fuzzing harness for AES256Encrypt/AES256Decrypt

2020-06-25 15:06:13 +00:00

crypto_aes256cbc.cpp

tests: Add fuzzing harness for AES256CBCEncrypt/AES256CBCDecrypt

2020-06-25 15:06:13 +00:00

crypto_chacha20_poly1305_aead.cpp

tests: Add fuzzing harness for ChaCha20Poly1305AEAD

2020-06-25 15:06:13 +00:00

crypto_chacha20.cpp

tests: Add fuzzing harness for ChaCha20

2020-06-25 15:06:13 +00:00

crypto_common.cpp

tests: Add fuzzing harness for {Read,Write}{LE,BE}{16,32,64} (crypto/common.h)

2020-06-11 14:05:54 +00:00

crypto_hkdf_hmac_sha256_l32.cpp

tests: Add fuzzing harness for CHKDF_HMAC_SHA256_L32

2020-06-25 15:06:13 +00:00

crypto_poly1305.cpp

tests: Add fuzzing harness for poly1305_auth(...)

2020-06-25 15:06:13 +00:00

crypto.cpp

Make Hash[160] consume range-like objects

2020-07-30 13:57:54 -07:00

cuckoocache.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

decode_tx.cpp

refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o)

2020-06-24 18:41:45 +02:00

descriptor_parse.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

deserialize.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

eval_script.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

fee_rate.cpp

…

fees.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

flatfile.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

float.cpp

…

fuzz.cpp

tests: Provide main(...) function in fuzzer

2020-06-25 21:03:27 +00:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

hex.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

http_request.cpp

tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests

2020-06-02 11:53:08 +00:00

integer.cpp

Merge #18413: script: prevent UB when computing abs value for num opcode serialize

2020-05-02 21:24:05 +08:00

key_io.cpp

…

key.cpp

Make Hash[160] consume range-like objects

2020-07-30 13:57:54 -07:00

kitchen_sink.cpp

refactor: Error message bilingual_str consistency

2020-06-09 15:39:44 +02:00

load_external_block_file.cpp

tests: Add fuzzing harness for LoadExternalBlockFile(...) (validation.h)

2020-07-15 11:41:21 +00:00

locale.cpp

util: remove unused c-string variant of atoi64()

2020-08-17 17:56:59 +02:00

merkleblock.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

message.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

multiplication_overflow.cpp

…

net_permissions.cpp

Add addr permission flag enabling non-cached addr sharing

2020-07-30 14:38:50 +03:00

netaddress.cpp

tests: Add ConsumeSubNet(...). Move and increase coverage in ConsumeNetAddr(...).

2020-07-08 05:05:12 +00:00

p2p_transport_deserializer.cpp

net: Use mockable time for ping/pong, add tests

2020-06-19 07:25:36 -04:00

parse_hd_keypath.cpp

tests: Add fuzzing coverage for FormatHDKeypath(...) and WriteHDKeypath(...)

2020-04-26 20:23:56 +00:00

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

policy_estimator_io.cpp

tests: Add fuzzing harness for CBlockPolicyEstimator::{Read,Write} (policy/fees.h)

2020-07-15 11:41:21 +00:00

policy_estimator.cpp

tests: Add fuzzing harness for CBlockPolicyEstimator::{Read,Write} (policy/fees.h)

2020-07-15 11:41:21 +00:00

pow.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

prevector.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

primitives_transaction.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

process_message.cpp

[net_processing] Move ProcessMessage to PeerLogicValidation

2020-08-21 13:10:41 +01:00

process_messages.cpp

[net/refactor] Add AddrFetch connections to ConnectionType enum

2020-08-07 17:18:16 -07:00

protocol.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

psbt.cpp

psbt: Allow both non_witness_utxo and witness_utxo

2020-06-24 16:31:42 -04:00

random.cpp

…

rbf.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

rolling_bloom_filter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

script_bitcoin_consensus.cpp

tests: Add fuzzing harness for functions in script/bitcoinconsensus.h

2020-05-30 10:37:01 +00:00

script_descriptor_cache.cpp

tests: Add fuzzing harness for functions in script/descriptor.h

2020-05-30 10:37:01 +00:00

script_flags.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

script_interpreter.cpp

tests: Add fuzzing harness for functions in script/interpreter.h

2020-05-30 10:37:01 +00:00

script_ops.cpp

…

script_sigcache.cpp

tests: Add fuzzing harness for functions in script/sigcache.h

2020-05-30 10:37:01 +00:00

script_sign.cpp

tests: Add fuzzing harness for functions in script/sign.h

2020-05-30 10:37:01 +00:00

script.cpp

Replace usage of GetScriptForWitness with GetScriptForDestination

2020-08-14 08:44:42 +12:00

scriptnum_ops.cpp

fuzz: add missing overrides to signature_checker

2020-07-22 05:27:13 +02:00

signature_checker.cpp

fuzz: add missing overrides to signature_checker

2020-07-22 05:27:13 +02:00

span.cpp

Simplify usage of Span in several places

2020-05-12 14:19:40 -07:00

spanparsing.cpp

Simplify usage of Span in several places

2020-05-12 14:19:40 -07:00

string.cpp

tests: Fill fuzzing coverage gaps for functions in script/script.h, script/script_error.h and script/standard.h

2020-05-30 10:37:01 +00:00

strprintf.cpp

tests: Fill fuzzing coverage gaps for functions in util/translation.h

2020-05-14 18:52:57 +00:00

system.cpp

fuzz: fix vector size problem in system fuzzer

2020-05-08 20:21:48 +02:00

timedata.cpp

…

transaction.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

tx_in.cpp

…

tx_out.cpp

…

util.h

test: Fix fuzzer compilation on macOS

2020-07-21 15:23:49 -07:00