Ava Chow e9edd43a95 Merge bitcoin/bitcoin#32521: policy: make pathological transactions packed with legacy sigops non-standard ...

96da68a38f qa: functional test a transaction running into the legacy sigop limit (Antoine Poinsot)
367147954d qa: unit test standardness of inputs packed with legacy sigops (Antoine Poinsot)
5863315e33 policy: make pathological transactions packed with legacy sigops non-standard. (Antoine Poinsot)

Pull request description:

  The Consensus Cleanup soft fork proposal includes a limit on the number of legacy signature
  operations potentially executed when validating a transaction. If this change is to be implemented
  here and activated by Bitcoin users in the future, we should make transactions that are not valid
  according to the new rules non-standard first because it would otherwise be a trivial DoS to
  potentially unupgraded miners after the soft fork activates.

  ML post: https://gnusha.org/pi/bitcoindev/49dyqqkf5NqGlGdinp6SELIoxzE_ONh3UIj6-EB8S804Id5yROq-b1uGK8DUru66eIlWuhb5R3nhRRutwuYjemiuOOBS2FQ4KWDnEh0wLuA=@protonmail.com/T/#u

ACKs for top commit:
  instagibbs:
    reACK 96da68a38f
  maflcko:
    review ACK 96da68a38f 🚋
  achow101:
    ACK 96da68a38f
  glozow:
    light code review ACK 96da68a38f, looks correct to me

Tree-SHA512: 106ffe62e48952affa31c5894a404a17a3b4ea8971815828166fba89069f757366129f7807205e8c6558beb75c6f67d8f9a41000be2f8cf95be3b1a02d87bfe9

2025-07-18 13:24:54 -07:00

..

crypto

test: create assert_not_equal util and add to where imports are needed

2025-04-01 08:39:24 -04:00

__init__.py

Rename rpc-tests directory to functional

2017-03-20 10:40:31 -04:00

address.py

test: check that keyless P2A 'signing' via signrawtransactionwithkey succeeds

2024-08-02 20:13:07 +02:00

authproxy.py

tests: Expand HTTP coverage to assert libevent behavior

2025-05-21 10:47:23 -04:00

bip340_test_vectors.csv

test: update BIP340 test vectors and implementation (variable-length messages)

2025-05-30 01:47:09 +02:00

blockfilter.py

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

blocktools.py

test: remove bare CBlockHeader .rehash()/.calc_sha256() calls

2025-07-17 11:59:09 +02:00

compressor.py

test: introduce output amount (de)compression routines

2025-03-04 12:50:17 -05:00

coverage.py

test: fix PEP484 no implicit optional argument types errors

2023-06-29 16:14:07 -06:00

descriptors.py

Output a descriptor in createmultisig and addmultisigaddress

2020-01-30 23:55:36 -05:00

key.py

test: update BIP340 test vectors and implementation (variable-length messages)

2025-05-30 01:47:09 +02:00

mempool_util.py

[functional test] orphan resolution works in the presence of DoSy peers

2025-07-14 16:13:47 -04:00

messages.py

test: rename CBlockHeader .hash -> .hash_hex for consistency

2025-07-17 12:45:35 +02:00

netutil.py

Merge bitcoin/bitcoin#31614: test: expect that files may disappear from /proc/PID/fd/

2025-02-10 15:58:09 -08:00

p2p.py

test: rename CBlockHeader .hash -> .hash_hex for consistency

2025-07-17 12:45:35 +02:00

psbt.py

test: add constants for MuSig2 PSBT key types (BIP 373)

2025-05-07 19:28:08 +02:00

script_util.py

Merge bitcoin/bitcoin#32521: policy: make pathological transactions packed with legacy sigops non-standard

2025-07-18 13:24:54 -07:00

script.py

test: remove bare CTransaction .rehash()/.calc_sha256() calls

2025-06-09 17:28:24 +02:00

segwit_addr.py

Use Bech32m encoding for v1+ segwit addresses

2021-03-16 10:48:36 -07:00

socks5.py

test: Avoid F541 (f-string without any placeholders)

2024-12-05 08:39:09 +01:00

test_framework.py

test: less ambiguous error if bitcoind is missing

2025-07-08 13:19:48 +02:00

test_node.py

test: Don't send empty named args with cli

2025-06-23 17:42:56 -04:00

test_shell.py

test: remove legacy wallet functional tests

2025-04-23 12:10:30 -07:00

util.py

Merge bitcoin/bitcoin#32509: qa: feature_framework_startup_failures.py fixes & improvements (#30660 follow-up)

2025-05-27 14:45:11 -07:00

v2_p2p.py

test: Check that disconnection happens when >4095 garbage bytes is sent

2024-06-21 19:37:13 +05:30

wallet_util.py

Fix typos in description.md and wallet_util.py

2024-04-25 16:14:10 +08:00

wallet.py

scripted-diff: test: rename CTransaction .getwtxid() -> wtxid_hex for consistency

2025-06-11 00:52:25 +02:00