mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-07-21 21:59:56 +02:00
4637cd157d
Check BlockCreateOptions before block template creation instead of clamping runtime values. This makes invalid runtime block creation options, including those passed by IPC mining clients, fail explicitly instead of silently mining with different values than the caller requested. Runtime option validation now uses the same error wording as startup option validation. Startup validation also rejects -blockmaxweight values lower than -blockreservedweight instead of allowing them to be clamped later. Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
38 lines
1.2 KiB
C++
38 lines
1.2 KiB
C++
// Copyright (c) The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_NODE_MINING_ARGS_H
|
|
#define BITCOIN_NODE_MINING_ARGS_H
|
|
|
|
#include <node/mining_types.h>
|
|
#include <util/result.h>
|
|
|
|
class ArgsManager;
|
|
|
|
namespace node {
|
|
|
|
static const bool DEFAULT_PRINT_MODIFIED_FEE = false;
|
|
|
|
/**
|
|
* Read the mining options set in \p args. Returns an error if one was
|
|
* encountered.
|
|
*/
|
|
[[nodiscard]] util::Result<BlockCreateOptions> ReadMiningArgs(const ArgsManager& args);
|
|
|
|
/** Check option values for validity. Returns an error for invalid values. */
|
|
[[nodiscard]] util::Result<void> CheckMiningOptions(BlockCreateOptions options, bool use_argnames);
|
|
|
|
/** Replace null optional values with their hardcoded defaults. */
|
|
[[nodiscard]] BlockCreateOptions FlattenMiningOptions(BlockCreateOptions options);
|
|
|
|
/**
|
|
* Merge two BlockCreateOptions structs, replacing null values in \p x with
|
|
* non-null values from \p y.
|
|
*/
|
|
[[nodiscard]] BlockCreateOptions MergeMiningOptions(BlockCreateOptions x, const BlockCreateOptions& y);
|
|
|
|
} // namespace node
|
|
|
|
#endif // BITCOIN_NODE_MINING_ARGS_H
|