bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-14 01:27:24 +02:00

Files

merge-script ce771726f3 Merge bitcoin/bitcoin#33960 : log: Use more severe log level (warn/err) where appropriate

fa45a1503e log: Use LogWarning for non-critical logs (MarcoFalke)
fa0018d011 log: Use LogError for fatal errors (MarcoFalke)
22229de728 doc: Fix typo in init log (MarcoFalke)

Pull request description:

  Logging supports severity levels above info via the legacy `LogPrintf`. So use the more appropriate `LogError` or `LogWarning`, where it applies.

  This has a few small benefits:

  * It often allows to remove the manual and literal "error: ", "Warning:", ... prefixes. Instead the uniform log level formatting is used.
  * It is easier to grep or glance for more severe logs, which indicate some kind of alert.
  * `LogPrintf` didn't indicate any severity level, but it is an alias for `LogInfo`. So having the log level explicitly spelled out makes it easier to read the code.
  * Also, remove the redundant trailing `\n` newline, while touching.
  * Also, remove the `__func__` formatting in the log string, which is redundant with `-logsourcelocations`. Instead, use a unique log string for each location.

ACKs for top commit:
  l0rinc:
    Code review ACK fa45a1503e
  stickies-v:
    ACK fa45a1503e
  rkrux:
    crACK fa45a1503e

Tree-SHA512: 516d439c36716f969c6e82d00bcda03c92c8765a9e41593b90052c86f8fa3a3dacbb2c3dc98bfc862cefa54cae34842b488671a20dd86cf1d15fb94aa5563406

2025-12-02 13:35:16 +00:00

fees

log: Use LogWarning for non-critical logs

2025-11-27 14:33:59 +01:00

ephemeral_policy.cpp

validation: use wtxid instead of txid in CheckEphemeralSpends

2025-03-11 16:00:46 +00:00

ephemeral_policy.h

validation: use wtxid instead of txid in CheckEphemeralSpends

2025-03-11 16:00:46 +00:00

feerate.cpp

Refactor CFeeRate to use FeeFrac internally