Ava Chow 3b39a8aeb4 Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream ...

fa0677d131 refactor: Use SpanReader over DataStream (MarcoFalke)
fad3eb3956 refactor: Use SpanReader over DataStream (MarcoFalke)
fa06e26764 refactor: [qt] Use SpanReader to avoid two vector copies (MarcoFalke)
fabd4d2e2e refactor: Avoid UB in SpanReader::ignore (MarcoFalke)
fa20bc2ec2 refactor: Use empty() over eof() in the streams interface (MarcoFalke)
fa879db735 test: Read debug log for self-checking comment (MarcoFalke)

Pull request description:

  This changes all places, where possible, to use SpanReader over DataStream. This makes the code easier to read and reason about, because `SpanReader` can never write data. Also, the code should be minimally faster, because it avoids a full redundant copy of the whole vector of bytes.

ACKs for top commit:
  stickies-v:
    re-ACK fa0677d131
  achow101:
    ACK fa0677d131
  janb84:
    re ACK fa0677d131
  sipa:
    crACK fa0677d131

Tree-SHA512: 1d9f43fc6e71d481cf7b8f8457f479745ee331734649e9e2c2ab00ce5d317112796c77afc328612ed004e65ac5c16fc92279d760cfb012cfddce9098c4af810f

2026-02-06 18:00:18 -08:00

..

util

Merge bitcoin/bitcoin#34181: refactor: [p2p] Make ProcessMessage private again, Use references when non-null

2026-02-06 17:10:25 -08:00

addition_overflow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addrman.cpp

fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-23 15:59:07 +01:00

asmap_direct.cpp

refactor: Simplify Interpret asmap function

2026-01-20 23:59:43 +01:00

asmap.cpp

refactor: Use span instead of vector for data in util/asmap

2026-01-20 23:59:41 +01:00

autofile.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

banman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

base_encode_decode.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bech32.cpp

lint: Check for missing trailing newline

2025-05-13 15:50:02 +02:00

bip324.cpp

…

bitdeque.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bitset.cpp

…

block_header.cpp

Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications

2026-01-14 11:38:07 -08:00

block_index_tree.cpp

validation: invert m_cached_finished_ibd to m_cached_is_ibd

2026-01-12 16:54:11 +01:00

block_index.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

block.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

blockfilter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bloom_filter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

buffered_file.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chain.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

checkqueue.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cluster_linearize.cpp

clusterlin: minimize chunks (feature)

2026-01-12 17:38:30 -05:00

CMakeLists.txt

fuzz: Add fuzzer for block index

2025-12-16 11:25:46 -05:00

coins_view.cpp

refactor: rename will_reuse_cache to reallocate_cache

2026-01-29 09:47:10 -05:00

coinscache_sim.cpp

Merge bitcoin/bitcoin#34164: validation: add reusable coins view for ConnectBlock

2026-01-29 14:59:36 -08:00

connman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_aes256.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_aes256cbc.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_diff_fuzz_chacha20.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_hkdf_hmac_sha256_l32.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_poly1305.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cuckoocache.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

decode_tx.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

descriptor_parse.cpp

fuzz: Exclude too expensive inputs in descriptor_parse targets

2026-01-22 21:01:55 +01:00

deserialize.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

difference_formatter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

eval_script.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

fee_rate.cpp

Refactor CFeeRate to use FeeFrac internally

2025-07-07 10:39:45 +02:00

feefrac.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

feeratediagram.cpp

clang-tidy: Apply modernize-deprecated-headers

2025-06-03 15:13:54 +02:00

fees.cpp

fees: refactor: rename fees to block_policy_estimator

2025-10-27 10:41:02 +01:00

flatfile.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

float.cpp

…

fuzz.cpp

fuzz: doc: remove any mention to address_deserialize_v2

2025-12-17 11:57:11 -03:00

fuzz.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

FuzzedDataProvider.h

fuzz: pull latest FuzzedDataProvider.h from upstream

2026-01-31 08:45:10 +03:00

golomb_rice.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

headerssync.cpp

fuzz: Use min option in ConsumeTime

2026-01-16 11:00:58 +01:00

hex.cpp

refactor: Move transaction_identifier.h to primitives

2025-08-11 16:47:51 +01:00

http_request.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

i2p.cpp

net: Fix -Wmissing-braces

2025-12-17 16:54:35 +00:00

integer.cpp

Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count

2026-01-20 15:47:17 -08:00

key_io.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

key.cpp

policy: uncap datacarrier by default

2025-05-30 10:12:38 -04:00

kitchen_sink.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

load_external_block_file.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

locale.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

merkle.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

merkleblock.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

message.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

mini_miner.cpp

scripted-diff: rename AddToMempool -> TryAddToMempool

2025-11-30 10:57:48 -05:00

miniscript.cpp

refactor(miniscript): Remove NodeRef & MakeNodeRef()

2026-01-20 22:41:25 +01:00

minisketch.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

muhash.cpp

refactor: Revert "disable self-assign warning for tests"

2025-10-09 20:47:25 +02:00

multiplication_overflow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_permissions.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netaddress.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netbase_dns_lookup.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

node_eviction.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

overflow.cpp

…

p2p_handshake.cpp

Merge bitcoin/bitcoin#34181: refactor: [p2p] Make ProcessMessage private again, Use references when non-null

2026-02-06 17:10:25 -08:00

p2p_headers_presync.cpp

Merge bitcoin/bitcoin#34181: refactor: [p2p] Make ProcessMessage private again, Use references when non-null

2026-02-06 17:10:25 -08:00

p2p_transport_serialization.cpp

…

package_eval.cpp

[miner] omit dummy extraNonce via IPC

2026-01-27 14:45:35 +01:00

parse_hd_keypath.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_iso8601.cpp

…

parse_numbers.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_script.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_univalue.cpp

…

partially_downloaded_block.cpp

refactor: unify container presence checks - trivial counts

2025-12-03 13:36:58 +01:00

pcp.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

policy_estimator_io.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

policy_estimator.cpp

Merge bitcoin/bitcoin#33629: Cluster mempool

2025-11-25 10:35:11 +00:00

poolresource.cpp

…

pow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

prevector.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

primitives_transaction.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

process_message.cpp

Merge bitcoin/bitcoin#34181: refactor: [p2p] Make ProcessMessage private again, Use references when non-null

2026-02-06 17:10:25 -08:00

process_messages.cpp

Merge bitcoin/bitcoin#34181: refactor: [p2p] Make ProcessMessage private again, Use references when non-null

2026-02-06 17:10:25 -08:00

protocol.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

psbt.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

random.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

rbf.cpp

Merge bitcoin/bitcoin#33985: fuzz: gate mempool entry based on weight

2025-12-02 15:07:01 +00:00

rolling_bloom_filter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

rpc.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_assets_test_minimizer.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_descriptor_cache.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_flags.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

script_format.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_interpreter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_ops.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_parsing.cpp

…

script_sigcache.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_sign.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

scriptnum_ops.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

secp256k1_ec_seckey_import_export_der.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

secp256k1_ecdsa_signature_parse_der_lax.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

signature_checker.cpp

script/verify_flags: make script_verify_flags type safe

2025-08-14 10:17:32 +10:00

signet.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

socks5.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

span.cpp

…

string.cpp

fuzz: Add a test case for ParseByteUnits()

2025-12-05 15:23:54 +00:00

strprintf.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

system.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

timeoffsets.cpp

…

torcontrol.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

transaction.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_in.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_out.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_pool.cpp

[miner] omit dummy extraNonce via IPC

2026-01-27 14:45:35 +01:00

txdownloadman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

txgraph.cpp

doc: fix double-word typos in comments

2025-12-30 12:12:26 -08:00

txorphan.cpp

refactor: unify container presence checks - trivial counts

2025-12-03 13:36:58 +01:00

txrequest.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

util.cpp

fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-23 15:59:07 +01:00

util.h

Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream

2026-02-06 18:00:18 -08:00

utxo_snapshot.cpp

Merge bitcoin/bitcoin#33680: validation: do not wipe utxo cache for stats/scans/snapshots

2026-01-29 14:43:27 -08:00

utxo_total_supply.cpp

Merge bitcoin/bitcoin#32420: mining, ipc: omit dummy extraNonce from coinbase

2026-02-02 15:21:16 -08:00

validation_load_mempool.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

vecdeque.cpp

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

versionbits.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00