Wladimir J. van der Laan 8a191148db Merge #17154: wallet: Remove return value from CommitTransaction ...

9e95931865 [wallet] Remove `state` argument from CWallet::CommitTransaction (John Newbery)
d1734f9a3b [wallet] Remove return value from CommitTransaction() (John Newbery)
b6f486a02b [wallet] Add doxygen comment to CWallet::CommitTransaction() (John Newbery)
8bba91b22d [wallet] Fix whitespace in CWallet::CommitTransaction() (John Newbery)

Pull request description:

  `CommitTransaction()` returns a bool to indicate success, but since commit
  b3a7410 (#9302) it only returns true, even if the transaction was not
  successfully broadcast. This commit changes CommitTransaction() to return
  void.

  All dead code in `if (!CommitTransaction())` branches has been removed.

  Two additional commits fix up the idiosyncratic whitespace in `CommitTransaction` and add a doxygen comment for the function.

ACKs for top commit:
  laanwj:
    ACK 9e95931865

Tree-SHA512: a55a2c20369a45222fc0e02d0891495655a926e71c4f52cb72624768dd7b9c1dca716ea67d38420afb90f40c6e0fd448caa60c18fd693bb10ecb110b641820e6

2019-10-24 10:16:12 +02:00

..

test

[wallet] Remove state argument from CWallet::CommitTransaction

2019-10-18 09:43:01 -04:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

crypter.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

crypter.h

Remove unused includes

2019-10-15 22:56:43 +00:00

db.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

db.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

feebumper.cpp

[wallet] Remove state argument from CWallet::CommitTransaction

2019-10-18 09:43:01 -04:00

feebumper.h

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

…

init.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

ismine.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

ismine.h

…

load.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

load.h

…

psbtwallet.cpp

…

psbtwallet.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rpcdump.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

rpcwallet.cpp

Merge #17154: wallet: Remove return value from CommitTransaction

2019-10-24 10:16:12 +02:00

rpcwallet.h

…

wallet.cpp

Merge #17154: wallet: Remove return value from CommitTransaction

2019-10-24 10:16:12 +02:00

wallet.h

Merge #17154: wallet: Remove return value from CommitTransaction

2019-10-24 10:16:12 +02:00

walletdb.cpp

Merge #16911: wallet: Only check the hash of transactions loaded from disk

2019-10-23 12:05:37 +02:00

walletdb.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

wallettool.cpp

…

wallettool.h

Remove unused includes

2019-10-15 22:56:43 +00:00

walletutil.cpp

…

walletutil.h

…