mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-19 14:53:43 +01:00
0ad4376a49
fa65bc0e79test: Run bench sanity checks in parallel with functional tests (MarcoFalke)fa9fdbce79test: Pass bench exe into test framework utils (MarcoFalke) Pull request description: The ctest target `bench_sanity_check` has many issues: * With sanitizers enabled, it is one of the slowest targets, often taking several minutes. See https://github.com/bitcoin/bitcoin/issues/32770#issuecomment-2984264066. * There is no insight from ctest into how long each individual sanity check takes. * On a timeout, or OOM issue, there is no insight into which sub-bench failed. The failure will generally just look like `75/153 Test #9: bench_sanity_check ...................***Failed 770.84 sec out of memory` * Places that can't use ctest (like the Windows-cross CI task) have to explicitly run it, or risk forgetting to run it. * All benchmarks are run sequentially, when they could run in parallel instead. Both issues can lead to CI timeouts and leave CPU unused during testing. Fix all issues by running it as part of the functional tests instead. This is similar to the rpcauth tests (https://github.com/bitcoin/bitcoin/pull/32881) and util tests [bitcoin-tx, and bitcoin-util] (https://github.com/bitcoin/bitcoin/pull/32697). ACKs for top commit: achow101: ACKfa65bc0e79l0rinc: Tested ACKfa65bc0e79janb84: tACKfa65bc0e79willcl-ark: ACKfa65bc0e79Tree-SHA512: d27e363b7896a7543a4ee8df41a56e58b74f07d4f296e2e5ee293fc91817d0be310e26905755fb94d44417d94fa29ad4cc5d4aa19e78d25d41bc2d9e0948c034