Pieter Wuille 6acd8700bc Merge #9680: Unify CWalletTx construction ...

b4bc32a451 [wallet] Get rid of CWalletTx default constructor (Russell Yanofsky)
a128bdc9e1 [wallet] Construct CWalletTx objects in CommitTransaction (Russell Yanofsky)

Pull request description:

  Two commits:

  - `Construct CWalletTx objects in CommitTransaction` moves a bunch of CWalletTx initialization into CWallet::CommitTransaction to dedup some code and avoid future inconsistencies in how wallet transactions are created.
  - `Get rid of CWalletTx default constructor` does what is described and eliminates the possibility of empty transaction entries being inadvertently created by mapWallet[hash] accesses.

  Both of these changes were originally part of #9381

Tree-SHA512: af3841c4f0539e0662d81b33c5369fc70aa06ddde1c59cb00fb21c9e4c7d9ff47f1edc5040cb463af1333838802c56b3ef875b939e2b804ee45b8e0294a4371c

2018-03-13 19:16:39 -07:00

..

accounting_tests.cpp

[wallet] Get rid of CWalletTx default constructor

2018-03-07 21:12:47 -05:00

crypto_tests.cpp

Increment MIT Licence copyright header year on files modified in 2017

2018-01-03 02:26:56 +09:00

wallet_test_fixture.cpp

Allow wallet files in multiple directories

2018-03-03 10:26:55 -05:00

wallet_test_fixture.h

Allow wallet files in multiple directories

2018-03-03 10:26:55 -05:00

wallet_tests.cpp

Merge #9680: Unify CWalletTx construction

2018-03-13 19:16:39 -07:00