highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-28 10:09:35 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
cc1efe909e9928a69870d71e173d8d03e9fd1090
bitcoin/src
History
fanquake dc9d662683 Merge bitcoin/bitcoin#25235: GetExternalSigner(): fail if multiple signers are found 
292b1a3e9c GetExternalSigner(): fail if multiple signers are found (amadeuszpawlik)

Pull request description:

  If there are multiple external signers, `GetExternalSigner()` will
  just pick the first one in the list. If the user has two or more
  hardware wallets connected at the same time, he might not notice this.

  This PR adds a check and fails with suitable message, forcing the user to disconnect all but one external signer, so that there is no ambiguity as to which external signer was used.

ACKs for top commit:
  Sjors:
    tACK 292b1a3e9c
  achow101:
    ACK 292b1a3e9c

Tree-SHA512: e2a41d3eecc607d4f94e708614bed0f3545f7abba85f300c5a5f0d3d17d72c815259734accc5ca370953eacd290f27894ba2c18016f5e9584cd50fa1ec2fbb0b
2022-08-13 16:08:19 +01:00
..
bench
Merge bitcoin/bitcoin#25785: bench: Add a benchmark for descriptor expansion
2022-08-12 13:00:06 +02:00
common
…
compat
compat: document redefining ssize_t when using MSVC
2022-07-20 13:10:12 +01:00
config
…
consensus
Remove LOCKTIME_MEDIAN_TIME_PAST constant
2022-06-22 09:54:15 +02:00
crc32c
…
crypto
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
index
Merge bitcoin/bitcoin#22485: doc: BaseIndex sync behavior with empty datadir
2022-07-21 19:54:18 +02:00
init
Merge bitcoin/bitcoin#24675: util: Use ArgsManager::GetPathArg more widely
2022-08-04 16:58:01 +01:00
interfaces
wallet: Return util::Result from WalletLoader methods
2022-08-10 11:14:53 -03:00
ipc
…
kernel
validationcaches: Use size_t for sizes
2022-08-03 12:03:28 -04:00
leveldb
Update leveldb-subtree subtree to latest upstream
2022-07-29 14:43:11 +01:00
logging
…
minisketch
Update minisketch subtree to latest master
2022-06-29 16:35:02 +01:00
node
validationcaches: Use size_t for sizes
2022-08-03 12:03:28 -04:00
policy
Remove ::g_max_datacarrier_bytes global
2022-08-02 15:29:16 +02:00
primitives
refactor: Make CTransaction constructor explicit
2022-07-25 12:16:54 +02:00
qt
Merge bitcoin/bitcoin#25235: GetExternalSigner(): fail if multiple signers are found
2022-08-13 16:08:19 +01:00
rpc
Merge bitcoin/bitcoin#22751: rpc/wallet: add simulaterawtransaction RPC
2022-08-05 15:19:03 -04:00
script
Merge bitcoin/bitcoin#25664: refactor: Redefine IsSolvable() using descriptors
2022-08-11 13:41:47 -04:00
secp256k1
Update secp256k1 subtree to latest upstream master
2022-06-11 14:55:18 +01:00
support
build: globally define NOMINMAX
2022-06-20 12:22:05 +01:00
test
Merge bitcoin/bitcoin#25677: refactor: make active_chain_tip a reference
2022-08-12 08:32:15 +02:00
univalue
univalue: Remove unused and confusing set*() return value
2022-07-29 15:24:42 +02:00
util
Merge bitcoin/bitcoin#25721: refactor: Replace BResult with util::Result
2022-08-05 15:33:45 +02:00
wallet
Merge bitcoin/bitcoin#25235: GetExternalSigner(): fail if multiple signers are found
2022-08-13 16:08:19 +01:00
zmq
scripted-diff: remove duplicate categories from LogPrint output
2022-06-06 12:12:03 +02:00
.bear-tidy-config
…
.clang-format
…
.clang-tidy
tidy: enable readability-redundant-string-init
2022-07-26 10:16:42 +01:00
addrdb.cpp
…
addrdb.h
…
addrman_impl.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
addrman.cpp
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
addrman.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-chainstate.cpp
validationcaches: Add and use ValidationCacheSizes
2022-08-03 12:03:27 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#24675: util: Use ArgsManager::GetPathArg more widely
2022-08-04 16:58:01 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
bitcoind-res.rc
…
bitcoind.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
refactor: remove unnecessary string initializations
2022-07-26 10:16:42 +01:00
blockfilter.h
…
chain.cpp
Remove unused SetTip(nullptr) code
2022-08-03 09:21:53 +02:00
chain.h
Remove unused SetTip(nullptr) code
2022-08-03 09:21:53 +02:00
chainparams.cpp
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
tracing: do not use coin after move in CCoinsViewCache::AddCoin
2022-07-21 12:55:20 +03:00
coins.h
refactor: remove unused methods {CDBIterator,CCoinsViewDBCursor}::GetValueSize()
2022-06-21 16:19:10 +02:00
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
validationcaches: Use size_t for sizes
2022-08-03 12:03:28 -04:00
dbwrapper.cpp
Remove unused includes from dbwrapper.h
2022-07-19 14:32:53 +02:00
dbwrapper.h
Remove unused includes from dbwrapper.h
2022-07-19 14:32:53 +02:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
refactor: remove unnecessary string initializations
2022-07-26 10:16:42 +01:00
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
build: globally define NOMINMAX
2022-06-20 12:22:05 +01:00
fs.h
Move FopenFn to fsbridge namespace
2022-07-15 12:25:51 -04:00
hash.cpp
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
hash.h
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
httpserver.h
…
i2p.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
i2p.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
indirectmap.h
…
init.cpp
validationcaches: Add and use ValidationCacheSizes
2022-08-03 12:03:27 -04:00
init.h
Move init::SanityCheck to kernel::SanityCheck
2022-06-02 11:42:12 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
extended keys: fail to derive too large depth instead of wrapping around
2022-08-04 11:32:26 +02:00
key.h
(pubk)key: mark Derive() as nodiscard
2022-08-04 11:32:25 +02:00
logging.cpp
logging: fix logging empty threadname
2022-06-02 22:30:30 +08:00
logging.h
logging: add LogPrintfCategory to log unconditionally with category
2022-06-08 14:02:54 +02:00
Makefile.am
build: move raw rule into Makefile.am
2022-08-10 13:36:33 +01:00
Makefile.bench.include
Merge bitcoin/bitcoin#25785: bench: Add a benchmark for descriptor expansion
2022-08-12 13:00:06 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
qt, refactor: Add transactionoverviewwidget.cpp source file
2022-06-14 16:55:22 +02:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
test/fuzz: Invoke LoadMempool via CChainState
2022-07-15 12:26:00 -04:00
Makefile.test_util.include
…
Makefile.test.include
Merge bitcoin/bitcoin#25798: build: fix cleanup of test logs
2022-08-11 11:57:12 -04:00
Makefile.univalue.include
…
mapport.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#24662: addrman: Use system time instead of adjusted network time
2022-08-05 09:03:33 +01:00
net_processing.h
[net processing] Remove CNode::nServices
2022-07-14 14:50:44 +02:00
net_types.cpp
…
net_types.h
…
net.cpp
net: simplify GetLocalAddress()
2022-08-10 15:09:29 +02:00
net.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netaddress.cpp
…
netaddress.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netbase.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netbase.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
noui.h
…
outputtype.cpp
outputtype: remove redundant check for uncompressed keys in AddAndGetDestinationForScript
2022-08-07 22:57:56 +02:00
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
refactor: Use type-safe std::chrono for addrman time
2022-07-26 11:06:10 +02:00
psbt.cpp
psbt: Implement merge for Taproot fields
2022-06-27 16:47:48 -04:00
psbt.h
psbt: Avoid unsigned int overflow in PSBT_IN_TAP_BIP32_DERIVATION
2022-08-10 11:58:17 -04:00
pubkey.cpp
Merge bitcoin/bitcoin#25642: Don't wrap around when deriving an extended key at a too large depth
2022-08-10 14:25:43 -04:00
pubkey.h
(pubk)key: mark Derive() as nodiscard
2022-08-04 11:32:25 +02:00
random.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
random.h
refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono)
2022-07-13 15:21:12 +02:00
randomenv.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
randomenv.h
…
rest.cpp
rest: clean-up for mempool endpoints
2022-08-05 10:28:11 -03:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Add ChronoFormatter to serialize
2022-07-26 11:05:04 +02:00
shutdown.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
…
streams.h
streams: Add AutoFile without ser-type and ser-version
2022-06-29 10:31:53 +02:00
sync.cpp
…
sync.h
…
threadinterrupt.cpp
Expose underlying clock in CThreadInterrupt
2022-07-13 15:20:49 +02:00
threadinterrupt.h
Expose underlying clock in CThreadInterrupt
2022-07-13 15:20:49 +02:00
threadsafety.h
…
timedata.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
timedata.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
tinyformat.h
…
torcontrol.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
torcontrol.h
…
txdb.cpp
CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash()
2022-07-22 12:45:07 +02:00
txdb.h
Add missing includes
2022-07-19 14:12:33 +02:00
txmempool.cpp
Remove ::g_max_datacarrier_bytes global
2022-08-02 15:29:16 +02:00
txmempool.h
Remove ::g_max_datacarrier_bytes global
2022-08-02 15:29:16 +02:00
txorphanage.cpp
refactor: log nEvicted message in LimitOrphans then return void
2022-07-28 14:39:45 +08:00
txorphanage.h
refactor: log nEvicted message in LimitOrphans then return void
2022-07-28 14:39:45 +08:00
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#25677: refactor: make active_chain_tip a reference
2022-08-12 08:32:15 +02:00
validation.h
Merge bitcoin/bitcoin#25677: refactor: make active_chain_tip a reference
2022-08-12 08:32:15 +02:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…