highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-29 17:19:30 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Ryan Ofsky cd3d9fa5ea
Merge bitcoin/bitcoin#31318: Drop script_pub_key arg from createNewBlock 
52fd1511a774d1ff9e747b2ce88aa1fcb778ced8 test: drop scriptPubKeyIn arg from CreateNewBlock (Sjors Provoost)
ff41b9e296aba0237e068fab181523c50bf8c9d0 Drop script_pub_key arg from createNewBlock (Sjors Provoost)
7ab733ede444aee61ab52670c228eec811268c6f rpc: rename coinbase_script to coinbase_output_script (Sjors Provoost)

Pull request description:

  Providing a script for the coinbase transaction is only done in test code and for (unoptimized) CPU solo mining.

  Production miners use the `getblocktemplate` RPC which omits the coinbase transaction entirely from its block template, leaving it to external (pool) software to construct it.

  This commit removes the `script_pub_key argument` from `createNewBlock()` in the Mining interface.

  A coinbase script can still be passed via `BlockCreateOptions` instead. Tests are modified to do so.

ACKs for top commit:
  ryanofsky:
    Code review ACK 52fd1511a774d1ff9e747b2ce88aa1fcb778ced8. No change since last review other than rebase
  TheCharlatan:
    Re-ACK 52fd1511a774d1ff9e747b2ce88aa1fcb778ced8
  vasild:
    ACK 52fd1511a774d1ff9e747b2ce88aa1fcb778ced8

Tree-SHA512: c4b3a53774d9a5dc90950e77f47a64dbb68f971baffbb9a0d8f59332ef8e52d0c039130c925bde73135b3d0e79e65d91d1df30dc4cff13f32d8a72e5c56669d8
2024-12-17 11:50:44 -05:00
..
bench
test: drop scriptPubKeyIn arg from CreateNewBlock
2024-12-04 12:46:33 +07:00
common
args: Catch directories in place of config files
2024-12-03 11:04:10 +01:00
compat
…
consensus
validation: Remove RECENT_CONSENSUS_CHANGE validation result
2024-11-11 10:24:38 +01:00
crc32c
…
crypto
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
index
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
init
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
interfaces
Merge bitcoin/bitcoin#31318: Drop script_pub_key arg from createNewBlock
2024-12-17 11:50:44 -05:00
ipc
Merge bitcoin/bitcoin#31318: Drop script_pub_key arg from createNewBlock
2024-12-17 11:50:44 -05:00
kernel
policy: Allow dust in transactions, spent in-mempool
2024-11-12 09:24:54 -05:00
leveldb
Update leveldb-subtree subtree to latest upstream
2024-06-13 13:17:57 +01:00
logging
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
minisketch
Update minisketch subtree to latest master
2024-06-12 14:38:39 +01:00
node
Merge bitcoin/bitcoin#31318: Drop script_pub_key arg from createNewBlock
2024-12-17 11:50:44 -05:00
policy
doc: ephemeral policy: add missing closing double quote
2024-11-25 21:05:11 +01:00
primitives
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
qt
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
rpc
Merge bitcoin/bitcoin#31318: Drop script_pub_key arg from createNewBlock
2024-12-17 11:50:44 -05:00
script
interpreter: Use the same type for SignatureHash in the definition
2024-11-25 15:36:05 +01:00
secp256k1
Update secp256k1 subtree to v0.6.0
2024-11-04 14:59:46 -05:00
support
cleanse: Use SecureZeroMemory for mingw-w64 (release) builds
2024-07-24 09:57:49 +01:00
test
Merge bitcoin/bitcoin#31318: Drop script_pub_key arg from createNewBlock
2024-12-17 11:50:44 -05:00
univalue
build: Remove Autotools-based build system
2024-08-30 21:31:39 +01:00
util
util: use explicit cast in MultiIntBitSet::Fill()
2024-12-05 16:55:36 +01:00
wallet
wallet: Migrate non-HD keys to combo() descriptor
2024-12-09 15:25:57 -05:00
zmq
cmake: Add FindZeroMQ module
2024-10-25 18:09:36 +01:00
.clang-format
…
.clang-tidy
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
addrdb.cpp
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
addrdb.h
…
addresstype.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addresstype.h
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addrman_impl.h
Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t
2024-09-20 12:55:22 -04:00
addrman.cpp
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
addrman.h
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
arith_uint256.cpp
…
arith_uint256.h
doc + test: Correct uint256 hex string endianness
2024-08-03 21:59:54 +02:00
attributes.h
…
banman.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
fuzz: replace hardcoded numbers for bech32 limits
2024-08-06 11:03:31 +02:00
bech32.h
fuzz: replace hardcoded numbers for bech32 limits
2024-08-06 11:03:31 +02:00
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks
2024-12-03 17:38:41 -05:00
bitcoin-cli-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-cli.cpp
args: Disallow -nodatadir
2024-11-20 22:55:25 +01:00
bitcoin-tx-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-tx.cpp
Merge bitcoin/bitcoin#31212: util: Improve documentation and negation of args
2024-12-04 13:20:46 -05:00
bitcoin-util-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-util.cpp
scripted-diff: Avoid printing version information for -noversion
2024-11-20 22:55:23 +01:00
bitcoin-wallet-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-wallet.cpp
args: Disallow -nodatadir
2024-11-20 22:55:25 +01:00
bitcoind-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoind.cpp
scripted-diff: Avoid printing version information for -noversion
2024-11-20 22:55:23 +01:00
blockencodings.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
blockencodings.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
doc: update NeedsRedownload() comment
2024-09-17 09:54:18 +02:00
chainparams.cpp
test: Don't enforce BIP94 on regtest unless specified by arg
2024-10-28 11:38:38 -04:00
chainparams.h
…
chainparamsbase.cpp
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsbase.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsseeds.h
seeds: Regenerate mainnet seeds
2024-08-27 07:00:27 +02:00
checkqueue.h
Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
2024-12-03 18:02:37 -05:00
clientversion.cpp
refactor: Pick translated string after format
2024-11-15 17:16:03 +01:00
clientversion.h
scripted-diff: Clarify "user agent" variable name
2024-10-28 12:35:49 +00:00
cluster_linearize.h
doc: correct typos
2024-11-11 14:14:39 +00:00
CMakeLists.txt
cmake: Build secp256k1 only when required
2024-11-23 15:31:39 +00:00
coins.cpp
Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests
2024-12-04 14:09:05 -05:00
coins.h
coins, refactor: Remove direct GetFlags access
2024-12-02 13:52:34 +01:00
compressor.cpp
…
compressor.h
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
core_io.h
rpc: add getdescriptoractivity
2024-11-26 20:47:08 -05:00
core_memusage.h
…
core_read.cpp
ci: Update Clang in "tidy" job
2024-12-05 14:37:47 +00:00
core_write.cpp
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
cuckoocache.h
validation: Don't error if maxsigcachesize exceeds uint32::max
2024-07-04 22:35:29 +02:00
dbwrapper.cpp
dbwrapper: Bump max file size to 32 MiB
2024-11-30 20:19:08 +01:00
dbwrapper.h
dbwrapper: Bump max file size to 32 MiB
2024-11-30 20:19:08 +01:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
external_signer.h
…
flatfile.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
flatfile.h
refactor: Add FlatFileSeq member variables in BlockManager
2024-07-24 09:39:35 +02:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563
2024-11-04 14:59:46 -05:00
headerssync.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
headerssync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
httprpc.cpp
args: Support -norpccookiefile for bitcoind and bitcoin-cli
2024-12-03 10:38:21 +01:00
httprpc.h
…
httpserver.cpp
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
httpserver.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
i2p.cpp
Merge bitcoin/bitcoin#29833: i2p: fix and improve logs
2024-06-26 15:28:26 -04:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#31223: net, init: derive default onion port if a user specified a -port
2024-12-13 18:56:37 -05:00
init.h
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
key_io.cpp
key: clear out secret data in DecodeExtKey
2024-10-27 15:38:54 +01:00
key_io.h
…
key.cpp
refactor: remove un-tested early returns
2024-08-04 08:52:22 +02:00
key.h
refactor: move SignSchnorr to KeyPair
2024-08-04 08:51:36 +02:00
logging.cpp
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
logging.h
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
mapport.cpp
mapport: remove dead code in DispatchMapPort
2024-10-25 15:02:07 -04:00
mapport.h
interfaces: remove now unused 'use_upnp' arg from 'mapPort'
2024-10-24 18:23:30 +02:00
memusage.h
memusage: Add DynamicUsage for std::string
2024-11-04 18:46:40 +01:00
merkleblock.cpp
…
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#31269: validation: Remove RECENT_CONSENSUS_CHANGE validation result
2024-11-14 09:43:47 +00:00
net_processing.h
net: add GetOrphanTransactions() to PeerManager
2024-10-01 21:55:18 -04:00
net_types.cpp
…
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
net.h
Merge bitcoin/bitcoin#31235: addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-13 12:13:17 +00:00
netaddress.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
netaddress.h
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
netbase.cpp
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
netbase.h
net: add All() in ReachableNets
2024-09-10 11:20:40 -03:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
doc: correct typos
2024-11-11 14:14:39 +00:00
pow.h
Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check
2024-09-02 15:43:33 +01:00
prevector.h
prevector: avoid GCC bogus warnings in insert method
2024-09-11 17:41:26 +02:00
protocol.cpp
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
protocol.h
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
psbt.cpp
…
psbt.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
pubkey.cpp
refactor: Hand-replace some ParseHex -> ""_hex
2024-08-28 19:11:59 +02:00
pubkey.h
refactor: Make XOnlyPubKey tolerate constexpr std::arrays
2024-08-28 19:09:51 +02:00
random.cpp
Merge bitcoin/bitcoin#31124: util: Remove RandAddSeedPerfmon
2024-10-24 18:08:12 -04:00
random.h
util: Remove RandAddSeedPerfmon
2024-10-21 23:24:17 +02:00
randomenv.cpp
util: Remove RandAddSeedPerfmon
2024-10-21 23:24:17 +02:00
randomenv.h
…
rest.cpp
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
rest.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
signet.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
signet.h
…
span.h
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
streams.cpp
streams: add DataStream::GetMemoryUsage
2024-11-04 18:46:40 +01:00
streams.h
streams: add DataStream::GetMemoryUsage
2024-11-04 18:46:40 +01:00
sync.cpp
…
sync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
threadsafety.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
tinyformat.h
tinyformat: Add compile-time checking for literal format strings
2024-10-28 19:13:46 -04:00
torcontrol.cpp
Merge bitcoin/bitcoin#31223: net, init: derive default onion port if a user specified a -port
2024-12-13 18:56:37 -05:00
torcontrol.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
txdb.cpp
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
txdb.h
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
txmempool.cpp
Move CalculateChunksForRBF() to the mempool changeset
2024-11-13 13:27:01 -05:00
txmempool.h
doc: add comments for CTxMemPool::ChangeSet
2024-11-13 13:27:01 -05:00
txorphanage.cpp
net: add GetOrphanTransactions() to PeerManager
2024-10-01 21:55:18 -04:00
txorphanage.h
[fuzz] txdownloadman and txdownload_impl
2024-10-24 21:23:56 -04:00
txrequest.cpp
Merge bitcoin/bitcoin#30194: refactor: use recommended type hiding on multi_index types
2024-08-07 20:00:28 +01:00
txrequest.h
…
uint256.cpp
scripted-diff: Rename SetHex to SetHexDeprecated
2024-07-24 09:15:34 +02:00
uint256.h
test: remove test-only uint256S
2024-09-06 17:36:18 +02:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#31346: Set notifications m_tip_block in LoadChainTip()
2024-12-13 08:25:25 -05:00
validation.h
Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
2024-12-03 18:02:37 -05:00
validationinterface.cpp
refactor: include the proper header rather than forward-declaring RemovalReasonToString
2024-10-08 15:25:47 +00:00
validationinterface.h
[refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr
2024-07-25 11:01:22 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00