mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-07-14 07:59:33 +02:00
ce2044a91d
75cf9708a0ci: add one more routable address to the VMs (docker containers) (Vasil Dimov)1b93983bf5test: make feature_bind_port_(discover|externalip).py auto-detect the skip condition (Vasil Dimov) Pull request description: `feature_bind_port_discover.py` and `feature_bind_port_externalip.py` require a routable address on the machine to run. Since that was not predictably available on CI, those tests required a manual setting up of IP addresses (e.g. using `ifconfig`) and then running the tests with a command line option telling them that the addresses are set up. The tests were not run in CI and [got rot](https://github.com/bitcoin/bitcoin/issues/31293#issuecomment-2497792487). Change that to auto-detect, from the tests, whether the needed IP addresses are present and if yes, run the test, otherwise skip it. Also change the CI to configure the needed addresses when running the functional tests. This way the tests will be run regularly on CI. Fixes: https://github.com/bitcoin/bitcoin/issues/31336 ACKs for top commit: willcl-ark: ACK75cf9708a0frankomosh: Tested ACK75cf9708a0. Built from source. ryanofsky: Code review ACK75cf9708a0. Tested locally with and without the special addresses, and the detection seems to work well. Tree-SHA512: 252911a37a06764f644a1a83c808f5255ac3bc74919426afa5d082c59e1ea924196354735f229d381cb5aff2340e001c2240bbadc8b5f27e5321fb4cfaef0fdb