Andrew Chow d2ccca253f Merge bitcoin/bitcoin#26567: Wallet: estimate the size of signed inputs using descriptors ...

10546a569c wallet: accurately account for the size of the witness stack (Antoine Poinsot)
9b7ec393b8 wallet: use descriptor satisfaction size to estimate inputs size (Antoine Poinsot)
8d870a9873 script/signingprovider: introduce a MultiSigningProvider (Antoine Poinsot)
fa7c46b503 descriptor: introduce a method to get the satisfaction size (Antoine Poinsot)
bdba7667d2 miniscript: introduce a helper to get the maximum witness size (Antoine Poinsot)
4ab382c2cd miniscript: make GetStackSize independent of P2WSH context (Antoine Poinsot)

Pull request description:

  The wallet currently estimates the size of a signed input by doing a dry run of the signing logic. This is unnecessary since all outputs we can sign for can be represented by a descriptor, and we can derive the size of a satisfaction ("signature") directly from the descriptor itself.
  In addition, the current approach does not generalize well: dry runs of the signing logic are only possible for the most basic scripts. See for instance the discussion in #24149 around that.

  This introduces a method to get the maximum size of a satisfaction from a descriptor, and makes the wallet use that instead of the dry-run.

ACKs for top commit:
  sipa:
    utACK 10546a569c
  achow101:
    re-ACK 10546a569c

Tree-SHA512: 43ed1529fbd30af709d903c8c5063235e8c6a03b500bc8f144273d6184e23a53edf0fea9ef898ed57d8a40d73208b5d935cc73b94a24fad3ad3c63b3b2027174

2023-09-06 13:31:03 -04:00

..

fuzz

fuzz: coinselection, fix m_cost_of_change

2023-08-23 14:48:27 -03:00

coinselector_tests.cpp

Merge bitcoin/bitcoin#27846: [coinselection] Increase SRD target by change_fee

2023-06-23 16:57:11 -04:00

db_tests.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

feebumper_tests.cpp

test: Remove unused txmempool include from tests

2022-10-18 14:02:09 +02:00

group_outputs_tests.cpp

scripted-diff: Replace CreateMockWalletDB with CreateMockableWalletDB

2023-05-03 10:45:10 -04:00

init_test_fixture.cpp

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

init_test_fixture.h

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

init_tests.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

ismine_tests.cpp

Rename script/standard.{cpp/h} to script/solver.{cpp/h}

2023-08-14 17:39:49 -04:00

psbt_wallet_tests.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rpc_util_tests.cpp

refactor: move Boost datetime usage to wallet

2022-10-01 11:41:53 +01:00

scriptpubkeyman_tests.cpp

Rename script/standard.{cpp/h} to script/solver.{cpp/h}

2023-08-14 17:39:49 -04:00

spend_tests.cpp

wallet: use descriptor satisfaction size to estimate inputs size

2023-08-25 12:40:12 +02:00

util.cpp

Remove unused includes from blockfilter.h

2023-08-17 18:28:15 +02:00

util.h

Move CTxDestination to its own file

2023-08-14 17:38:27 -04:00

wallet_crypto_tests.cpp

Move random test util code from setup_common to random

2023-02-06 12:26:04 -08:00

wallet_test_fixture.cpp

Merge bitcoin/bitcoin#26715: Introduce MockableDatabase for wallet unit tests

2023-05-15 11:39:43 +01:00

wallet_test_fixture.h

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

wallet_tests.cpp

Remove unused includes from blockfilter.h

2023-08-17 18:28:15 +02:00

wallet_transaction_tests.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletdb_tests.cpp

test: Avoid BOOST_ASSERT macro

2023-05-31 15:42:40 +01:00

walletload_tests.cpp

wallet: accurately account for the size of the witness stack

2023-08-25 12:40:12 +02:00