Andrew Chow 79e8247ddb Merge bitcoin/bitcoin#28039: wallet: don't include bdb files from our headers ...

8b5397c00e wallet: bdb: include bdb header from our implementation files only (Cory Fields)
6e010626af wallet: bdb: don't use bdb define in header (Cory Fields)
004b184b02 wallet: bdb: move BerkeleyDatabase constructor to cpp file (Cory Fields)
b3582baa3a wallet: bdb: move SafeDbt to cpp file (Cory Fields)
e5e5aa1da2 wallet: bdb: move SpanFromDbt to below SafeDbt's implementation (Cory Fields)
4216f69250 wallet: bdb: move TxnBegin to cpp file since it uses a bdb function (Cory Fields)
43369f3706 wallet: bdb: drop default parameter (Cory Fields)

Pull request description:

  Only `#include` upstream bdb headers from our cpp files.

  It's generally good practice to avoid including 3rd party deps in headers as otherwise they tend to sneak into new compilation units. IMO this makes for a nice cleanup.

  There's a good bit of code movement here, but each commit is small and _should_ be obviously correct.

  Note: in the future, the buildsystem can add the bdb include path for `bdb.cpp` and `salvage.cpp` only, rather than all wallet sources.

ACKs for top commit:
  achow101:
    reACK 8b5397c00e
  hebasto:
    ACK 8b5397c00e

Tree-SHA512: 0ef6e8a9c4c6e2d1e5d6a3534495f91900e4175143911a5848258c56da54535b85fad67b6d573da5f7b96e7881299b5a8ca2327e708f305b317b9a3e85038d66

2023-07-07 13:43:28 -04:00

..

rpc

scripted-diff: Following the C++ Standard rules for identifiers with _.

2023-06-20 10:23:08 +02:00

test

Merge bitcoin/bitcoin#27920: wallet: bugfix, always use apostrophe for spkm descriptor ID

2023-07-03 21:42:01 -04:00

bdb.cpp

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

bdb.h

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

coincontrol.cpp

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coincontrol.h

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coinselection.cpp

[bug] Increase SRD target by change_fee

2023-06-21 16:19:19 -04:00

coinselection.h

[bug] Increase SRD target by change_fee

2023-06-21 16:19:19 -04:00

context.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

context.h

…

crypter.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

crypter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

db.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

db.h

wallet: Add GetPrefixCursor to DatabaseBatch

2023-06-01 13:09:08 -04:00

dump.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

dump.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

external_signer_scriptpubkeyman.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

external_signer_scriptpubkeyman.h

wallet: set keypool_size instead of access global args manager

2023-02-15 15:49:44 -03:00

feebumper.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

feebumper.h

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.h

…

init.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

load.cpp

scripted-diff: move settings to common namespace

2023-05-30 17:26:51 +02:00

load.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

salvage.cpp

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

salvage.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

scriptpubkeyman.cpp

refactor: extract descriptor ID calculation from spkm GetID()

2023-06-28 09:37:15 -03:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#27759: Fix #includes in src/wallet

2023-05-29 16:33:14 +01:00

spend.cpp

[bug] Increase SRD target by change_fee

2023-06-21 16:19:19 -04:00

spend.h

gui: bugfix, getAvailableBalance skips selected coins

2023-04-03 17:23:42 -03:00

sqlite.cpp

refactor: Drop unsafe AsBytePtr function

2023-06-28 15:14:45 -04:00

sqlite.h

wallet: sqlite: force sqlite3.h to be included by the cpp files

2023-07-06 19:53:44 +00:00

transaction.cpp

…

transaction.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

types.h

wallet: add AddressPurpose enum to replace string values

2023-04-11 15:52:25 -04:00

wallet.cpp

wallet: migration bugfix, persist empty labels

2023-07-06 16:11:55 -03:00

wallet.h

Add [[nodiscard]] where ignoring a Result return type is an error

2023-05-29 13:12:45 +02:00

walletdb.cpp

Merge bitcoin/bitcoin#27920: wallet: bugfix, always use apostrophe for spkm descriptor ID

2023-07-03 21:42:01 -04:00

walletdb.h

walletdb: Refactor legacy wallet record loading into its own function

2023-06-27 11:00:47 -04:00

wallettool.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

wallettool.h

…

walletutil.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

walletutil.h

Merge bitcoin/bitcoin#25634: wallet, tests: Expand and test when the blank wallet flag should be un/set

2023-06-14 09:30:39 -04:00