Wladimir J. van der Laan
89e93135ae
Merge #17427: qt: Fix missing qRegisterMetaType for size_t
1828c6f05f refactor: Styling w/ clang-format, comment update (Hennadii Stepanov)
88a94f7bb8 qt: Fix missing qRegisterMetaType for size_t (Hennadii Stepanov)
Pull request description:
On master (a7aec7ad97) this connection a7aec7ad97/src/qt/rpcconsole.cpp (L587) fails due to `ClientModel::mempoolSizeChanged()` signal has unregistered parameter type `size_t`: a7aec7ad97/src/qt/clientmodel.h (L102)
More:
```
$ QT_FATAL_WARNINGS=1 lldb src/qt/bitcoin-qt -- -debug=qt
...
(lldb) bt
* thread #17, name = 'QThread', stop reason = signal SIGABRT
* frame #0: 0x00007ffff35fce97 libc.so.6`__GI_raise(sig=2) at raise.c:51
frame #1: 0x00007ffff35fe801 libc.so.6`__GI_abort at abort.c:79
frame #2: 0x00007ffff5901352 libQt5Core.so.5`QMessageLogger::warning(char const*, ...) const + 354
frame #3: 0x00007ffff5b216fe libQt5Core.so.5`___lldb_unnamed_symbol2329$$libQt5Core.so.5 + 334
frame #4: 0x00007ffff5b2456d libQt5Core.so.5`QMetaObject::activate(QObject*, int, int, void**) + 1933
frame #5: 0x000055555566872e bitcoin-qt`ClientModel::mempoolSizeChanged(this=<unavailable>, _t1=<unavailable>, _t2=<unavailable>) at moc_clientmodel.cpp:260
...
```
`debug.log`:
```
[] GUI: QObject::connect: Cannot queue arguments of type 'size_t'
(Make sure 'size_t' is registered using qRegisterMetaType().)
```
This PR fixes it.
Refs:
- [Qt docs: qRegisterMetaType](https://doc.qt.io/qt-5/qmetatype.html#qRegisterMetaType)
- #16348
---
Side NOTE: Also I believe this line a7aec7ad97/src/qt/bitcoin.cpp (L63) is redundant since long `CAmount` is a `typedef`.
ACKs for top commit:
laanwj:
Tested ACK 1828c6f05f
Tree-SHA512: 2c7f9fe6a5ae70f2e1dd86b07f95d4b00c85c5706a9d722f063f80beb71880d012ec46556963fb1544c2af53d006936c2f7612eae60d9193f67db62ba3d86129
2019-11-10 11:38:53 +01:00
..
2019-11-06 11:56:41 -05:00
2019-10-24 16:01:44 -04:00
2019-10-29 15:46:45 -04:00
2019-10-28 13:41:45 +01:00
2019-10-15 22:56:43 +00:00
2019-11-08 08:44:49 -05:00
2019-11-04 14:13:52 -05:00
2019-11-06 00:04:38 +01:00
2019-10-28 13:31:33 +01:00
2019-10-15 22:56:43 +00:00
2019-11-10 12:11:07 +02:00
2019-11-06 00:04:38 +01:00
2019-11-04 04:22:53 -05:00
2019-11-08 23:23:08 +01:00
2019-10-30 16:24:02 -04:00
2019-11-07 23:08:22 -04:00
2019-11-08 18:45:38 +01:00
2019-11-05 12:59:16 -05:00
2019-10-14 13:24:54 +03:00
2019-10-29 11:30:12 +02:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-11-04 13:18:27 +01:00
2019-10-16 08:56:57 -07:00
2019-09-05 13:25:11 +12:00
2019-11-04 14:39:34 -05:00
2019-10-28 13:31:33 +01:00
2019-10-28 13:31:33 +01:00
2019-10-30 12:35:41 +01:00
2019-10-29 15:46:45 -04:00
2019-10-15 22:56:43 +00:00
2019-10-16 17:06:20 -04:00
2019-10-16 13:06:50 -04:00
2019-10-29 20:27:30 +01:00
2019-11-01 12:06:35 +01:00
2019-09-06 22:05:33 +02:00
2019-11-01 12:06:35 +01:00
2019-10-02 08:51:12 +02:00
2019-09-25 20:56:38 +02:00
2019-10-15 22:56:43 +00:00
2019-08-30 11:29:21 +09:00
2019-10-10 15:47:39 -04:00
2019-10-15 22:56:43 +00:00
2019-10-28 10:30:51 -04:00
2019-10-28 13:41:45 +01:00
2019-10-28 13:41:45 +01:00
2019-10-15 22:56:43 +00:00
2019-10-25 13:11:09 +00:00
2019-10-15 22:56:43 +00:00
2019-11-07 10:07:11 -05:00
2019-10-28 10:30:51 -04:00
2019-10-15 22:56:43 +00:00
2019-10-22 00:07:31 +02:00
2019-11-08 18:45:38 +01:00
2019-11-08 18:45:38 +01:00
2019-11-07 22:08:22 -05:00
2019-11-06 11:56:41 -05:00
2019-09-30 09:41:11 +02:00
2019-10-24 16:01:43 -04:00
2019-11-06 11:56:41 -05:00
2019-11-07 23:08:22 -04:00
2019-10-29 15:46:45 -04:00
2019-11-05 12:38:28 -05:00
2019-10-29 15:46:45 -04:00
2019-10-29 11:30:12 +02:00
2019-11-04 11:17:20 -05:00
2019-11-05 12:38:28 -05:00
2019-10-15 22:56:43 +00:00
2019-11-04 04:22:53 -05:00
2019-11-04 10:42:33 -05:00
2019-11-04 10:42:33 -05:00
2019-10-16 08:56:57 -07:00
2019-10-15 22:56:43 +00:00
2019-10-02 10:39:14 -04:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-11-01 18:12:57 -04:00
2019-10-22 00:07:31 +02:00
2019-10-18 14:24:21 -04:00
2019-10-28 16:42:39 -07:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-10-28 13:31:33 +01:00
2019-09-25 10:56:00 -04:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-10-16 08:56:57 -07:00
2019-10-15 22:56:43 +00:00
2019-10-30 14:20:17 -04:00
2019-11-09 22:08:29 -08:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-10-15 22:56:43 +00:00
2019-11-08 23:23:14 +13:00
2019-11-07 10:07:11 -05:00
2019-11-05 12:59:16 -05:00
2019-11-05 12:59:16 -05:00
2019-10-28 10:30:51 -04:00
2019-10-15 22:56:43 +00:00