highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-09 08:43:04 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
d759b5d26a7e7cf381d80a5a0390787a136042e9
bitcoin/src
History
MarcoFalke d759b5d26a Merge #15911: Use wallet RBF default for walletcreatefundedpsbt 
d6b3640ac7 [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0 (Sjors Provoost)
9ed062b568 [doc] rpc: remove "fallback to" from RBF default help (Sjors Provoost)
4fcb698bc2 [rpc] walletcreatefundedpsbt: use wallet default RBF (Sjors Provoost)

Pull request description:

  The `walletcreatefundedpsbt` RPC call currently ignores `-walletrbf` and defaults to not use RBF. This PR fixes that.

  This PR also replaces UniValue in `ConstructTransaction` with a `bool` in preparation of moving this helper method out of the RPC codebase entirely. This may be a bit overkill, but does slightly simplify it.

  Fixes #15878

ACKs for top commit:
  achow101:
    Code Review ACK d6b3640ac7
  l2a5b1:
    re-ACK d6b3640
  MarcoFalke:
    ACK d6b3640ac7

Tree-SHA512: 55b9bccd1ef36b54f6b34793017dc0721103099ad3761b3b04862291ee13d6915915d4dbb1a8567924fa56e5e95dfe10eec070e06701610e70c87f8ea92b2a00
2019-08-02 08:53:39 -04:00
..
bench
Merge #16227: Refactor CWallet's inheritance chain
2019-07-11 22:42:39 +02:00
compat
Document assumptions about C++ compiler
2019-03-05 11:19:32 +01:00
config
…
consensus
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
crypto
Add ChaCha20Poly1305@Bitcoin AEAD implementation
2019-06-25 15:13:02 +02:00
index
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
interfaces
Merge #16452: refactor: use RelayTransaction in BroadcastTransaction utility
2019-07-31 10:49:28 -04:00
leveldb
…
node
refactor : use RelayTransaction in BroadcastTransaction utility
2019-07-24 19:47:56 -04:00
obj
…
obj-test
…
policy
[wallet] abort when attempting to fund a transaction above maxtxfee
2019-06-28 22:44:38 -04:00
primitives
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
qt
gui: Remove unused RPCConsole::tabFocus
2019-07-31 23:29:19 +01:00
rpc
Merge #15911: Use wallet RBF default for walletcreatefundedpsbt
2019-08-02 08:53:39 -04:00
script
Merge #16227: Refactor CWallet's inheritance chain
2019-07-11 22:42:39 +02:00
secp256k1
Update the secp256k1 subtree to the latest upstream version
2019-03-31 11:41:05 -07:00
support
Improve documentation of memory_cleanse()
2019-07-01 12:59:44 +02:00
test
Merge #16433: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN
2019-07-30 22:02:02 +02:00
univalue
…
util
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
wallet
Merge #15911: Use wallet RBF default for walletcreatefundedpsbt
2019-08-02 08:53:39 -04:00
zmq
rpc: switch to using RPCHelpMan.Check()
2019-07-08 09:53:52 +09:00
.clang-format
…
addrdb.cpp
addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.
2019-06-14 08:30:43 +02:00
addrdb.h
…
addrman.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
addrman.h
…
amount.h
…
arith_uint256.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
arith_uint256.h
…
attributes.h
…
banman.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Refactor out translation.h
2019-07-24 16:32:53 +03:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Refactor out translation.h
2019-07-24 16:32:53 +03:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Refactor out translation.h
2019-07-24 16:32:53 +03:00
bitcoind-res.rc
…
bitcoind.cpp
Trivial: add missing space
2019-07-28 13:33:10 -10:00
blockencodings.cpp
CorruptionPossible -> BLOCK_MUTATED
2019-05-02 15:14:12 -04:00
blockencodings.h
…
blockfilter.cpp
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
blockfilter.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
bloom.cpp
refactor: Improve CRollingBloomFilter::reset by using std::fill
2019-05-22 15:55:50 +01:00
bloom.h
…
chain.cpp
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chain.h
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chainparams.cpp
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparams.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsbase.cpp
…
chainparamsbase.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
coins.h
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_memusage.h
…
core_read.cpp
Include core_io.h from core_read.cpp
2019-06-06 08:00:33 +02:00
core_write.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
cuckoocache.h
…
dbwrapper.cpp
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
dbwrapper.h
…
dummywallet.cpp
Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options
2019-04-28 04:42:38 +00:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
Avoid redefine warning
2019-04-10 12:16:52 +01:00
fs.h
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063
2019-03-31 11:41:05 -07:00
httprpc.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
httprpc.h
…
httpserver.cpp
Remove global symbols: Avoid using the global namespace if possible
2019-05-25 23:23:11 +02:00
httpserver.h
[build] Add several util units
2019-04-09 17:53:08 -04:00
indirectmap.h
…
init.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
init.h
…
key_io.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
key_io.h
…
key.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
key.h
CKey: add method to negate the key
2019-03-27 13:59:50 +01:00
limitedmap.h
…
logging.cpp
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
logging.h
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
Makefile.am
Merge #16434: build: Specify AM_CPPFLAGS for ZMQ
2019-07-30 15:42:05 +02:00
Makefile.bench.include
Merge #15649: Add ChaCha20Poly1305@Bitcoin AEAD
2019-07-11 22:00:16 +02:00
Makefile.leveldb.include
…
Makefile.qt.include
build: Stop translating PACKAGE_NAME
2019-06-26 11:01:37 -04:00
Makefile.qttest.include
scripted-diff: Rename test_bitcoin to test/setup_common
2019-04-11 10:12:36 -04:00
Makefile.test.include
Move ismine to wallet module
2019-06-19 18:06:30 -04:00
memusage.h
…
merkleblock.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
merkleblock.h
…
miner.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
miner.h
…
net_processing.cpp
refactor : use RelayTransaction in BroadcastTransaction utility
2019-07-24 19:47:56 -04:00
net_processing.h
refactor : use RelayTransaction in BroadcastTransaction utility
2019-07-24 19:47:56 -04:00
net.cpp
Merge #15993: net: Drop support of the insecure miniUPnPc versions
2019-07-29 16:51:36 +02:00
net.h
net: Rename ::fRelayTxes to ::g_relay_txes
2019-05-09 09:10:53 -04:00
netaddress.cpp
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
netaddress.h
netaddress: Update CNetAddr for ORCHIDv2
2019-05-15 14:21:48 -04:00
netbase.cpp
net: Make poll in InterruptibleRecv only filter for POLLIN events.
2019-07-18 13:04:16 +02:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors
2019-08-01 15:17:10 +02:00
noui.h
Suppress output in test_bitcoin for expected errors
2019-07-03 14:03:21 +02:00
optional.h
…
outputtype.cpp
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
outputtype.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pow.cpp
…
pow.h
…
prevector.h
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
protocol.cpp
…
protocol.h
Remove unused bits from the service flags enum
2019-07-12 14:14:54 -04:00
psbt.cpp
Merge #15427: Add support for descriptors to utxoupdatepsbt
2019-07-02 16:53:22 +02:00
psbt.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pubkey.cpp
…
pubkey.h
…
random.cpp
Merge #15224: Add RNG strengthening (10ms once every minute)
2019-05-18 10:01:54 +02:00
random.h
Merge #15224: Add RNG strengthening (10ms once every minute)
2019-05-18 10:01:54 +02:00
rest.cpp
rpc: migrate JSONRPCRequest functionality into request.cpp
2019-07-05 11:22:02 +09:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
…
sync.cpp
Replace remaining fprintf with tfm::format manually
2019-06-13 11:46:38 -04:00
sync.h
scripted-diff: Rename LockAnnotation to LockAssertion
2019-05-17 13:29:04 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
2019-05-17 13:29:04 +02:00
timedata.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
timedata.h
…
tinyformat.h
tinyformat: Add doc to Bitcoin Core specific strprintf
2019-06-13 09:30:40 -04:00
torcontrol.cpp
fix: tor: Call event_base_loopbreak from the event's callback
2019-07-17 15:32:38 +01:00
torcontrol.h
…
txdb.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
txdb.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
txmempool.cpp
validation: Add missing mempool locks
2019-06-07 11:07:09 +02:00
txmempool.h
txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN
2019-07-22 07:40:24 -04:00
ui_interface.cpp
Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit
2019-06-18 15:59:53 -04:00
ui_interface.h
Add MSG_NOPREFIX flag for user messages
2019-06-19 19:22:34 +03:00
uint256.cpp
Merge #14734: fix an undefined behavior in uint::SetHex
2019-07-03 14:18:29 +02:00
uint256.h
…
undo.h
…
validation.cpp
[mempool] log correct messages when CPFP fails
2019-07-26 16:21:26 -04:00
validation.h
Merge #15681: [mempool] Allow one extra single-ancestor transaction per package
2019-07-19 20:00:12 +02:00
validationinterface.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
validationinterface.h
Remove extra CBlockIndex declaration
2019-06-25 15:02:34 -04:00
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
warnings.h
…