mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-20 15:19:07 +01:00
490cb056f6
fad6efd3berefactor: Use STR_INTERNAL_BUG macro where possible (MarcoFalke)fada379589doc: Remove unused bugprone-lambda-function-name suppression (MarcoFalke)fae1d99651refactor: Use const reference to std::source_location (MarcoFalke)fa5fbcd615util: Allow Assert() in contexts without __func__ (MarcoFalke) Pull request description: Without this, compile warnings could be hit about `__func__` being only valid inside functions. ``` warning: predefined identifier is only valid inside function [-Wpredefined-identifier-outside-function] note: expanded from macro Assert 115 | #define Assert(val) inline_assertion_check<true>(val, __FILE__, __LINE__, __func__, #val) | ^ ``` Ref https://github.com/bitcoin/bitcoin/pull/32740#discussion_r2486258473 This also introduces a slight behaviour change, because `std::source_location::function_name` usually includes the entire function signature instead of just the name. ACKs for top commit: l0rinc: Code review ACKfad6efd3bestickies-v: ACKfad6efd3behodlinator: re-ACKfad6efd3beTree-SHA512: e78a2d812d5ae22e45c93db1661dafbcd22ef209b3d8d8d5f2ac514e92fd19a17c3f0a5db2ef5e7748aa2083b10c0465326eb36812e6a80e238972facd2c7e98