Andrew Chow 73966f75f6 Merge bitcoin/bitcoin#25344: New outputs argument for bumpfee/psbtbumpfee ...

4c8ecccdcd test: add tests for `outputs` argument to `bumpfee`/`psbtbumpfee` (Seibart Nedor)
c0ebb98382 wallet: add `outputs` arguments to `bumpfee` and `psbtbumpfee` (Seibart Nedor)
a804f3cfc0 wallet: extract and reuse RPC argument format definition for outputs (Seibart Nedor)

Pull request description:

  This implements a modification of the proposal in #22007: instead of **adding** outputs to the set of outputs in the original transaction, the outputs given by `outputs` argument **completely replace** the outputs in the original transaction.

  As noted below, this makes it easier to "cancel" a transaction or to reduce the amounts in the outputs, which is not the case with the original proposal in #22007, but it seems from the discussion in this PR that the **replace** behavior is more desirable than **add** one.

ACKs for top commit:
  achow101:
    ACK 4c8ecccdcd
  1440000bytes:
    Code Review ACK 4c8ecccdcd
  ishaanam:
    reACK 4c8ecccdcd

Tree-SHA512: 31361f4a9b79c162bda7929583b0a3fd200e09f4c1a5378b12007576d6b14e02e9e4f0bab8aa209f08f75ac25a1f4805ad16ebff4a0334b07ad2378cc0090103

2023-02-16 13:47:41 -05:00

..

rpc

Merge bitcoin/bitcoin#25344: New outputs argument for bumpfee/psbtbumpfee

2023-02-16 13:47:41 -05:00

test

Merge bitcoin/bitcoin#25966: test: Remove redundant test

2023-02-03 17:32:46 -05:00

bdb.cpp

clang-tidy: Fix modernize-use-default-member-init in headers

2023-01-31 11:50:10 +00:00

bdb.h

clang-tidy: Fix modernize-use-default-member-init in headers

2023-01-31 11:50:10 +00:00

coincontrol.cpp

…

coincontrol.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coinselection.cpp

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

coinselection.h

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

context.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

context.h

…

crypter.cpp

…

crypter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

db.cpp

…

db.h

clang-tidy: Fix modernize-use-default-member-init in headers

2023-01-31 11:50:10 +00:00

dump.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

dump.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer_scriptpubkeyman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

feebumper.h

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.h

…

init.cpp

Remove -sysperms option

2023-02-05 08:09:16 +00:00

interfaces.cpp

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

ismine.h

…

load.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

load.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

salvage.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

salvage.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

scriptpubkeyman.cpp

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

scriptpubkeyman.h

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

spend.cpp

Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors

2023-02-16 10:01:33 +00:00

spend.h

Merge bitcoin/bitcoin#25659: wallet: simplify ListCoins implementation

2023-01-18 14:26:39 -05:00

sqlite.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

sqlite.h

Use DataStream where possible

2023-01-26 10:44:05 +01:00

transaction.cpp

…

transaction.h

Merge bitcoin/bitcoin#26499: wallet: Abandon descendants of orphaned coinbases

2023-01-30 10:09:41 +00:00

wallet.cpp

Zero out wallet master key upon lock

2023-02-10 20:21:23 -05:00

wallet.h

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

walletdb.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

walletdb.h

Use DataStream where possible

2023-01-26 10:44:05 +01:00

wallettool.cpp

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

wallettool.h

…

walletutil.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

walletutil.h

…