mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-19 10:24:21 +02:00
6ecda04fefrandom: drop ad-hoc Shuffle in favor of std::shuffle (Pieter Wuille)da28a26aaebench random: benchmark more functions, and add InsecureRandomContext (Pieter Wuille)0a9bbc64c1random bench refactor: move to new bench/random.cpp (Pieter Wuille) Pull request description: This adds benchmarks for various operations on `FastRandomContext` and `InsecureRandomContext`, and then removes the ad-hoc `Shuffle` functions, now that it appears that standard library `std::shuffle` has comparable performance. The other reason for keeping `Shuffle`, namely the fact that libstdc++ used self-move (which debug mode panics on) has been fixed as well (see https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1658344049). ACKs for top commit: achow101: ACK6ecda04fefhodlinator: ACK6ecda04fefdergoegge: Code review ACK6ecda04fefTree-SHA512: 2560b7312410581ff2b9bd0716e0f1558d910b5eadb9544785c972384985ac0f11f72d6b2797cfe2e7eb71fa57c30cffd98cc009cb4ee87a18b1524694211417