glozow d9aa7b23e4 Merge bitcoin/bitcoin#26596: wallet: Migrate legacy wallets to descriptor wallets without requiring BDB ...

8ce3739edb test: verify wallet is still active post-migration failure (furszy)
771bc60f13 wallet: Use LegacyDataSPKM when loading (Ava Chow)
61d872f1b3 wallet: Move MigrateToDescriptor and DeleteRecords to LegacyDataSPKM (Ava Chow)
b231f4d556 wallet: Move LegacyScriptPubKeyMan::IsMine to LegacyDataSPKM (Ava Chow)
7461d0c006 wallet: Move LegacySPKM data storage and handling to LegacyDataSPKM (Ava Chow)
517e204bac Change MigrateLegacyToDescriptor to reopen wallet as BERKELEY_RO (Ava Chow)

Pull request description:

  #26606 introduced `BerkeleyRODatabase` which is an independent parser for BDB files. This PR uses this in legacy wallet migration so that migration will continue to work once the legacy wallet and BDB are removed. `LegacyDataSPKM` is introduced to have the minimum data and functions necessary for a legacy wallet to be loaded for migration.

ACKs for top commit:
  cbergqvist:
    ACK 8ce3739edb
  theStack:
    Code-review ACK 8ce3739edb
  furszy:
    Code review ACK 8ce3739edb

Tree-SHA512: dccea12d6c597de15e3e42f97ab483cfd069e103611200279a177e021e8e9c4e74387c4f45d2e58b3a1e7e2bdb32a1d2d2060b1f8086c03eeaa0c68579d9d54e

2024-07-11 16:47:02 +01:00

..

rpc

wallet: update mempool conflicts tests + docs

2024-07-01 12:27:43 -04:00

test

fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error

2024-06-19 13:39:43 +02:00

bdb.cpp

bdb: Be able to make byteswapped databases

2024-05-16 15:03:13 -04:00

bdb.h

bdb: Be able to make byteswapped databases

2024-05-16 15:03:13 -04:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

random: drop ad-hoc Shuffle in favor of std::shuffle

2024-07-06 09:06:36 -04:00

coinselection.h

Fold GetSelectionWaste() into ComputeAndSetWaste()

2024-05-24 14:53:54 -04:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

wallet: implement BerkeleyROBatch

2024-05-13 23:01:37 -04:00

db.h

bdb: Be able to make byteswapped databases

2024-05-16 15:03:13 -04:00

dump.cpp

bdb: Be able to make byteswapped databases

2024-05-16 15:03:13 -04:00

dump.h

…

external_signer_scriptpubkeyman.cpp

util: add TransactionError includes and namespace declarations

2024-05-16 10:16:08 -05:00

external_signer_scriptpubkeyman.h

common: Add PSBTError enum

2024-05-16 10:16:08 -05:00

feebumper.cpp

Merge bitcoin/bitcoin#27969: bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate

2024-06-14 14:46:04 -04:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Merge bitcoin/bitcoin#26606: wallet: Implement independent BDB parser

2024-05-21 10:05:09 +01:00

interfaces.cpp

util: add TransactionError includes and namespace declarations

2024-05-16 10:16:08 -05:00

load.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

load.h

…

migrate.cpp

refactor: Add explicit cast to expected_last_page to silence fuzz ISan

2024-06-07 17:30:38 +02:00

migrate.h

Add MakeBerkeleyRODatabase

2024-05-16 15:03:13 -04:00

receive.cpp

[clang-tidy] Enable the misc-no-recursion check

2024-04-07 14:04:45 +01:00

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#26596: wallet: Migrate legacy wallets to descriptor wallets without requiring BDB

2024-07-11 16:47:02 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#26596: wallet: Migrate legacy wallets to descriptor wallets without requiring BDB

2024-07-11 16:47:02 +01:00

spend.cpp

random: drop ad-hoc Shuffle in favor of std::shuffle

2024-07-06 09:06:36 -04:00

spend.h

…

sqlite.cpp

wallet: use LogTrace for walletdb log messages at trace level

2024-06-28 17:41:52 +10:00

sqlite.h

…

transaction.cpp

…

transaction.h

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

types.h

util: move error.h TransactionError enum to node/types.h

2024-05-16 10:16:08 -05:00

wallet.cpp

Merge bitcoin/bitcoin#26596: wallet: Migrate legacy wallets to descriptor wallets without requiring BDB

2024-07-11 16:47:02 +01:00

wallet.h

Merge bitcoin/bitcoin#26596: wallet: Migrate legacy wallets to descriptor wallets without requiring BDB

2024-07-11 16:47:02 +01:00

walletdb.cpp

wallet: Use LegacyDataSPKM when loading

2024-07-01 14:25:55 -04:00

walletdb.h

…

wallettool.cpp

Merge bitcoin/bitcoin#26606: wallet: Implement independent BDB parser

2024-05-21 10:05:09 +01:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…