MarcoFalke 38176dc665 Merge #20573: wallet, bugfix: allow send with string fee_rate amounts ...

6fa72ceb80 test: add coverage for passing fee rate as a string (Jon Atack)
ce207d6b93 wallet, bugfix: allow send to take string fee rate values (Jon Atack)

Pull request description:

  RPC send currently only accepts fee rates as numbers, which is a user-facing bug. It should accept fee rates as an amount, e.g. a string or a number, as documented in its help and like sendtoaddress, sendmany, fundrawtransaction, walletcreatefundedpsbt, and bumpfee. Provide a fix and regression test coverage.

ACKs for top commit:
  MarcoFalke:
    review ACK 6fa72ceb80
  achow101:
    Code review ACK 6fa72ceb80
  promag:
    Code review ACK 6fa72ceb80.

Tree-SHA512: 735f9269cb1b81953764b5283449c0b154bd62de034225be5bcedc515c84faf767fe8fe0741008679fe412922c847b00d116cb11aab775236b779c847ba87167

2020-12-10 08:46:01 +01:00

..

test

test: Remove no longer needed MakeChain calls

2020-12-07 20:46:03 -05:00

bdb.cpp

…

bdb.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

feebumper.cpp

Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const

2020-12-06 00:22:40 +00:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

interfaces.cpp

Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const

2020-12-06 00:22:40 +00:00

ismine.h

…

load.cpp

Ignoring (but warn) on duplicate -wallet parameters

2020-11-03 12:06:32 +01:00

load.h

…

rpcdump.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

rpcwallet.cpp

wallet, bugfix: allow send to take string fee rate values

2020-12-04 22:12:36 +01:00

rpcwallet.h

…

salvage.cpp

Enforce salvage is only for BDB wallets

2020-11-18 11:56:12 -05:00

salvage.h

…

scriptpubkeyman.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

scriptpubkeyman.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

sqlite.cpp

Fix mock SQLiteDatabases

2020-11-18 11:56:12 -05:00

sqlite.h

…

wallet.cpp

refactor: Get rid of more redundant chain methods

2020-12-07 09:09:53 -04:00

wallet.h

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.cpp

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

wallettool.h

…

walletutil.cpp

refactor: Use C++17 std::array where possible

2020-12-04 08:22:45 +01:00

walletutil.h

wallet: Add GetClosestWalletFeature function

2020-10-19 00:14:38 -04:00