mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-29 23:37:44 +01:00

Files

W. J. van der Laan 7f0f853373 Merge bitcoin/bitcoin#23005 : multiprocess: Delay wallet client construction

ad085f9ba1 multiprocess: Delay wallet client construction (Russell Yanofsky)

Pull request description:

  Delay wallet client construction until after logging, thread and other init for two reasons:

  - More responsive multiprocess GUI startup. When bitcoin-gui is started this moves the call from bitcoin-gui to bitcoin-node that spawns bitcoin-wallet off of the GUI event thread and onto the background GUI init executor thread.

  - Avoids feature_logging.py test failures with bitcoin-node by making bitcoin-wallet logging start after bitcoin-node logging starts,
    because the tests are not written to handle the bitcoin-wallet logging init code running first.

  This partially reverts commit b266b3e0bf, moving wallet client creation back to the place it was located before.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

ACKs for top commit:
  laanwj:
    code review ACK ad085f9ba1
  hebasto:
    ACK ad085f9ba1, I have reviewed the code and it looks OK.

Tree-SHA512: 74d957ce2ee096db745c517124f60800185814b06c20db676090e10dce1b90311adbab02865a69731f8c39b9365f9ee14be0830ca1368cac9b474801ea92bad5

2021-11-15 18:08:49 +01:00

chain.h

Merge bitcoin/bitcoin#23003 : multiprocess: Make interfaces::Chain::isTaprootActive non-const

2021-10-13 07:19:13 +02:00

echo.cpp

…

echo.h

…

handler.cpp

…

handler.h

…

init.cpp

…

init.h

…

ipc.h

…

node.h

Merge bitcoin/bitcoin#23005 : multiprocess: Delay wallet client construction

2021-11-15 18:08:49 +01:00

README.md

…

wallet.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.