mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-04 06:12:07 +01:00
fa46a1b74btest: Avoid CScript() as default function argument (MarcoFalke)fadf621825test: Make leaf_script mandatory when scriptpath is set in TaprootSignatureMsg (MarcoFalke) Pull request description: Unlike other function calls in default arguments, CScript should not cause any issues in the tests, because they are const. However, this change allows to enable the "function-call-in-default-argument (B008)" lint rule, which will help to catch severe test bugs, such as https://github.com/bitcoin/bitcoin/issues/30543#issuecomment-2259260024 . The lint rule will be enabled in a follow-up, when all violations are fixed. ACKs for top commit: instagibbs: utACKfa46a1b74btheStack: lgtm ACKfa46a1b74bismaelsadeeq: Tested ACKfa46a1b74bTree-SHA512: bc68b15121d50ead0fc70ad772360a7829908aedeaff8426efcb8a67f33117f67d26b4f5da94fa735dd8de9c9ff65fc10a29323f1b12f238b75486fa7cc32a89