bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-18 07:50:38 +02:00

History

merge-script df241970a3

Merge bitcoin/bitcoin#30554 : test: Avoid CScript() as default function argument

fa46a1b74bd35371036af17b2df2036dbc993ce1 test: Avoid CScript() as default function argument (MarcoFalke)
fadf621825fdbf5fd131da14419bb19bb81e5801 test: Make leaf_script mandatory when scriptpath is set in TaprootSignatureMsg (MarcoFalke)

Pull request description:

  Unlike other function calls in default arguments, CScript should not cause any issues in the tests, because they are const.

  However, this change allows to enable the "function-call-in-default-argument (B008)" lint rule, which will help to catch severe test bugs, such as https://github.com/bitcoin/bitcoin/issues/30543#issuecomment-2259260024 .

  The lint rule will be enabled in a follow-up, when all violations are fixed.

ACKs for top commit:
  instagibbs:
    utACK fa46a1b74bd35371036af17b2df2036dbc993ce1
  theStack:
    lgtm ACK fa46a1b74bd35371036af17b2df2036dbc993ce1
  ismaelsadeeq:
    Tested ACK fa46a1b74bd35371036af17b2df2036dbc993ce1

Tree-SHA512: bc68b15121d50ead0fc70ad772360a7829908aedeaff8426efcb8a67f33117f67d26b4f5da94fa735dd8de9c9ff65fc10a29323f1b12f238b75486fa7cc32a89

2024-08-02 14:02:04 +01:00

crypto

…

__init__.py

…

address.py

test: refactor: return TaprootInfo from P2TR address creation routine

2024-06-11 14:36:05 +02:00

authproxy.py

test: use json-rpc 2.0 in all functional tests by default

2024-06-07 09:26:55 -04:00

bdb.py