mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-21 07:39:08 +01:00
466e4df3fbassert_mempool_contents: assert not duplicates expected (Greg Sanders)ea5db2f269functional: only generate required blocks for test (Greg Sanders)d033acb608fuzz: package_eval: let fuzzer run out input in main tx creation loop (Greg Sanders)ba35a570c5CheckEphemeralSpends: return boolean, and set child state and txid outparams (Greg Sanders)cf0cee1617func: add note about lack of 1P1C propagation in tree submitpackage (Greg Sanders)8424290304unit test: ephemeral_tests is using a dust relay rate, not minrelay (Greg Sanders)d9cfa5fc4eCheckEphemeralSpends: no need to iterate inputs if no parent dust (Greg Sanders)87b26e3dc0func: rename test_free_relay to test_no_minrelay_fee (Greg Sanders)e5709a4a41func: slight elaboration on submitpackage restriction (Greg Sanders)08e969bd10RPC: only enforce dust rules on priority when standardness active (Greg Sanders)ca050d12e7unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX (Greg Sanders)7c3490169cfuzz: package_eval: move last_tx inside txn ctor (Greg Sanders)445eaed182fuzz: use optional status instead of should_rbf_eph_spend (Greg Sanders)4dfdf615b9fuzz: remove unused TransactionsDelta validation interface (Greg Sanders)09ce926e4afunc: cleanup reorg test comment (Greg Sanders)768a0c1889func: cleanup test_dustrelay comments (Greg Sanders)bedca1cb66fuzz: Directly place transactions in vector (Greg Sanders)c041ad6eccfuzz: explain package eval coin tracking better (Greg Sanders)bc0d98ea61fuzz: remove dangling reference to GetEntry (Greg Sanders)15b6cbf07funit test: make dust index less magical (Greg Sanders)5fbcfd12b8unit test: assert txid returned on CheckEphemeralSpends failures (Greg Sanders)ef94d84b4ebench: remove unnecessary CMTxn constructors (Greg Sanders)c5c10fd317ephemeral policy doxygen cleanup (Greg Sanders)dd9044b8d4ephemeral policy: IWYU (Greg Sanders)c6859ce2deMove+rename GetDustIndexes -> GetDust (Greg Sanders)62016b3230Use std::ranges for ephemeral policy checks (Greg Sanders)3ed930a1f4Have HasDust and PreCheckValidEphemeralTx take CTransaction (Greg Sanders)04a614bf9aRename CheckValidEphemeralTx to PreCheckEphemeralTx (Greg Sanders)cbf1a47d60CheckEphemeralSpends: only compute txid of tx when needed (Greg Sanders) Pull request description: Follow-up to https://github.com/bitcoin/bitcoin/pull/30239 Here are the parent PR's comments that should be addressed by this PR: https://github.com/bitcoin/bitcoin/pull/30239/files#r1834529646 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831247308 https://github.com/bitcoin/bitcoin/pull/30239/files#r1832622481 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831195216 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834639096 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834624976 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834619709 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834610434 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834504436 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834500036 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832985488 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830929809 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832376920 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832755799 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832492686 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832980576 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832784278 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1837989979 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830996993 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830997947 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830012890 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830037288 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830977092 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832622481 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834726168 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832453654 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848488226 ACKs for top commit: naumenkogs: ACK466e4df3fbhodlinator: ACK466e4df3fbtheStack: lgtm ACK466e4df3fbglozow: utACK466e4df3fbTree-SHA512: 89106f695755c238b84e0996b89446c0733e10a94c867f656d516d26697d2efe38dfc332188b8589a0a26a3d2bd2c88c6ab70c108e187ce5bfcb91bbf3fb0391
71 lines
3.0 KiB
C++
71 lines
3.0 KiB
C++
// Copyright (c) 2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_TEST_UTIL_TXMEMPOOL_H
|
|
#define BITCOIN_TEST_UTIL_TXMEMPOOL_H
|
|
|
|
#include <policy/packages.h>
|
|
#include <txmempool.h>
|
|
#include <util/time.h>
|
|
|
|
namespace node {
|
|
struct NodeContext;
|
|
}
|
|
struct PackageMempoolAcceptResult;
|
|
|
|
CTxMemPool::Options MemPoolOptionsForTest(const node::NodeContext& node);
|
|
|
|
struct TestMemPoolEntryHelper {
|
|
// Default values
|
|
CAmount nFee{0};
|
|
NodeSeconds time{};
|
|
unsigned int nHeight{1};
|
|
uint64_t m_sequence{0};
|
|
bool spendsCoinbase{false};
|
|
unsigned int sigOpCost{4};
|
|
LockPoints lp;
|
|
|
|
CTxMemPoolEntry FromTx(const CMutableTransaction& tx) const;
|
|
CTxMemPoolEntry FromTx(const CTransactionRef& tx) const;
|
|
|
|
// Change the default value
|
|
TestMemPoolEntryHelper& Fee(CAmount _fee) { nFee = _fee; return *this; }
|
|
TestMemPoolEntryHelper& Time(NodeSeconds tp) { time = tp; return *this; }
|
|
TestMemPoolEntryHelper& Height(unsigned int _height) { nHeight = _height; return *this; }
|
|
TestMemPoolEntryHelper& Sequence(uint64_t _seq) { m_sequence = _seq; return *this; }
|
|
TestMemPoolEntryHelper& SpendsCoinbase(bool _flag) { spendsCoinbase = _flag; return *this; }
|
|
TestMemPoolEntryHelper& SigOpsCost(unsigned int _sigopsCost) { sigOpCost = _sigopsCost; return *this; }
|
|
};
|
|
|
|
/** Check expected properties for every PackageMempoolAcceptResult, regardless of value. Returns
|
|
* a string if an error occurs with error populated, nullopt otherwise. If mempool is provided,
|
|
* checks that the expected transactions are in mempool (this should be set to nullptr for a test_accept).
|
|
*/
|
|
std::optional<std::string> CheckPackageMempoolAcceptResult(const Package& txns,
|
|
const PackageMempoolAcceptResult& result,
|
|
bool expect_valid,
|
|
const CTxMemPool* mempool);
|
|
|
|
/** Check that we never get into a state where an ephemeral dust
|
|
* transaction would be mined without the spend of the dust
|
|
* also being mined. This assumes standardness checks are being
|
|
* enforced.
|
|
*/
|
|
void CheckMempoolEphemeralInvariants(const CTxMemPool& tx_pool);
|
|
|
|
/** For every transaction in tx_pool, check TRUC invariants:
|
|
* - a TRUC tx's ancestor count must be within TRUC_ANCESTOR_LIMIT
|
|
* - a TRUC tx's descendant count must be within TRUC_DESCENDANT_LIMIT
|
|
* - if a TRUC tx has ancestors, its sigop-adjusted vsize must be within TRUC_CHILD_MAX_VSIZE
|
|
* - any non-TRUC tx must only have non-TRUC parents
|
|
* - any TRUC tx must only have TRUC parents
|
|
* */
|
|
void CheckMempoolTRUCInvariants(const CTxMemPool& tx_pool);
|
|
|
|
/** One-line wrapper for creating a mempool changeset with a single transaction
|
|
* and applying it. */
|
|
void AddToMempool(CTxMemPool& tx_pool, const CTxMemPoolEntry& entry);
|
|
|
|
#endif // BITCOIN_TEST_UTIL_TXMEMPOOL_H
|