mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 13:42:10 +02:00
d3e40af259
`BaseIndex` currently uses the same name for logs, `getindexinfo`, prune locks, and the sync thread. Linux truncates system thread names to 15 visible bytes after the `b-` prefix, so long indexer names are clipped in system tools. Pass a separate thread name explicitly at each `BaseIndex` call site and shorten the OS-visible indexer names to `txidx`, `blkfltbscidx`, `coinstatsidx`, and `txospenderidx`. Add an `Assume` to `ThreadRename()` so future OS-visible thread names keep fitting the same Linux limit. The public index names, `getindexinfo` keys, command-line options, and on-disk paths stay unchanged. Co-authored-by: winterrdog <winterrdog@users.noreply.github.com> Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com> Co-authored-by: sedited <seb.kung@gmail.com> Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
67 lines
1.7 KiB
C++
67 lines
1.7 KiB
C++
// Copyright (c) 2018-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <util/string.h>
|
|
#include <util/threadnames.h>
|
|
|
|
#include <mutex>
|
|
#include <set>
|
|
#include <string>
|
|
#include <thread>
|
|
#include <vector>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
using util::ToString;
|
|
|
|
BOOST_AUTO_TEST_SUITE(util_threadnames_tests)
|
|
|
|
const std::string TEST_THREAD_NAME_BASE = "test_thrd.";
|
|
|
|
/**
|
|
* Run a bunch of threads to all call util::ThreadRename.
|
|
*
|
|
* @return the set of name each thread has after attempted renaming.
|
|
*/
|
|
std::set<std::string> RenameEnMasse(int num_threads)
|
|
{
|
|
std::vector<std::thread> threads;
|
|
std::set<std::string> names;
|
|
std::mutex lock;
|
|
|
|
auto RenameThisThread = [&](int i) {
|
|
util::ThreadRename(TEST_THREAD_NAME_BASE + ToString(i));
|
|
std::lock_guard<std::mutex> guard(lock);
|
|
names.insert(util::ThreadGetInternalName());
|
|
};
|
|
|
|
threads.reserve(num_threads);
|
|
for (int i = 0; i < num_threads; ++i) {
|
|
threads.emplace_back(RenameThisThread, i);
|
|
}
|
|
|
|
for (std::thread& thread : threads) thread.join();
|
|
|
|
return names;
|
|
}
|
|
|
|
/**
|
|
* Rename a bunch of threads with the same basename (expect_multiple=true), ensuring suffixes are
|
|
* applied properly.
|
|
*/
|
|
BOOST_AUTO_TEST_CASE(util_threadnames_test_rename_threaded)
|
|
{
|
|
std::set<std::string> names = RenameEnMasse(100);
|
|
|
|
BOOST_CHECK_EQUAL(names.size(), 100U);
|
|
|
|
// Names "test_thrd.[n]" should exist for n = [0, 99]
|
|
for (int i = 0; i < 100; ++i) {
|
|
BOOST_CHECK(names.contains(TEST_THREAD_NAME_BASE + ToString(i)));
|
|
}
|
|
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|