mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-13 06:04:42 +02:00
d0b76c7f3erpc+bitcoin-tx: Specify correct type for ParseFixedPoint() (Hodlinator)43ca54ca00refactor(test): Make CAmount arg explicit for BuildCreditingTransaction() (Hodlinator)b5e91e946cwallet: Remove CoinsResult::Clear() (Hodlinator) Pull request description: The *knapsack_solver_test* in *coinselector_tests.cpp* was accumulating satoshi amounts beyond 21M BTC. This was uncovered while experimenting with adding checks to `CAmount`. Fix that by fully resetting the `CoinsResult` object accumulating those amounts, inspired by https://github.com/bitcoin/bitcoin/issues/35449#issuecomment-4613968627. Also, while we're at it, add 2 commits which correct some `int64_t`/`CAmount` confusion. Fixes https://github.com/bitcoin/bitcoin/issues/35449 ACKs for top commit: sedited: ACKd0b76c7f3efurszy: utACKd0b76c7f3ebrunoerg: code review ACKd0b76c7f3eTree-SHA512: 6d989ded6f6327dc657f437dc256d4adf42a34a1252621421ee38d7851c6cdc97a462f033a4728e3aa7d5514deee4db6e83646105633f9cf7ed6e7e90406b67d