merge-script 2a1234001c Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet ...

75b704df9d wallettool: Disallow creating new unnamed wallets (Ava Chow)
5875a9c502 wallet: disallow unnamed wallets in createwallet and restorewallet (Ava Chow)
d30ad4a912 wallet, rpc: Use HandleWalletError in createwallet (Ava Chow)

Pull request description:

  We've been moving in the direction that all wallets must have a name. Therefore, we shouldn't allow creating new unnamed wallets. `createwallet`, `restorewallet`, and the wallet tool's `create` and `createfromdump` all now require the user to provide a non-empty wallet name when creating/restoring a wallet.

  The GUI is already enforcing this, but we were not enforcing it for RPCs or in the underlying `CreateWallet` and `RestoreWallet` functions.

  Wallet migration does still need to be able to restore unnamed wallets, so there is a new argument to `RestoreWallet` to explicitly allow that behavior for migration only.

ACKs for top commit:
  rkrux:
    lgtm ACK 75b704df9d
  polespinasa:
    re ACK 75b704df9d

Tree-SHA512: 8bde76d0b091e9276788c69412934af3426da2a7a69a00f94072d36c1a075cd41744ecdd5fef2b72870c1351b76aae061f124f716bb23f4839be20c464fc5ebd

2026-01-21 22:56:59 +01:00

..

bench

Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods

2026-01-21 13:23:43 +01:00

common

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

compat

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

consensus

Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count

2026-01-20 15:47:17 -08:00

crc32c

…

crypto

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

index

Merge bitcoin/bitcoin#32997: index: Deduplicate HashKey / HeightKey handling

2025-12-27 16:18:34 +00:00

init

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

interfaces

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

ipc

Merge bitcoin/bitcoin#34363: Update libmultiprocess subtree to avoid occasional rpc_misc.py timeout

2026-01-21 15:07:23 +00:00

kernel

iwyu: Do not export crypto/hex_base.h header

2026-01-19 17:03:11 +00:00

leveldb

…

logging

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

minisketch

…

node

iwyu: Do not export crypto/hex_base.h header

2026-01-19 17:03:11 +00:00

policy

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

primitives

refactor: rename CTransaction::GetTotalSize to signal that it's not cached

2026-01-19 20:20:13 +01:00

qt

Merge bitcoin/bitcoin#34353: refactor: Use std::bind_front over std::bind

2026-01-21 14:59:31 +00:00

rpc

refactor: rename CTransaction::GetTotalSize to signal that it's not cached

2026-01-19 20:20:13 +01:00

script

Merge bitcoin/bitcoin#32471: wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key

2026-01-20 12:17:19 -08:00

secp256k1

…

support

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

test

Merge bitcoin/bitcoin#34353: refactor: Use std::bind_front over std::bind

2026-01-21 14:59:31 +00:00

univalue

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

util

Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods

2026-01-21 13:23:43 +01:00

wallet

Merge bitcoin/bitcoin#34269: wallet: disallow creating new or restoring to an unnamed (default) wallet

2026-01-21 22:56:59 +01:00

zmq

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

.clang-format

clang-format: use AngleBracket for main includes

2026-01-19 17:11:23 +00:00

.clang-tidy

Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods

2026-01-21 13:23:43 +01:00

addrdb.cpp

…

addrdb.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addresstype.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addresstype.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addrman_impl.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

addrman.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

addrman.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

arith_uint256.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

arith_uint256.h

…

attributes.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

banman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

Add regtest support to bitcoin-chainstate tool

2025-12-18 20:19:15 +03:30

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

bitcoin-res.rc

…

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

bitcoin-util-res.rc

…

bitcoin-util.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoin.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bitcoind-res.rc

…

bitcoind.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockencodings.cpp

log,blocks: avoid ComputeTotalSize and GetHash work when logging is disabled

2026-01-19 20:20:13 +01:00

blockencodings.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockfilter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockfilter.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chain.cpp

Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications

2026-01-14 11:38:07 -08:00

chain.h

Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications

2026-01-14 11:38:07 -08:00

chainparams.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chainparams.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

chainparamsbase.cpp

…

chainparamsbase.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

chainparamsseeds.h

…

checkqueue.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

clientversion.cpp

…

clientversion.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cluster_linearize.h

clusterlin: minimize chunks (feature)

2026-01-12 17:38:30 -05:00

CMakeLists.txt

refactor: [move-only] Merge core_io module

2026-01-19 12:57:16 +01:00

coins.cpp

Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void

2026-01-02 16:49:23 -08:00

coins.h

refactor: Let CCoinsViewCache::BatchWrite return void

2025-12-14 22:25:31 +01:00

compressor.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

compressor.h

…

core_io.cpp

Merge bitcoin/bitcoin#33738: log: avoid collecting GetSerializeSize data when compact block logging is disabled

2026-01-20 15:41:30 -08:00

core_io.h

refactor: [move-only] Merge core_io module

2026-01-19 12:57:16 +01:00

core_memusage.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cuckoocache.h

…

dbwrapper.cpp

refactor: Add Chainstate::StoragePath() method

2025-12-12 06:49:59 -04:00

dbwrapper.h

refactor: Add Chainstate::StoragePath() method

2025-12-12 06:49:59 -04:00

deploymentinfo.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

deploymentinfo.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

deploymentstatus.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

deploymentstatus.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

dummywallet.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

external_signer.cpp

refactor: Avoid copies by using const references or by move-construction

2026-01-14 23:03:47 +01:00

external_signer.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

flatfile.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

flatfile.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

hash.cpp

…

hash.h

…

headerssync.cpp

…

headerssync.h

…

httprpc.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

httprpc.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

httpserver.cpp

Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods

2026-01-21 13:23:43 +01:00

httpserver.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

i2p.cpp

log: Remove brittle and confusing LogPrintLevel

2025-12-13 13:43:24 +01:00

i2p.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

indirectmap.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

init.cpp

Merge bitcoin/bitcoin#34224: init: Return EXIT_SUCCESS on interrupt

2026-01-13 15:23:12 -08:00

init.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

key_io.cpp

…

key_io.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

key.cpp

…

key.h

…

logging.cpp

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

logging.h

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

mapport.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

mapport.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

memusage.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

merkleblock.cpp

Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications

2026-01-14 11:38:07 -08:00

merkleblock.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

musig.cpp

…

musig.h

…

net_permissions.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_permissions.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_processing.cpp

log,net: avoid ComputeTotalSize when logging is disabled

2026-01-19 20:20:13 +01:00

net_processing.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

net_types.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_types.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net.cpp

refactor: Use std::reference_wrapper<AddrMan> in Connman

2026-01-15 15:17:07 +01:00

net.h

Merge bitcoin/bitcoin#34302: fuzz: Restore SendMessages coverage in process_message(s) fuzz targets

2026-01-20 16:45:18 +01:00

netaddress.cpp

…

netaddress.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

netbase.cpp

Merge bitcoin/bitcoin#34033: scripted-diff: Unify error and warning log formatting

2025-12-11 09:00:18 -08:00

netbase.h

refactor: Avoid copies by using const references or by move-construction

2026-01-14 23:03:47 +01:00

netgroup.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netgroup.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netmessagemaker.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

noui.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

noui.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

outputtype.cpp

…

outputtype.h

…

pow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

pow.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

prevector.h

…

private_broadcast.cpp

net_processing: retry private broadcast

2025-12-16 17:53:50 +01:00

private_broadcast.h

net_processing: retry private broadcast

2025-12-16 17:53:50 +01:00

protocol.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

protocol.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

psbt.cpp

refactor: Avoid copies by using const references or by move-construction

2026-01-14 23:03:47 +01:00

psbt.h

refactor: Avoid copies by using const references or by move-construction

2026-01-14 23:03:47 +01:00

pubkey.cpp

…

pubkey.h

…

random.cpp

…

random.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

randomenv.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

randomenv.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

rest.cpp

rest: reformat uri_prefixes initializer list

2025-12-14 10:04:37 +01:00

rest.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

scheduler.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

scheduler.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

semaphore_grant.h

…

serialize.h

…

signet.cpp

Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count

2026-01-20 15:47:17 -08:00

signet.h

kernel: Remove some unnecessary non-kernel includes

2025-12-21 10:24:09 +01:00

span.h

…

streams.cpp

…

streams.h

…

sync.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

sync.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

threadsafety.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

tinyformat.h

…

torcontrol.cpp

refactor: Use std::bind_front over std::bind

2026-01-20 15:30:46 +01:00

torcontrol.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

txdb.cpp

Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void

2026-01-02 16:49:23 -08:00

txdb.h

Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void

2026-01-02 16:49:23 -08:00

txgraph.cpp

clusterlin: minimize chunks (feature)

2026-01-12 17:38:30 -05:00

txgraph.h

…

txmempool.cpp

Fix compilation for old Boost versions

2025-12-18 22:38:02 +01:00

txmempool.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

txrequest.cpp

Fix compilation for old Boost versions

2025-12-18 22:38:02 +01:00

txrequest.h

doc: fix double-word typos in comments

2025-12-30 12:12:26 -08:00

uint256.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

uint256.h

…

undo.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

validation.cpp

Merge bitcoin/bitcoin#33728: test: Add bitcoin-chainstate test for assumeutxo functionality

2026-01-14 14:30:47 -08:00

validation.h

Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications

2026-01-14 11:38:07 -08:00

validationinterface.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

validationinterface.h

refactor: Convert ChainstateRole enum to struct

2025-12-12 06:49:59 -04:00

versionbits_impl.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

versionbits.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

versionbits.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

walletinitinterface.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00