Wladimir J. van der Laan
2c0fc856a6
Merge #20464 : refactor: Treat CDataStream bytes as uint8_t
...
fa29272459 Remove redundant MakeUCharSpan wrappers (MarcoFalke)
faf4aa2f47 Remove CDataStream::Init in favor of C++11 member initialization (MarcoFalke)
fada14b948 Treat CDataStream bytes as uint8_t (MarcoFalke)
fa8bdb048e refactor: Drop CDataStream constructors in favor of one taking a Span of bytes (MarcoFalke)
faa96f841f Remove unused CDataStream methods (MarcoFalke)
Pull request description:
Using `uint8_t` for raw bytes has a style benefit:
* The signedness is clear from reading the code, as it does not depend on the architecture
Other clean-ups in this pull include:
* Remove unused methods
* Constructor is simplified with `Span`
* Remove `Init()` member in favor of C++11 member initialization
ACKs for top commit:
laanwj:
code review ACK fa29272459
theStack:
ACK fa29272459 🍾
Tree-SHA512: 931ee28bd99843d7e894b48e90e1187ffb0278677c267044b3c0c255069d9bbd9298ab2e539b1002a30b543d240450eaec718ef4ee95a7fd4be0a295e926343f
2021-02-01 15:17:28 +01:00
..
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2021-01-21 09:29:42 -05:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-21 09:29:42 -05:00
2021-01-21 09:29:42 -05:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-25 20:55:36 +00:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-14 16:55:56 +01:00
2021-01-21 09:29:42 -05:00
2020-12-31 09:45:41 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2020-12-31 08:49:10 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-03 18:38:31 +01:00
2021-01-28 14:15:26 -05:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2021-01-08 09:40:50 +01:00
2020-12-10 07:15:42 +01:00
2021-01-02 15:07:07 +01:00
2021-01-21 09:29:42 -05:00
2020-12-10 07:15:42 +01:00
2020-12-16 13:00:47 +00:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2020-12-10 07:15:42 +01:00
2021-01-21 09:29:42 -05:00
2021-01-21 09:29:42 -05:00
2021-01-25 20:55:36 +00:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-23 20:04:37 +01:00
2021-01-23 20:04:37 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-15 19:00:36 +01:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2020-12-15 19:00:36 +01:00
2020-12-10 07:15:42 +01:00
2021-01-25 20:55:36 +00:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-01-21 09:29:42 -05:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2020-12-10 07:15:42 +01:00
2021-01-11 10:37:16 +01:00
2021-01-11 10:37:16 +01:00
2020-12-10 07:15:42 +01:00
2020-12-15 19:00:36 +01:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2020-12-10 07:15:42 +01:00
2021-01-23 20:04:37 +01:00
2021-02-01 15:17:28 +01:00