highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-11 17:52:48 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
e2dfeb0146da046ad34655b17941e54e4b3d7769
bitcoin/src
History
MarcoFalke e2dfeb0146 Merge #13930: doc: Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader 
66e15e8f97 Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader (Sjors Provoost)

Pull request description:

  Salvaged (but slightly modified) from #12138, the comment there was really helpful to wrap my head around that part of the code.

  In addition, a naive reader like yours truly will first think `IsValid(BLOCK_VALID_SCRIPTS)` means the previous block was invalid. But IIUC that's not what  it means. Instead, it means the block hasn't been checked for validity at the `BLOCK_VALID_SCRIPTS` level yet. So in that case the existing text "previous block index isn't valid" is wrong.

Tree-SHA512: 442a319a83290d94697fdf51376463b70454e0f3909d4a45594ddc2e7c26cd19dc703808385a25e26d6d2dddab0aa35ca41722f2e65ee6fe57bbaf62652d3ec8
2018-12-22 21:40:07 +01:00
..
bench
Merge #14172: Refactor and add tests for BlockFilter construction
2018-12-22 14:16:38 +01:00
compat
…
config
…
consensus
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
crypto
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
index
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
interfaces
Remove unreferenced boost headers
2018-11-16 03:20:44 +00:00
leveldb
…
obj
…
obj-test
…
policy
Add locking annotations to feeStats, shortStats and longStats
2018-12-03 00:14:33 +01:00
primitives
Use const in COutPoint class
2018-11-30 12:54:24 +02:00
qt
Merge #14975: qt: Refactoring with QString::toNSString()
2018-12-17 19:53:51 -10:00
rpc
Merge #14811: Mining: Enforce that segwit option must be set in GBT
2018-12-21 13:46:06 +01:00
script
Add descriptor expansion cache
2018-11-28 15:24:49 -08:00
secp256k1
…
support
…
test
Merge #14172: Refactor and add tests for BlockFilter construction
2018-12-22 14:16:38 +01:00
univalue
…
util
Merge #14771: test: Add BOOST_REQUIRE to getters returning optional
2018-11-22 11:37:17 -05:00
wallet
Merge #14653: rpcwallet: Add missing transaction categories to rpc helptexts
2018-12-21 05:57:25 +13:00
zmq
Use RPCHelpMan for all RPCs
2018-11-14 15:33:15 -05:00
.clang-format
…
addrdb.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
addrdb.h
…
addrman.cpp
Make addrman use its local RNG exclusively
2018-12-12 14:22:12 -08:00
addrman.h
Make addrman use its local RNG exclusively
2018-12-12 14:22:12 -08:00
amount.h
…
arith_uint256.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
arith_uint256.h
Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1
2018-12-04 19:55:04 +02:00
attributes.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
base58.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
base58.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #14480: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread
2018-12-07 15:40:50 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge #14480: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread
2018-12-07 15:40:50 +01:00
bitcoind-res.rc
…
bitcoind.cpp
Merge #14521: qt, docs: Fix bitcoin-qt -version output formatting
2018-11-23 10:17:46 +01:00
blockencodings.cpp
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
blockencodings.h
disallow oversized CBlockHeaderAndShortTxIDs
2018-11-13 12:41:41 -08:00
blockfilter.cpp
blockfilter: Remove default clause in switch statement.
2018-12-21 23:53:29 -06:00
blockfilter.h
blockfilter: Additional constructors for BlockFilter.
2018-11-06 09:12:54 -08:00
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
validation: Add and use HaveTxsDownloaded where appropriate
2018-12-04 10:51:56 -05:00
chainparams.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
chainparams.h
…
chainparamsbase.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
chainparamsbase.h
…
chainparamsseeds.h
…
checkpoints.cpp
…
checkpoints.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
coins.h
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
compat.h
Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h
2018-11-14 12:19:04 -05:00
compressor.cpp
…
compressor.h
…
core_io.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
core_memusage.h
…
core_read.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
core_write.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
dummywallet.cpp
Remove direct node->wallet calls in init.cpp
2018-11-06 11:44:40 -04:00
fs.cpp
…
fs.h
revert removal of fstream.hpp header in fs.h
2018-11-20 14:41:12 +09:00
hash.cpp
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
hash.h
Merge #13258: uint256: Remove unnecessary crypto/common.h dependency
2018-11-30 18:48:58 +01:00
httprpc.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
httprpc.h
…
httpserver.cpp
http: Remove timeout to exit event loop
2018-11-23 16:54:22 +00:00
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #14741: doc: Indicate -rpcauth option password hashing alg
2018-12-13 13:29:26 +01:00
init.h
Pass chain and client variables where needed
2018-11-06 11:44:40 -04:00
key_io.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
key_io.h
…
key.cpp
…
key.h
…
keystore.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
keystore.h
…
limitedmap.h
…
logging.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
logging.h
…
Makefile.am
Merge #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
2018-11-15 14:39:37 -05:00
Makefile.bench.include
Add Benchmark to test input de-duplication worst case
2018-11-25 10:53:20 +09:00
Makefile.leveldb.include
…
Makefile.qt.include
Merge #12783: macOS: disable AppNap during sync
2018-11-10 10:37:59 +01:00
Makefile.qttest.include
…
Makefile.test.include
Remove duplicate libconsensus linking in test make
2018-11-29 05:30:58 -06:00
memusage.h
…
merkleblock.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
merkleblock.h
…
miner.cpp
[mining] segwit option must be set in GBT
2018-12-10 16:42:14 -05:00
miner.h
[mining] segwit option must be set in GBT
2018-12-10 16:42:14 -05:00
net_processing.cpp
Use a FastRandomContext in LimitOrphanTxSize
2018-12-12 14:22:12 -08:00
net_processing.h
…
net.cpp
Use a local FastRandomContext in a few more places in net
2018-12-12 14:22:12 -08:00
net.h
Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested.
2018-12-04 12:58:02 +01:00
netaddress.cpp
Merge #14728: fix uninitialized read when stringifying an addrLocal
2018-11-23 09:53:20 +01:00
netaddress.h
Merge #14728: fix uninitialized read when stringifying an addrLocal
2018-11-23 09:53:20 +01:00
netbase.cpp
Add missing locking annotations
2018-11-28 09:36:25 +01:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
noui.h
…
outputtype.cpp
…
outputtype.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
pow.cpp
…
pow.h
…
prevector.h
Implement prevector::fill once
2018-11-14 12:19:28 -05:00
protocol.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
protocol.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
Do not permit copying FastRandomContexts
2018-12-12 14:28:16 -08:00
random.h
Do not permit copying FastRandomContexts
2018-12-12 14:28:16 -08:00
rest.cpp
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1
2018-12-04 19:55:04 +02:00
sync.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Pass chain locked variables where needed
2018-11-06 11:44:40 -04:00
timedata.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
torcontrol.h
…
txdb.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
txdb.h
…
txmempool.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
txmempool.h
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
ui_interface.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
ui_interface.h
…
uint256.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
uint256.h
…
undo.h
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
validation.cpp
Merge #13930: doc: Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader
2018-12-22 21:40:07 +01:00
validation.h
Merge #13258: uint256: Remove unnecessary crypto/common.h dependency
2018-11-30 18:48:58 +01:00
validationinterface.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
Remove direct node->wallet calls in init.cpp
2018-11-06 11:44:40 -04:00
warnings.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
warnings.h
…