mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-12 06:53:11 +02:00
fa21edddb2
Make the checks stricter and easier to follow: * Fix a typo. * After the first ban from node 1 wait until node 0 "sees" the ban. * Move the restart_node out of the debug log context, to avoid bloat. * Removed the timeout from the outer/lower exit stack to check "dropped (banned)\n" on node 1, because the inner/top exit stack waits longer. * The inner/top exit stack checks for the both disconnections peer=2 and possibly peer=3 (for v2->v1 retry). * And finally, add a redundant assert to confirm once more that node 0 is has "seen" the ban.
88 lines
3.5 KiB
Python
Executable File
88 lines
3.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-present The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the setban rpc call."""
|
|
|
|
from contextlib import ExitStack
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
p2p_port,
|
|
assert_equal,
|
|
)
|
|
|
|
class SetBanTests(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.setup_clean_chain = True
|
|
self.extra_args = [[],[]]
|
|
|
|
def is_banned(self, node, addr):
|
|
return any(e['address'] == addr for e in node.listbanned())
|
|
|
|
def run_test(self):
|
|
# Node 0 connects to Node 1, check that the noban permission is not granted
|
|
self.connect_nodes(0, 1)
|
|
peerinfo = self.nodes[1].getpeerinfo()[0]
|
|
assert "noban" not in peerinfo["permissions"]
|
|
|
|
# Node 0 gets banned by Node 1
|
|
self.nodes[1].setban("127.0.0.1", "add")
|
|
self.wait_until(lambda: not self.nodes[0].is_connected_to(self.nodes[1]))
|
|
|
|
# Node 0 should not be able to reconnect
|
|
self.restart_node(1, [])
|
|
context = ExitStack()
|
|
context.enter_context(self.nodes[1].assert_debug_log(expected_msgs=["dropped (banned)\n"]))
|
|
# When disconnected right after connecting, a v2 node will attempt to reconnect with v1.
|
|
# Wait for all disconnects on node0, so that it cannot mess with later tests.
|
|
context.enter_context(self.nodes[0].assert_debug_log(
|
|
expected_msgs=[
|
|
"retrying with v1 transport protocol for peer=2",
|
|
"Cleared nodestate for peer=2",
|
|
"Cleared nodestate for peer=3",
|
|
] if self.options.v2transport else [
|
|
"Cleared nodestate for peer=2", # Just one v1 disconnect to wait for
|
|
],
|
|
timeout=8))
|
|
with context:
|
|
self.nodes[0].addnode("127.0.0.1:" + str(p2p_port(1)), "onetry")
|
|
assert not self.nodes[0].is_connected_to(self.nodes[1])
|
|
|
|
# However, node 0 should be able to reconnect if it has noban permission
|
|
self.restart_node(1, ['-whitelist=127.0.0.1'])
|
|
self.connect_nodes(0, 1)
|
|
peerinfo = self.nodes[1].getpeerinfo()[0]
|
|
assert "noban" in peerinfo["permissions"]
|
|
|
|
# If we remove the ban, Node 0 should be able to reconnect even without noban permission
|
|
self.nodes[1].setban("127.0.0.1", "remove")
|
|
self.restart_node(1, [])
|
|
self.connect_nodes(0, 1)
|
|
peerinfo = self.nodes[1].getpeerinfo()[0]
|
|
assert "noban" not in peerinfo["permissions"]
|
|
|
|
self.log.info("Test that a non-IP address can be banned/unbanned")
|
|
node = self.nodes[1]
|
|
tor_addr = "pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion"
|
|
ip_addr = "1.2.3.4"
|
|
assert not self.is_banned(node, tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
node.setban(tor_addr, "add")
|
|
assert self.is_banned(node, tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
node.setban(tor_addr, "remove")
|
|
assert not self.is_banned(self.nodes[1], tor_addr)
|
|
assert not self.is_banned(node, ip_addr)
|
|
|
|
self.log.info("Test -bantime")
|
|
self.restart_node(1, ["-bantime=1234"])
|
|
self.nodes[1].setban("127.0.0.1", "add")
|
|
banned = self.nodes[1].listbanned()[0]
|
|
assert_equal(banned['ban_duration'], 1234)
|
|
|
|
if __name__ == '__main__':
|
|
SetBanTests(__file__).main()
|