mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-11 20:30:27 +02:00

History

Wladimir J. van der Laan 68c7acf6bb

Merge #20671 : Replace boost::optional with std::optional

fa4435e22f78f632a455016ce00a357009aac059 Replace boost::optional with std::optional (MarcoFalke)
fa7e803f3e4df33117927aef6fef9bfaee4f410d Remove unused MakeOptional (MarcoFalke)
fadd4029dced574778ade228931a7706f92bc676 psbt: Assert that tx has a value in UpdatePSBTOutput (MarcoFalke)

Pull request description:

  Now that we can use std::optional from the vanilla standard library, drop the third-party boost dependency

ACKs for top commit:
  practicalswift:
    cr ACK fa4435e22f78f632a455016ce00a357009aac059: patch looks correct!
  laanwj:
    code review ACK fa4435e22f78f632a455016ce00a357009aac059
  hebasto:
    ACK fa4435e22f78f632a455016ce00a357009aac059, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 50c5a1a130cac65e043e0177ba5b009fc2ba09343af4e23322ff2eb32184a55f8f2dea66e7a1b9d9acf56bc164eef4e47448750549a07f3b661199ac9bf9afef

2020-12-21 13:12:16 +01:00

check-doc.py

Remove -zapwallettxes

2020-08-31 12:39:19 -04:00

check-rpc-mappings.py

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

commit-script-check.sh

test: Mention commit id in scripted diff error

2020-10-03 13:50:52 +02:00

extended-lint-all.sh

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

extended-lint-cppcheck.sh

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

git-subtree-check.sh

test: Add option to git-subtree-check to do full check, add help

2020-12-04 09:36:17 +01:00

lint-all.sh

Run all lint scripts

2019-05-16 16:42:59 +02:00

lint-assertions.sh

util: Add Assert identity function

2020-06-15 07:39:08 -04:00

lint-circular-dependencies.sh

Remove the remaining fee estimation globals

2020-12-03 12:56:37 +01:00

lint-cpp.sh

lint: add C++ code linter

2020-09-01 14:23:08 +08:00

lint-filenames.sh

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

lint-format-strings.py

Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan

2020-01-23 16:35:08 -05:00

lint-format-strings.sh

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

lint-git-commit-check.sh

ci: Drop Travis-specific way to set COMMIT_RANGE variable

2020-12-21 12:10:59 +02:00

lint-include-guards.sh

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

lint-includes.sh

Replace boost::optional with std::optional

2020-12-19 09:46:55 +01:00

lint-locale-dependence.sh

Merge #18817 : doc: Document differences in bitcoind and bitcoin-qt locale handling

2020-08-29 10:03:45 +02:00

lint-logs.sh

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

lint-python-mutable-default-parameters.sh

lint: Catch use of [] or {} as default parameter values in Python functions

2019-08-26 10:53:10 +00:00

lint-python-utf8-encoding.sh

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

lint-python.sh

swapped "is" for "==" in literal comparison

2020-11-09 10:21:51 -05:00

lint-qt.sh

test: Add lint to prevent SIGNAL/SLOT connect style

2018-08-21 09:43:55 +01:00

lint-shebang.sh

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

lint-shell-locale.sh

macOS fix: Work around empty (sub)expression error when using BSD grep

2018-08-31 00:52:48 +02:00

lint-shell.sh

ci: Drop Travis-specific workaround for shellcheck

2020-12-21 12:11:00 +02:00

lint-spelling.ignore-words.txt

Make lint-spelling.py happy

2020-06-19 02:20:04 -07:00

lint-spelling.sh

test: Add crc32c exception to various linters and generation scripts

2020-01-28 17:01:48 +01:00

lint-submodule.sh

ci: Check for submodules

2020-02-10 16:48:15 +01:00

lint-tests.sh

Obsolete #!/bin/bash shebang

2018-06-20 11:12:41 +03:00

lint-whitespace.sh

ci: Drop Travis-specific way to set COMMIT_RANGE variable

2020-12-21 12:10:59 +02:00

README.md

test: Add option to git-subtree-check to do full check, add help

2020-12-04 09:36:17 +01:00

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs. Scripted diffs are only assumed to run on the latest LTS release of Ubuntu. Running them on other operating systems might require installing GNU tools, such as GNU sed.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

Usage: test/lint/git-subtree-check.sh [-r] DIR [COMMIT]
       test/lint/git-subtree-check.sh -?

DIR is the prefix within the repository to check.
COMMIT is the commit to check, if it is not provided, HEAD will be used.
-r checks that subtree commit is present in repository.

To do a full check with -r, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)
for src/crc32c: https://github.com/google/crc32c.git (branch master)

To do so, add the upstream repository as remote:

git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git

lint-all.sh

Calls other scripts with the lint- prefix.