mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-19 14:53:43 +01:00
992c714451
The previous behavior was the result of casting the result returned from the libevent function evhttp_uridecode to std:string but this was probably not intended.
40 lines
1.4 KiB
C++
40 lines
1.4 KiB
C++
// Copyright (c) 2015-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <common/url.h>
|
|
|
|
#include <charconv>
|
|
#include <string>
|
|
#include <string_view>
|
|
#include <system_error>
|
|
|
|
std::string UrlDecode(std::string_view url_encoded)
|
|
{
|
|
std::string res;
|
|
res.reserve(url_encoded.size());
|
|
|
|
for (size_t i = 0; i < url_encoded.size(); ++i) {
|
|
char c = url_encoded[i];
|
|
// Special handling for percent which should be followed by two hex digits
|
|
// representing an octet values, see RFC 3986, Section 2.1 Percent-Encoding
|
|
if (c == '%' && i + 2 < url_encoded.size()) {
|
|
unsigned int decoded_value{0};
|
|
auto [p, ec] = std::from_chars(url_encoded.data() + i + 1, url_encoded.data() + i + 3, decoded_value, 16);
|
|
|
|
// Only if there is no error and the pointer is set to the end of
|
|
// the string, we can be sure both characters were valid hex
|
|
if (ec == std::errc{} && p == url_encoded.data() + i + 3) {
|
|
res += static_cast<char>(decoded_value);
|
|
// Next two characters are part of the percent encoding
|
|
i += 2;
|
|
continue;
|
|
}
|
|
// In case of invalid percent encoding, add the '%' and continue
|
|
}
|
|
res += c;
|
|
}
|
|
|
|
return res;
|
|
}
|