Ava Chow 4bcef32a93 Merge bitcoin/bitcoin#28312: test: fix keys_to_multisig_script (P2MS) helper for n/k > 16 ...

5cf0a1f230 test: add `createmultisig` P2MS encoding test for all n (1..20) (Sebastian Falbesoner)
0570d2c204 test: add unit test for `keys_to_multisig_script` (Sebastian Falbesoner)
0c41fc3fa5 test: fix `keys_to_multisig_script` (P2MS) helper for n/k > 16 (Sebastian Falbesoner)

Pull request description:

  While reviewing #28307, I noticed that the test framework's `key_to_multisig_script` helper (introduced in #23305) is broken for pubkey count (n) and threshold (k) values larger than 16. This is due to the implementation currently enforcing a direct single-byte data push (using `CScriptOp.encode_op_n`), which obviously fails for values 17+. Fix that by passing the numbers directly to the CScript list, where it's automatically converted to minimally-encoded pushes (see class method `CScript.__coerce_instance`, branch `isinstance(other, int)`).

  The second commit adds a unit test to ensure that the encoding  is correct.

ACKs for top commit:
  achow101:
    ACK 5cf0a1f230
  tdb3:
    ACK 5cf0a1f230
  rkrux:
    reACK [5cf0a1f](5cf0a1f230)

Tree-SHA512: 4168a165c3f483ec8e37a27dba1628a7ea0063545a2b7e74d9e20d753fddd7e33d37e1a190434fa6dca39adf9eef5d0211f7a0c1c7b44979f0a3bb350e267562

2024-06-17 15:18:08 -04:00

..

crypto

crypto: add NUMS_H const

2024-05-14 10:24:31 +02:00

__init__.py

…

address.py

test: add MiniWallet tagging support to avoid UTXO mixing

2024-05-05 12:33:34 +02:00

authproxy.py

test: use json-rpc 2.0 in all functional tests by default

2024-06-07 09:26:55 -04:00

bdb.py

…

bip340_test_vectors.csv

…

blockfilter.py

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

blocktools.py

[test]: remove duplicate WITNESS_SCALE_FACTOR

2024-05-03 10:30:50 +01:00

coverage.py

test: fix PEP484 no implicit optional argument types errors

2023-06-29 16:14:07 -06:00

descriptors.py

…

key.py

Merge bitcoin/bitcoin#28374: test: python cryptography required for BIP 324 functional tests

2023-11-07 16:48:57 -05:00

mempool_util.py

test: use tagged ephemeral MiniWallet instance in fill_mempool

2024-05-05 12:36:51 +02:00

messages.py

refactor: Rename CTransaction::nVersion to version

2024-06-07 13:55:23 -04:00

netutil.py

test: cover UNIX sockets in feature_proxy.py

2024-03-01 14:47:29 -05:00

p2p.py

scripted-diff: test: Use int.to_bytes over struct packing

2024-05-07 15:40:47 +02:00

psbt.py

test: PSBT: eliminate magic numbers for global unsigned tx key (0)

2023-03-04 12:43:38 +01:00

script_util.py

test: add unit test for keys_to_multisig_script

2024-06-05 16:18:31 +02:00

script.py

refactor: Rename CTransaction::nVersion to version

2024-06-07 13:55:23 -04:00

segwit_addr.py

…

socks5.py

test: add keep_alive option to socks5 proxy in test_framework

2023-07-10 10:07:45 -04:00

test_framework.py

test: Remove redundant verack check

2024-06-10 07:58:10 +02:00

test_node.py

Merge bitcoin/bitcoin#30132: indexes: Don't wipe indexes again when continuing a prior reindex

2024-06-10 10:12:30 -04:00

test_shell.py

…

util.py

test: refactor: move fill_mempool to new module mempool_util

2024-05-05 12:33:30 +02:00

v2_p2p.py

[test] make v2transport arg in addconnection mandatory and few cleanups

2024-01-31 22:37:54 +05:30

wallet_util.py

Fix typos in description.md and wallet_util.py

2024-04-25 16:14:10 +08:00

wallet.py

Merge bitcoin/bitcoin#29325: consensus: Store transaction nVersion as uint32_t

2024-06-12 10:32:31 +01:00