Ava Chow 256e170319 Merge bitcoin/bitcoin#29777: test: refactor: introduce and use calculate_input_weight helper ...

6d91cb781c test: add unit tests for `calculate_input_weight` (Sebastian Falbesoner)
f81fad5e0f test: introduce and use `calculate_input_weight` helper (Sebastian Falbesoner)

Pull request description:

  Rather than manually estimating an input's weight by adding up all the involved components (fixed-size skeleton, compact-serialized lengths, and the actual scriptSig / witness stack items) we can simply take use of the serialization classes `CTxIn` / `CTxInWitness` instead, to achieve the same with significantly less code.

  The new helper is used in the functional tests rpc_psbt.py and wallet_send.py, where the previous manual estimation code was
  duplicated. Unit tests are added in the second commit.

ACKs for top commit:
  kevkevinpal:
    tACK [6d91cb7](6d91cb781c)
  QureshiFaisal:
    tACK [6d91cb7](6d91cb781c)
  achow101:
    ACK 6d91cb781c
  AngusP:
    tACK 6d91cb781c
  rkrux:
    tACK [6d91cb7](6d91cb781c)

Tree-SHA512: 04424e4d94d0e13745a9c11df2dd3697c98552bbb0e792c4af67ecbb66060adc3cc0cefc202cdee2d9db0baf85b8bedf2eb339ac4b316d986b5f10f6b70c5a33

2024-04-22 18:51:59 -04:00

..

crypto

test: speedup bip324_cipher.py unit test

2024-02-06 01:35:03 +01:00

__init__.py

…

address.py

…

authproxy.py

…

bdb.py

…

bip340_test_vectors.csv

…

blockfilter.py

…

blocktools.py

…

coverage.py

…

descriptors.py

…

key.py

…

messages.py

test: p2p: check disconnect due to lack of desirable service flags

2024-03-11 15:23:09 +01:00

netutil.py

test: cover UNIX sockets in feature_proxy.py

2024-03-01 14:47:29 -05:00

p2p.py

test: makes timeout a forced named argument in tests methods that use it

2024-03-27 15:33:07 +01:00

psbt.py

…

script_util.py

…

script.py

test: Fix SegwitV0SignatureMsg nLockTime signedness

2024-02-07 12:07:44 +01:00

segwit_addr.py

…

socks5.py

…

test_framework.py

Merge bitcoin/bitcoin#29498: test: Update --tmpdir doc string to say directory must not exist

2024-04-09 09:43:28 +02:00

test_node.py

Merge bitcoin/bitcoin#29279: test: p2p: check disconnect due to lack of desirable service flags

2024-03-19 17:22:04 +00:00

test_shell.py

…

util.py

fixup: get all utxos up front in fill_mempool, discourage wallet mixing

2024-04-15 18:22:32 +02:00

v2_p2p.py

[test] make v2transport arg in addconnection mandatory and few cleanups

2024-01-31 22:37:54 +05:30

wallet_util.py

test: add unit tests for calculate_input_weight

2024-04-05 01:09:31 +02:00

wallet.py

test framework: Add and use option for tx-version in MiniWallet methods

2024-02-08 21:50:55 +00:00