highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-21 15:50:07 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
eaf6be0114a6d7763767da9496907fe8a670ff9e
bitcoin/src/wallet
History
Samuel Dobson e9d6eb1b80 Merge bitcoin/bitcoin#22217: refactor: Avoid wallet code writing node settings file 
49ee2a0ad8 Avoid wallet code writing node settings file (Russell Yanofsky)

Pull request description:

  Change wallet loading code to access settings through the Chain interface instead of writing settings.json directly. This is for running wallet and node in separate processes, since multiprocess code wouldn't easily work with different processes updating the same file.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10). The commit was first part of larger PR #10102.

ACKs for top commit:
  jamesob:
    ACK 49ee2a0ad8 ([`jamesob/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co`](https://github.com/jamesob/bitcoin/tree/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co))
  ryanofsky:
    > ACK [49ee2a0](49ee2a0ad8) ([`jamesob/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co`](https://github.com/jamesob/bitcoin/tree/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co))
  Zero-1729:
    crACK 49ee2a0ad8
  meshcollider:
    Code review ACK 49ee2a0ad8

Tree-SHA512: a81c63b87816f739e02e3992808f314294d6c7213babaafdaaf3c4650ebc97ee4f98f9a4684ce4ff87372df59989b8ad5929159c5686293a7cce04e97e2fabba
2021-08-19 10:44:25 +12:00
..
test
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
bdb.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
bdb.h
wallet: Add BerkeleyDB version sanity check at init time
2021-01-17 18:10:20 +01:00
coincontrol.cpp
refactor: Drop CCoinControl::SetNull
2021-04-18 21:10:47 +01:00
coincontrol.h
rpc: include_unsafe option for fundrawtransaction
2021-04-30 18:53:47 +02:00
coinselection.cpp
wallet: Use GetSelectionAmount for target value calculations
2021-08-13 00:34:02 -04:00
coinselection.h
Have OutputGroup determine the value to use
2021-05-19 15:35:11 -04:00
context.cpp
Remove g_rpc_chain global
2020-05-28 02:13:19 -04:00
context.h
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
crypter.cpp
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
crypter.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
db.cpp
Merge bitcoin/bitcoin#21944: wallet: Fix issues when walletdir is root directory
2021-06-09 22:53:36 +12:00
db.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
dump.cpp
refactor: move first run detection to client code
2021-05-19 08:50:16 +02:00
dump.h
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
external_signer_scriptpubkeyman.cpp
Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets
2021-06-18 09:12:44 +12:00
external_signer_scriptpubkeyman.h
refactor: remove m_internal from DescriptorSPKman
2021-06-30 08:37:50 +02:00
feebumper.cpp
Replace size/weight estimate tuple with struct for named fields
2021-05-26 07:33:09 +08:00
feebumper.h
wallet: Avoid translating RPC errors when creating txs
2020-05-01 07:39:06 -04:00
fees.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
fees.h
…
init.cpp
Merge bitcoin/bitcoin#18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100
2021-05-26 19:32:51 +08:00
interfaces.cpp
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
ismine.h
doc: Add developer documentation to isminetype
2021-01-19 19:04:45 +08:00
load.cpp
Merge bitcoin/bitcoin#22217: refactor: Avoid wallet code writing node settings file
2021-08-19 10:44:25 +12:00
load.h
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
receive.cpp
MOVEONLY: CWallet transaction code out of wallet.cpp/.h
2021-05-26 06:32:51 -05:00
receive.h
MOVEONLY: CWallet transaction code out of wallet.cpp/.h
2021-05-26 06:32:51 -05:00
rpcdump.cpp
wallet: use PACKAGE_NAME instead of "Bitcoin" in rpcdump
2021-08-16 16:04:53 +08:00
rpcwallet.cpp
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
rpcwallet.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
salvage.cpp
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
salvage.h
wallettool: Have RecoverDatabaseFile return errors and warnings
2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp
Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors
2021-08-09 14:45:12 +12:00
scriptpubkeyman.h
Merge bitcoin/bitcoin#22337: wallet: Use bilingual_str for errors
2021-08-09 14:45:12 +12:00
spend.cpp
wallet: Assert that enough was selected to cover the fees
2021-08-13 00:34:47 -04:00
spend.h
MOVEONLY: CWallet transaction code out of wallet.cpp/.h
2021-05-26 06:32:51 -05:00
sqlite.cpp
wallet: refactor: dedup sqlite PRAGMA assignments
2021-05-17 17:22:36 +02:00
sqlite.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
transaction.cpp
MOVEONLY: CWallet transaction code out of wallet.cpp/.h
2021-05-26 06:32:51 -05:00
transaction.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
wallet.cpp
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
wallet.h
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
walletdb.cpp
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
walletdb.h
refactor: remove ::vpwallets and related global variables
2021-08-17 04:05:15 -04:00
wallettool.cpp
refactor: move first run detection to client code
2021-05-19 08:50:16 +02:00
wallettool.h
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
walletutil.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
walletutil.h
wallet: Upgrade existing descriptor caches
2021-06-24 13:49:22 -04:00