highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
eb137184482cea8a2a7cdfcd3c73ec6ae5fdd0d6
bitcoin/src
History
Ava Chow eb13718448 Merge bitcoin/bitcoin#31179: RPC: Add reserve member function to UniValue and use it in blockToJSON function 
5d82d92aff rpc: reserve space for `UniValue` variables  in `blockToJSON` (ismaelsadeeq)
6a506d5c37 UniValue: add reserve member function (ismaelsadeeq)
bd461195f4 bench: support benching all verbosity of `BlockToJson` (ismaelsadeeq)

Pull request description:

  This PR is motivated by https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-2444881418,
  It adds a `reserve` member function to `UniValue` and applies it within the `blockToJSON` function to pre-allocate memory, minimizing reallocation's.

  <details>
  <summary>Slight performance increase in verbosity 1</summary>

  On **master**:

  |         ns/op |        op/s |  err% | total | benchmark              |
  |--------------:|------------:|------:|------:|:------------------------|
  |      190,342  |     5,254   |  2.3% |  0.01 | `BlockToJsonVerbose1`   |
  |  34,812,292   |       28.73 |  1.0% |  0.38 | `BlockToJsonVerbose2`   |
  |  34,457,167   |       29.02 |  1.0% |  0.38 | `BlockToJsonVerbose3`   |

  On **this PR**:

  |         ns/op |        op/s |  err% | total | benchmark              |
  |--------------:|------------:|------:|------:|:------------------------|
  |      172,278  |     5,805   |  0.7% |  0.01 | `BlockToJsonVerbose1`   |
  |  33,720,584   |       29.66 |  0.4% |  0.37 | `BlockToJsonVerbose2`   |
  |  33,884,417   |       29.51 |  1.2% |  0.38 | `BlockToJsonVerbose3`   |
  </details>

ACKs for top commit:
  maflcko:
    review ACK 5d82d92aff 🐀
  l0rinc:
    ACK 5d82d92aff
  achow101:
    ACK 5d82d92aff
  Eunovo:
    Re-ACK 5d82d92aff

Tree-SHA512: bdd2c1bcdc4d060d30ad3be0b10f0d722dda0c2286bc4156af851503220e8854e76a4dc53456826b543c110982455268838172d3a1026eee754d4c673b48ea05
2025-07-23 13:29:07 -07:00
..
bench
Merge bitcoin/bitcoin#31179: RPC: Add reserve member function to UniValue and use it in blockToJSON function
2025-07-23 13:29:07 -07:00
common
Merge bitcoin/bitcoin#32673: clang-tidy: Apply modernize-deprecated-headers
2025-06-11 15:08:23 -07:00
compat
build: simplify *ifaddr handling
2025-05-08 16:49:58 +01:00
consensus
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
crc32c
Update crc32c subtree to latest upstream master
2024-02-27 18:28:19 +00:00
crypto
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
index
refactor: cleanup index logging
2025-07-11 15:18:22 +02:00
init
refactor: Avoid using IsArgSet() on -debug, -loglevel, and -vbparams list options
2025-02-13 12:30:15 -05:00
interfaces
Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant
2025-07-11 13:47:19 -04:00
ipc
refactor: modernize deprecated ipc headers
2025-06-19 16:29:55 +02:00
kernel
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
leveldb
Update leveldb subtree to latest upstream
2025-05-30 16:51:49 +01:00
logging
scripted-diff: modernize outdated trait patterns - values
2025-02-21 10:43:01 +01:00
minisketch
Update minisketch subtree to latest upstream
2025-05-13 18:07:47 +01:00
node
Merge bitcoin/bitcoin#32827: mempool: Avoid needless vtx iteration during IBD
2025-07-21 11:01:12 -04:00
policy
Merge bitcoin/bitcoin#32521: policy: make pathological transactions packed with legacy sigops non-standard
2025-07-18 13:24:54 -07:00
primitives
Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant
2025-07-11 13:47:19 -04:00
qt
Merge bitcoin/bitcoin#32940: cmake: Use newer signature of qt6_add_lrelease when available
2025-07-11 14:26:16 +01:00
rpc
Merge bitcoin/bitcoin#31179: RPC: Add reserve member function to UniValue and use it in blockToJSON function
2025-07-23 13:29:07 -07:00
script
Merge bitcoin/bitcoin#32564: miniscript, refactor: Make operator""_mst consteval (re-take)
2025-07-02 15:06:33 +01:00
secp256k1
Update secp256k1 subtree to latest master
2025-07-22 09:35:01 +01:00
support
doc: remove For ... comments
2025-05-19 16:40:33 +01:00
test
Merge bitcoin/bitcoin#32945: tests: speed up coins_tests by parallelizing
2025-07-22 11:19:18 -07:00
univalue
Merge bitcoin/bitcoin#31179: RPC: Add reserve member function to UniValue and use it in blockToJSON function
2025-07-23 13:29:07 -07:00
util
optimization: peel align-head and unroll body to 64 bytes
2025-07-16 14:37:19 -07:00
wallet
wallet: remove outdated pszSkip arg of database Rewrite func
2025-07-16 14:27:17 +05:30
zmq
chore: use std::vector<std::byte> for BlockManager::ReadRawBlock()
2025-06-13 19:19:44 +03:00
.clang-format
…
.clang-tidy
clang-tidy: Apply modernize-deprecated-headers
2025-06-03 15:13:54 +02:00
addrdb.cpp
log: Properly log warnings with warn loglevel in addrdb
2025-07-10 11:24:40 +02:00
addrdb.h
…
addresstype.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addresstype.h
refactor: deduplicate anchor witness program bytes (0x4e,0x73)
2025-03-23 21:58:39 +01:00
addrman_impl.h
Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t
2024-09-20 12:55:22 -04:00
addrman.cpp
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
addrman.h
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
arith_uint256.cpp
Add a fuzz test for Num3072 multiplication and inversion
2025-01-09 10:11:46 -05:00
arith_uint256.h
arith_uint256: modernize comparison operators
2025-04-07 10:45:13 -04:00
attributes.h
…
banman.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
banman.h
doc: remove For ... comments
2025-05-19 16:40:33 +01:00
base58.cpp
clang-tidy: Apply modernize-deprecated-headers
2025-06-03 15:13:54 +02:00
base58.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
bech32.cpp
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
bech32.h
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
bip324.cpp
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
bip324.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
bitcoin-chainstate.cpp
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
bitcoin-cli-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-cli.cpp
cli: Reject + sign in -netinfo level parsing
2025-05-15 19:48:38 +02:00
bitcoin-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-tx-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-tx.cpp
bitcoin-tx: Reject + sign in MutateTxDel*
2025-05-17 09:36:25 +02:00
bitcoin-util-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-util.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-wallet-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-wallet.cpp
Remove create options from wallet tool
2025-05-09 15:07:04 +02:00
bitcoin.cpp
multiprocess: Add bitcoin wrapper executable
2025-05-12 14:49:17 -04:00
bitcoind-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoind.cpp
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
blockencodings.cpp
p2p: Add witness mutation check inside FillBlock
2025-06-10 10:07:56 -04:00
blockencodings.h
p2p: remove vestigial READ_STATUS_CHECKBLOCK_FAILED
2025-06-10 10:07:56 -04:00
blockfilter.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
blockfilter.h
…
chain.cpp
…
chain.h
validation: Don't use IsValid() to filter for invalid blocks
2025-06-12 14:40:59 -04:00
chainparams.cpp
test: Reject + sign when parsing regtest deployment params
2025-05-15 22:12:24 +02:00
chainparams.h
…
chainparamsbase.cpp
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
chainparamsbase.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsseeds.h
seeds: update fixed dns seeds
2025-03-06 15:39:58 -06:00
checkqueue.h
validation: use a lock for CCheckQueueControl
2025-05-19 22:06:48 +00:00
clientversion.cpp
doc: update MIT license URL
2025-05-20 09:30:41 +01:00
clientversion.h
windows: Use predefined RC_INVOKED macro instead of custom one
2025-05-29 11:18:36 +01:00
cluster_linearize.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
CMakeLists.txt
Squashed 'src/secp256k1/' changes from 4187a46649..b9313c6e1a
2025-07-22 09:35:01 +01:00
coins.cpp
Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests
2024-12-04 14:09:05 -05:00
coins.h
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
compressor.cpp
…
compressor.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
core_io.h
rpc: add getdescriptoractivity
2024-11-26 20:47:08 -05:00
core_memusage.h
…
core_read.cpp
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
core_write.cpp
rpc: reserve space for UniValue variables in blockToJSON
2025-01-22 17:31:22 -05:00
cuckoocache.h
doc: remove For ... comments
2025-05-19 16:40:33 +01:00
dbwrapper.cpp
refactor: encapsulate vector/array keys into Obfuscation
2025-07-16 14:33:07 -07:00
dbwrapper.h
refactor: encapsulate vector/array keys into Obfuscation
2025-07-16 14:33:07 -07:00
deploymentinfo.cpp
scripted-diff: rename gbt_force and gbt_force_name
2025-04-30 14:51:21 +02:00
deploymentinfo.h
scripted-diff: rename gbt_force and gbt_force_name
2025-04-30 14:51:21 +02:00
deploymentstatus.cpp
scripted-diff: modernize outdated trait patterns - types
2025-02-21 10:41:27 +01:00
deploymentstatus.h
versionbits: Simplify VersionBitsCache API
2025-01-21 00:38:03 +10:00
dummywallet.cpp
build, wallet, doc: Remove BDB
2025-05-06 12:21:32 -07:00
external_signer.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
external_signer.h
…
flatfile.cpp
flatfile: check whether the file has been closed successfully
2025-06-16 15:33:19 +02:00
flatfile.h
refactor: Add FlatFileSeq member variables in BlockManager
2024-07-24 09:39:35 +02:00
hash.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
hash.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
headerssync.cpp
[headerssync] update headerssync config for v29
2025-03-04 14:23:18 -05:00
headerssync.h
doc: remove For ... comments
2025-05-19 16:40:33 +01:00
httprpc.cpp
remove RPCTimerInterface and RPCRunLater
2025-07-03 06:26:23 -04:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#32539: init: Configure reachable networks before we start the RPC server
2025-06-06 15:31:36 -07:00
httpserver.h
rpc: increase the defaults for -rpcthreads and -rpcworkqueue
2024-11-04 17:08:21 +01:00
i2p.cpp
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
[prep/config] remove -maxorphantx
2025-07-14 16:13:10 -04:00
init.h
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
key_io.cpp
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
key_io.h
…
key.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
key.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
logging.cpp
log: Add rate limiting to LogPrintf, LogInfo, LogWarning, LogError, LogPrintLevel
2025-07-09 09:13:00 -04:00
logging.h
log: Add rate limiting to LogPrintf, LogInfo, LogWarning, LogError, LogPrintLevel
2025-07-09 09:13:00 -04:00
mapport.cpp
mapport: make ProcessPCP void
2024-11-04 14:19:40 -05:00
mapport.h
mapport: turn -natpmp to on by default
2025-07-17 12:43:04 -04:00
memusage.h
memusage: Add DynamicUsage for std::string
2024-11-04 18:46:40 +01:00
merkleblock.cpp
[clang-tidy] Enable the misc-no-recursion check
2024-04-07 14:04:45 +01:00
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
util: move fees.h and error.h to common/messages.h
2024-05-16 10:16:08 -05:00
net_permissions.h
scripted-diff: modernize outdated trait patterns - types
2025-02-21 10:41:27 +01:00
net_processing.cpp
[prep/test] have TxOrphanage remember its own limits in LimitOrphans
2025-07-14 16:13:10 -04:00
net_processing.h
[prep/test] have TxOrphanage remember its own limits in LimitOrphans
2025-07-14 16:13:10 -04:00
net_types.cpp
rpc: avoid copying into UniValue
2024-05-20 16:48:19 +00:00
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
Explicitly close all AutoFiles that have been written
2025-06-16 15:33:15 +02:00
net.h
threading: semaphore: move CountingSemaphoreGrant to its own header
2025-05-10 03:31:30 +00:00
netaddress.cpp
doc: update URLs
2025-06-03 08:09:21 +01:00
netaddress.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
netbase.cpp
Merge bitcoin/bitcoin#32826: p2p: add more bad ports
2025-06-30 13:28:17 -04:00
netbase.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
node: Use log levels in noui_ThreadSafeMessageBox
2024-03-21 16:41:16 +01:00
noui.h
…
outputtype.cpp
wallet, rpc: Use OUTPUT_TYPES to describe the output types instead of hardcoding them
2025-06-18 18:11:28 -03:00
outputtype.h
wallet, rpc: Use OUTPUT_TYPES to describe the output types instead of hardcoding them
2025-06-18 18:11:28 -03:00
pow.cpp
fuzz: enable running fuzz test cases in Debug mode
2025-04-22 17:11:24 +10:00
pow.h
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
prevector.h
refactor: Remove UB in prevector reverse iterators
2025-05-14 09:35:32 +02:00
protocol.cpp
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
protocol.h
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
psbt.cpp
psbt: use sighash type field to determine whether to remove non-witness utxos
2025-05-14 14:00:43 -07:00
psbt.h
psbt: use sighash type field to determine whether to remove non-witness utxos
2025-05-14 14:00:43 -07:00
pubkey.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
pubkey.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
random.cpp
random: Use modern Windows randomness functions
2025-05-14 22:55:10 -07:00
random.h
random: add fixed-size std::array generation
2025-07-16 13:19:18 -07:00
randomenv.cpp
build: simplify *ifaddr handling
2025-05-08 16:49:58 +01:00
randomenv.h
…
rest.cpp
rest: replace rf_names[0].rf by RESTResponseFormat::UNDEF for code clarity
2025-07-06 11:20:18 +08:00
rest.h
…
scheduler.cpp
thread-safety: fix annotations with REVERSE_LOCK
2025-06-16 18:09:14 +00:00
scheduler.h
kernel: Remove dependency on CScheduler
2024-02-16 17:12:52 +01:00
semaphore_grant.h
threading: semaphore: move CountingSemaphoreGrant to its own header
2025-05-10 03:31:30 +00:00
serialize.h
refactor: re-enable UBSan implicit-sign-change in serialize.h
2025-05-14 15:41:20 +02:00
signet.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
signet.h
…
span.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
streams.cpp
refactor: encapsulate vector/array keys into Obfuscation
2025-07-16 14:33:07 -07:00
streams.h
refactor: encapsulate vector/array keys into Obfuscation
2025-07-16 14:33:07 -07:00
sync.cpp
scripted-diff: modernize outdated trait patterns - values
2025-02-21 10:43:01 +01:00
sync.h
Merge bitcoin/bitcoin#32829: threading: use correct mutex name in reverse_lock fatal error messages
2025-07-07 15:51:37 +01:00
threadsafety.h
thread-safety: modernize thread safety macros
2025-05-08 20:13:46 +00:00
tinyformat.h
refactor: Introduce struct to hold a runtime format string
2025-01-15 12:16:08 +01:00
torcontrol.cpp
config: allow setting -proxy per network
2025-05-13 12:09:40 +02:00
torcontrol.h
config: allow setting -proxy per network
2025-05-13 12:09:40 +02:00
txdb.cpp
refactor: Remove manual CDBBatch size estimation
2025-04-07 15:59:41 +02:00
txdb.h
kernel: Move default cache constants to caches
2025-01-15 15:44:55 +01:00
txgraph.cpp
txgraph: Track multiple potential would-be clusters in Trim (improvement)
2025-07-02 16:01:57 -04:00
txgraph.h
txgraph: Add ability to trim oversized clusters (feature)
2025-07-02 14:52:54 -04:00
txmempool.cpp
mempool: Avoid expensive loop in removeForBlock during IBD
2025-07-18 16:50:42 -07:00
txmempool.h
Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant
2025-07-11 13:47:19 -04:00
txrequest.cpp
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
txrequest.h
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
uint256.cpp
refactor: Remove SetHexDeprecated
2025-04-09 15:59:59 +01:00
uint256.h
refactor: Remove SetHexDeprecated
2025-04-09 15:59:59 +01:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant
2025-07-11 13:47:19 -04:00
validation.h
Merge bitcoin/bitcoin#30479: validation: Add eligible ancestors of reconsidered block to setBlockIndexCandidates
2025-07-09 16:55:43 -07:00
validationinterface.cpp
thread-safety: fix annotations with REVERSE_LOCK
2025-06-16 18:09:14 +00:00
validationinterface.h
doc: fix BlockConnected incorrect comment
2025-07-07 18:14:52 +01:00
versionbits_impl.h
tests: refactor versionbits fuzz test
2025-01-21 00:38:03 +10:00
versionbits.cpp
scripted-diff: rename gbt_force and gbt_force_name
2025-04-30 14:51:21 +02:00
versionbits.h
scripted-diff: rename gbt_force and gbt_force_name
2025-04-30 14:51:21 +02:00
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00